From patchwork Wed Jun 29 03:34:17 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jiawen Wu X-Patchwork-Id: 113535 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 817E4A0572; Wed, 29 Jun 2022 05:26:30 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 74F46410EE; Wed, 29 Jun 2022 05:26:30 +0200 (CEST) Received: from smtpproxy21.qq.com (smtpbg703.qq.com [203.205.195.89]) by mails.dpdk.org (Postfix) with ESMTP id 2CAC8410D5 for ; Wed, 29 Jun 2022 05:26:27 +0200 (CEST) X-QQ-mid: bizesmtp71t1656473177tc5pyo9a Received: from wxdbg.localdomain.com ( [183.129.236.74]) by bizesmtp.qq.com (ESMTP) with id ; Wed, 29 Jun 2022 11:26:17 +0800 (CST) X-QQ-SSF: 01400000000000G0Q000000A0000000 X-QQ-FEAT: xoS364mEyr17WCM+BKgw+/v5fIaezBf8RQ1fqQrrz+SEbhO+AjyRCTiFnDaxe dSBFgFPOa0jwtWj+hzk9wUDHjBHTilsjE9IEeuJxUo/1GS2FgDqBtT1asJZQOKt1ZYL0hz7 qvUoefAYl5d5LbPUh3+ckwv6tiD+lfXTMWOD+6mC7hpk7yFROkaHzMxs0mfRNHK31rmeFc5 WrJdXCQU0dBxs7SsQLPXR1dGVHHmBdji6/dVdSxeBXT54fWtGlRXUsYTiiFvAbMeThk5gWE loJ/DkU9Ek0JBrEca61bp8Xdx9kB2d5zEsaISUi35zaVkAk8sEk0GEfY5dq8vNZ9HVBKpgy iW6IGlQ26uVJh6EJq0nGA+sSoFte/JrihvI9gsX X-QQ-GoodBg: 2 From: Jiawen Wu To: dev@dpdk.org Cc: Jiawen Wu Subject: [PATCH 2/2] net/ngbe: fix customized devices probe failure Date: Wed, 29 Jun 2022 11:34:17 +0800 Message-Id: <20220629033417.958443-2-jiawenwu@trustnetic.com> X-Mailer: git-send-email 2.27.0 In-Reply-To: <20220629033417.958443-1-jiawenwu@trustnetic.com> References: <20220629033417.958443-1-jiawenwu@trustnetic.com> MIME-Version: 1.0 X-QQ-SENDSIZE: 520 Feedback-ID: bizesmtp:trustnetic.com:qybgforeign:qybgforeign10 X-QQ-Bgrelay: 1 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org The devices with OEM subsystem vendor ID failed to be initialized, because flash was read before memory address was set. Fixes: 240422edbf84 ("net/ngbe: support OEM subsystem vendor ID") Signed-off-by: Jiawen Wu --- drivers/net/ngbe/ngbe_ethdev.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/net/ngbe/ngbe_ethdev.c b/drivers/net/ngbe/ngbe_ethdev.c index 308c231183..86c28099c4 100644 --- a/drivers/net/ngbe/ngbe_ethdev.c +++ b/drivers/net/ngbe/ngbe_ethdev.c @@ -363,6 +363,8 @@ eth_ngbe_dev_init(struct rte_eth_dev *eth_dev, void *init_params __rte_unused) rte_eth_copy_pci_info(eth_dev, pci_dev); eth_dev->data->dev_flags |= RTE_ETH_DEV_AUTOFILL_QUEUE_XSTATS; + hw->hw_addr = (void *)pci_dev->mem_resource[0].addr; + /* Vendor and Device ID need to be set before init of shared code */ hw->back = pci_dev; hw->device_id = pci_dev->id.device_id; @@ -381,7 +383,6 @@ eth_ngbe_dev_init(struct rte_eth_dev *eth_dev, void *init_params __rte_unused) hw->sub_system_id = (u16)ssid >> 8 | (u16)ssid << 8; } ngbe_map_device_id(hw); - hw->hw_addr = (void *)pci_dev->mem_resource[0].addr; /* Reserve memory for interrupt status block */ mz = rte_eth_dma_zone_reserve(eth_dev, "ngbe_driver", -1,