From patchwork Thu Jun 30 09:24:22 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Usman Tanveer X-Patchwork-Id: 113569 X-Patchwork-Delegate: jerinj@marvell.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 10067A0545; Thu, 30 Jun 2022 11:24:33 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 8915D40223; Thu, 30 Jun 2022 11:24:32 +0200 (CEST) Received: from mail-wm1-f42.google.com (mail-wm1-f42.google.com [209.85.128.42]) by mails.dpdk.org (Postfix) with ESMTP id 84CE1400EF for ; Thu, 30 Jun 2022 11:24:31 +0200 (CEST) Received: by mail-wm1-f42.google.com with SMTP id j7so1183016wmp.2 for ; Thu, 30 Jun 2022 02:24:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=emumba-com.20210112.gappssmtp.com; s=20210112; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=C1/QziSs66EWKuyPAf13UbpZ4Ve54iSY1uXQGphxHIE=; b=08LD8hiq684xhj3OlTNm/0zwHuHz3HdBJYjc9A+7Wv1rZ/tICHRPwzg1bFBchC6zfk ZwqpX8jYVsvxp1DPAuFjrlxKUEx1jew4qXgfKx2qjwQR2zUyPDuWNUIhexzGxOawQBv1 DVQsb6p2K+2xLXlOFhsG8bcVMgJbvR2W4TTfx+5aRnfHHEZCuWzh0sZ7PSrIEGhtt4Hz wqHvzN0xyWiPBYnvYt74LXxmoRvT8YrJSsYdSsup+2E/rE1DKaipvKoy0HffBle4zuMd fUWmg481UeSzMxmYbZbQCVPdDpc/rfBZmy2ifjmNky4/GNvmkkUnhtMWfTQLHuI6NIVh 8vNw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=C1/QziSs66EWKuyPAf13UbpZ4Ve54iSY1uXQGphxHIE=; b=HXczLY5cBkirECaOJS9pqY7+efObd2RUrGy0OddxsmivQ6XpEzWDTNBeFnucgofUH5 G0iSzwgBhCsx6nV+Dh4YFR/VbqORz54D2EaSgs81YsVMz1cyv81U+VChGPX7XKuRUT/w pnx8snfMfpW5/KZMZ25ymfRvr3vPYJTze0mvz37xGIPY0FYvx1lGCryF9xBtd3I5xvAB msGD38NoiPQB6F49uexOMuopnOJnGMZrir6o+NCf7bsTXm5gJuwFrqez2xqeuQXWp6nA mTIsyKU6ER9PR54yqZOOxJImFcWyMrD0shx4uVGuqwxr9N2p+HjnApXLTuzGtnenjp8p i3sg== X-Gm-Message-State: AJIora8dcORZsAWPpKhn8XEcsyFoBLd9sTNklpUW9yI+Cdm9g0FbTq7j qTsEK60PFMTAA5JafbBZIZsjpqa1Yl+FBg== X-Google-Smtp-Source: AGRyM1tCoivaJKY6gFsKdXubnAHc6cVqNIRJPEQg7Ey/u6yrYRVwBCcUI9sxTAtrBxZUq3cuAyXIWA== X-Received: by 2002:a05:600c:a42:b0:39c:9166:5a55 with SMTP id c2-20020a05600c0a4200b0039c91665a55mr8752593wmq.141.1656581071009; Thu, 30 Jun 2022 02:24:31 -0700 (PDT) Received: from localhost.localdomain ([119.160.59.130]) by smtp.gmail.com with ESMTPSA id i8-20020a1c3b08000000b00397402ae674sm2043746wma.11.2022.06.30.02.24.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 30 Jun 2022 02:24:30 -0700 (PDT) From: Usman Tanveer To: dev@dpdk.org Cc: ciara.power@intel.com, ndabilpuram@marvell.com, kirankumark@marvell.com, skori@marvell.com, skoteshwar@marvell.com, Usman Tanveer Subject: [PATCH] net/cnxk: fix segmentation fault in telemetry Date: Thu, 30 Jun 2022 14:24:22 +0500 Message-Id: <20220630092422.114332-1-usman.tanveer@emumba.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org It gives segmentation fault when no parameter is passed for command '/cnxk/ipsec/info' in usertools/telemetry app as NULL is being passed as parameter to strtoul(). Now this function returns -1 before strtoul() if no parameter is passed. Signed-off-by: Usman Tanveer --- drivers/net/cnxk/cnxk_ethdev_sec_telemetry.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/net/cnxk/cnxk_ethdev_sec_telemetry.c b/drivers/net/cnxk/cnxk_ethdev_sec_telemetry.c index dfad5af8fe..088798d70a 100644 --- a/drivers/net/cnxk/cnxk_ethdev_sec_telemetry.c +++ b/drivers/net/cnxk/cnxk_ethdev_sec_telemetry.c @@ -229,6 +229,9 @@ ethdev_sec_tel_handle_info(const char *cmd __rte_unused, const char *params, uint32_t i; int ret; + if (params == NULL || strlen(params) == 0 || !isdigit(*params)) + return -1; + port_id = strtoul(params, &end_p, 0); if (errno != 0) return -EINVAL;