From patchwork Wed Jul 27 23:01:26 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Cristian Dumitrescu X-Patchwork-Id: 114322 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id E85EBA00C5; Thu, 28 Jul 2022 01:02:36 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 1E8C342BC7; Thu, 28 Jul 2022 01:01:50 +0200 (CEST) Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by mails.dpdk.org (Postfix) with ESMTP id EB25942B81 for ; Thu, 28 Jul 2022 01:01:44 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1658962907; x=1690498907; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=2R+GVO7r3oN9TqFFRzpvaV99DCKCCGwCt5YuQ4wzHKU=; b=J1f5Nc6tTHpwHID+wqgpJF+IK9bR6FP7F4OZcI5lDNsUjM8tQEqR0MP6 G/eyK5+a7lLpSv+ahcnyrrH/bF9Z1KGf2GW43hU1cpGEudOhxeTPJJPho pgGBxxG4pmGeUy1e9nzvj4he96K63tF7aH3oox5eTnbshgyBb6bSMWPta sPhW5v8kMrs70EiOukeNMMEdd2tb46sL2css6EDWSfJczi+chy6wFjOfZ cnsQ/ywQIZK2NL7Tt5B5xo0WJGqLXJ6eZWGUHLYRx4mOmxVI3W85/tlbp whCN/FbFm0qzcuo0Zzj6w5ZWvAqg1gO9LuRfdvYAtQPt5/2NkFpKpYcKn w==; X-IronPort-AV: E=McAfee;i="6400,9594,10421"; a="314150925" X-IronPort-AV: E=Sophos;i="5.93,196,1654585200"; d="scan'208";a="314150925" Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 27 Jul 2022 16:01:44 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.93,196,1654585200"; d="scan'208";a="846444351" Received: from silpixa00400573.ir.intel.com (HELO silpixa00400573.ger.corp.intel.com.) ([10.237.223.157]) by fmsmga006.fm.intel.com with ESMTP; 27 Jul 2022 16:01:43 -0700 From: Cristian Dumitrescu To: dev@dpdk.org Cc: "Kamalakannan R ." Subject: [PATCH V5 11/17] examples/pipeline: remove the obsolete pipeline create CLI command Date: Wed, 27 Jul 2022 23:01:26 +0000 Message-Id: <20220727230132.601114-11-cristian.dumitrescu@intel.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220727230132.601114-1-cristian.dumitrescu@intel.com> References: <20220727225431.600913-1-cristian.dumitrescu@intel.com> <20220727230132.601114-1-cristian.dumitrescu@intel.com> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org The pipeline configuration is now done through the I/O specification file, hence this CLI command is no longer needed. Signed-off-by: Cristian Dumitrescu Signed-off-by: Kamalakannan R. --- examples/pipeline/cli.c | 47 ----------------------------------------- 1 file changed, 47 deletions(-) diff --git a/examples/pipeline/cli.c b/examples/pipeline/cli.c index 28cf8d4178..7b725a9c27 100644 --- a/examples/pipeline/cli.c +++ b/examples/pipeline/cli.c @@ -523,39 +523,6 @@ cmd_tap(char **tokens, } } -static const char cmd_pipeline_create_help[] = -"pipeline create \n"; - -static void -cmd_pipeline_create(char **tokens, - uint32_t n_tokens, - char *out, - size_t out_size, - void *obj) -{ - struct pipeline *p; - char *name; - uint32_t numa_node; - - if (n_tokens != 4) { - snprintf(out, out_size, MSG_ARG_MISMATCH, tokens[0]); - return; - } - - name = tokens[1]; - - if (parser_read_uint32(&numa_node, tokens[3]) != 0) { - snprintf(out, out_size, MSG_ARG_INVALID, "numa_node"); - return; - } - - p = pipeline_create(obj, name, (int)numa_node); - if (!p) { - snprintf(out, out_size, "pipeline create error."); - return; - } -} - static const char cmd_pipeline_port_in_help[] = "pipeline port in \n" " link rxq bsz \n" @@ -3188,7 +3155,6 @@ cmd_help(char **tokens, "\tmempool\n" "\tlink\n" "\ttap\n" - "\tpipeline create\n" "\tpipeline port in\n" "\tpipeline port out\n" "\tpipeline codegen\n" @@ -3241,12 +3207,6 @@ cmd_help(char **tokens, return; } - if ((strcmp(tokens[0], "pipeline") == 0) && - (n_tokens == 2) && (strcmp(tokens[1], "create") == 0)) { - snprintf(out, out_size, "\n%s\n", cmd_pipeline_create_help); - return; - } - if ((strcmp(tokens[0], "pipeline") == 0) && (n_tokens == 3) && (strcmp(tokens[1], "port") == 0)) { if (strcmp(tokens[2], "in") == 0) { @@ -3529,13 +3489,6 @@ cli_process(char *in, char *out, size_t out_size, void *obj) } if (strcmp(tokens[0], "pipeline") == 0) { - if ((n_tokens >= 3) && - (strcmp(tokens[2], "create") == 0)) { - cmd_pipeline_create(tokens, n_tokens, out, out_size, - obj); - return; - } - if ((n_tokens >= 4) && (strcmp(tokens[2], "port") == 0) && (strcmp(tokens[3], "in") == 0)) {