From patchwork Thu Jul 28 15:11:43 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Cristian Dumitrescu X-Patchwork-Id: 114366 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 2514BA00C5; Thu, 28 Jul 2022 17:13:27 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 1CBF042C13; Thu, 28 Jul 2022 17:12:11 +0200 (CEST) Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by mails.dpdk.org (Postfix) with ESMTP id DEFEE42C01 for ; Thu, 28 Jul 2022 17:12:05 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1659021126; x=1690557126; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=7DIJdGBhhTi2g2X6BRxSQ0emsktRdh2ueXI7HokequQ=; b=L3clT/LY5pqaSirz39M4Tksd/f/02Y1fscmuKC6NOzcXUhwgUoFA3bta Ef2J+4Dys+yqvf3Mw783PnCfRrTO8wL0lX5Djz7sHXI1YZxd/gM3dGQwL JF/Sjg2aYVsgeNRfiRnwX8CMFxq927lw2UahOx8h3U5DUaYvhroZxc5ER uv5+ygIl7L9gqEms2NIEiWEyi0DxTAOG2iuidYVrbt/jBVU/A+P/c/OpB bKKbCgwx2hRLQhX+PAIsfITiUyBWwmPS80h3pR+5hLdigt1lumaSle4ba HVr1I5Am9q01yvSMHTHOg/5CEkv9zP5J/2nXycF3Nz5vleUDFQPbel1Iu Q==; X-IronPort-AV: E=McAfee;i="6400,9594,10422"; a="288547411" X-IronPort-AV: E=Sophos;i="5.93,198,1654585200"; d="scan'208";a="288547411" Received: from orsmga001.jf.intel.com ([10.7.209.18]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 28 Jul 2022 08:12:05 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.93,198,1654585200"; d="scan'208";a="633727333" Received: from silpixa00400573.ir.intel.com (HELO silpixa00400573.ger.corp.intel.com.) ([10.237.223.157]) by orsmga001.jf.intel.com with ESMTP; 28 Jul 2022 08:12:04 -0700 From: Cristian Dumitrescu To: dev@dpdk.org Cc: "Kamalakannan R ." Subject: [PATCH V6 13/17] examples/pipeline: remove the obsolete mirroring configuration CLI command Date: Thu, 28 Jul 2022 15:11:43 +0000 Message-Id: <20220728151147.603265-14-cristian.dumitrescu@intel.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220728151147.603265-1-cristian.dumitrescu@intel.com> References: <20220718130713.339003-1-cristian.dumitrescu@intel.com> <20220728151147.603265-1-cristian.dumitrescu@intel.com> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org The pipeline mirroring configuration is done through the I/O specification file, so this CLI command is no longer needed. Signed-off-by: Cristian Dumitrescu Signed-off-by: Kamalakannan R. --- examples/pipeline/cli.c | 76 ----------------------------------------- 1 file changed, 76 deletions(-) diff --git a/examples/pipeline/cli.c b/examples/pipeline/cli.c index b26e73c706..fa828c008b 100644 --- a/examples/pipeline/cli.c +++ b/examples/pipeline/cli.c @@ -2457,68 +2457,6 @@ cmd_pipeline_stats(char **tokens, } } -static const char cmd_pipeline_mirror_help[] = -"pipeline mirror slots sessions \n"; - -static void -cmd_pipeline_mirror(char **tokens, - uint32_t n_tokens, - char *out, - size_t out_size, - void *obj) -{ - struct rte_swx_pipeline_mirroring_params params; - struct pipeline *p; - int status; - - if (n_tokens != 7) { - snprintf(out, out_size, MSG_ARG_MISMATCH, tokens[0]); - return; - } - - if (strcmp(tokens[0], "pipeline")) { - snprintf(out, out_size, MSG_ARG_NOT_FOUND, "pipeline"); - return; - } - - p = pipeline_find(obj, tokens[1]); - if (!p) { - snprintf(out, out_size, MSG_ARG_INVALID, "pipeline_name"); - return; - } - - if (strcmp(tokens[2], "mirror")) { - snprintf(out, out_size, MSG_ARG_NOT_FOUND, "mirror"); - return; - } - - if (strcmp(tokens[3], "slots")) { - snprintf(out, out_size, MSG_ARG_NOT_FOUND, "slots"); - return; - } - - if (parser_read_uint32(¶ms.n_slots, tokens[4])) { - snprintf(out, out_size, MSG_ARG_INVALID, "n_slots"); - return; - } - - if (strcmp(tokens[5], "sessions")) { - snprintf(out, out_size, MSG_ARG_NOT_FOUND, "sessions"); - return; - } - - if (parser_read_uint32(¶ms.n_sessions, tokens[6])) { - snprintf(out, out_size, MSG_ARG_INVALID, "n_sessions"); - return; - } - - status = rte_swx_pipeline_mirroring_config(p->p, ¶ms); - if (status) { - snprintf(out, out_size, "Command failed!\n"); - return; - } -} - static const char cmd_pipeline_mirror_session_help[] = "pipeline mirror session port clone fast | slow " "truncate \n"; @@ -2746,7 +2684,6 @@ cmd_help(char **tokens, "\tpipeline meter set\n" "\tpipeline meter stats\n" "\tpipeline stats\n" - "\tpipeline mirror\n" "\tpipeline mirror session\n" "\tthread pipeline enable\n" "\tthread pipeline disable\n\n"); @@ -2958,12 +2895,6 @@ cmd_help(char **tokens, return; } - if (!strcmp(tokens[0], "pipeline") && - (n_tokens == 2) && !strcmp(tokens[1], "mirror")) { - snprintf(out, out_size, "\n%s\n", cmd_pipeline_mirror_help); - return; - } - if (!strcmp(tokens[0], "pipeline") && (n_tokens == 3) && !strcmp(tokens[1], "mirror") && !strcmp(tokens[2], "session")) { @@ -3217,13 +3148,6 @@ cli_process(char *in, char *out, size_t out_size, void *obj) return; } - if ((n_tokens >= 4) && - (strcmp(tokens[2], "mirror") == 0) && - (strcmp(tokens[3], "slots") == 0)) { - cmd_pipeline_mirror(tokens, n_tokens, out, out_size, obj); - return; - } - if ((n_tokens >= 4) && (strcmp(tokens[2], "mirror") == 0) && (strcmp(tokens[3], "session") == 0)) {