From patchwork Fri Aug 12 13:23:32 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Power, Ciara" X-Patchwork-Id: 114921 X-Patchwork-Delegate: gakhil@marvell.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 4E929A0543; Fri, 12 Aug 2022 15:23:47 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 93850410FC; Fri, 12 Aug 2022 15:23:42 +0200 (CEST) Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by mails.dpdk.org (Postfix) with ESMTP id 6DF9E406A2 for ; Fri, 12 Aug 2022 15:23:40 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1660310620; x=1691846620; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=6isGZosgTRT0piMiTN9fH+NgqFNMo/MEINcFFbGdwdg=; b=NkppdHGKVSw4B0sq0B5gtOxDregnJmsTsO0sJnIZbvzJkYPGcJLeOT9/ d19bkfqHiPvvifhqxC1vTmplRiu5IQeeJjaERVMbeJRCXRpHK5pKXoLa0 FVVqA1HZW437ACQA1nbr786jt+83YE6pAdAf2kMHLAqDEUyqgUvlW/eLz 5SU3L0sJ/7QQQoZzBPMWBwDgv+Hhbz2nJ+NtvvvBhcqo3KXk29/of4mL3 lggi07L57Ofn/w1G1wdFzptVaFurDMuXg+cdDkAInXepxy6YcQOTHGWh1 OAXlAXq/vZt86RosGYhUnJzYZXtyozi7XEzlQIWEHsMCXeDgFXifqrihS g==; X-IronPort-AV: E=McAfee;i="6400,9594,10437"; a="292386740" X-IronPort-AV: E=Sophos;i="5.93,233,1654585200"; d="scan'208";a="292386740" Received: from orsmga003.jf.intel.com ([10.7.209.27]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 12 Aug 2022 06:23:40 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.93,233,1654585200"; d="scan'208";a="556513809" Received: from silpixa00400355.ir.intel.com (HELO silpixa00400355.ger.corp.intel.com) ([10.237.222.49]) by orsmga003.jf.intel.com with ESMTP; 12 Aug 2022 06:23:38 -0700 From: Ciara Power To: Akhil Goyal , Fan Zhang Cc: dev@dpdk.org, kai.ji@intel.com, pablo.de.lara.guarch@intel.com, Ciara Power Subject: [PATCH 1/3] test/crypto: fix wireless auth digest segment Date: Fri, 12 Aug 2022 13:23:32 +0000 Message-Id: <20220812132334.75707-2-ciara.power@intel.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220812132334.75707-1-ciara.power@intel.com> References: <20220812132334.75707-1-ciara.power@intel.com> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org The segment size for some tests was too small to hold the auth digest. This caused issues when using op->sym->auth.digest.data for comparisons in AESNI_MB PMD after a subsequent patch enables SGL. For example, if segment size is 2, and digest size is 4, then 4 bytes are read from op->sym->auth.digest.data, which overflows into the memory after the segment, rather than using the second segment that contains the remaining half of the digest. Fixes: 11c5485bb276 ("test/crypto: add scatter-gather tests for IP and OOP") Signed-off-by: Ciara Power --- app/test/test_cryptodev.c | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/app/test/test_cryptodev.c b/app/test/test_cryptodev.c index 69a0301de0..e6925b6531 100644 --- a/app/test/test_cryptodev.c +++ b/app/test/test_cryptodev.c @@ -3040,6 +3040,14 @@ create_wireless_algo_auth_cipher_operation( remaining_off -= rte_pktmbuf_data_len(sgl_buf); sgl_buf = sgl_buf->next; } + + /* The last segment should be large enough to hold full digest */ + if (sgl_buf->data_len < auth_tag_len) { + rte_pktmbuf_free(sgl_buf->next); + sgl_buf->next = NULL; + rte_pktmbuf_append(sgl_buf, auth_tag_len - sgl_buf->data_len); + } + sym_op->auth.digest.data = rte_pktmbuf_mtod_offset(sgl_buf, uint8_t *, remaining_off); sym_op->auth.digest.phys_addr = rte_pktmbuf_iova_offset(sgl_buf,