From patchwork Mon Aug 15 07:12:21 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Qi Zhang X-Patchwork-Id: 114982 X-Patchwork-Delegate: qi.z.zhang@intel.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 7E045A00C3; Mon, 15 Aug 2022 01:05:56 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id C6E4042BEA; Mon, 15 Aug 2022 01:03:54 +0200 (CEST) Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by mails.dpdk.org (Postfix) with ESMTP id 2715642BC3; Mon, 15 Aug 2022 01:03:52 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1660518232; x=1692054232; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=isqOY/p84pkONiqVfRMVUqf+ojP9tMjmICFUl0+a76Y=; b=SWG+UQ4D7BAewo2OgSCDgxjsIQSbaBlmomLd8iyERdM5eSIq0ipVzIls qKCnfYN2NRrGevOMi6CrZisOcGHVCtJNhRYSrHRPLa2TAJG+l070RfKxE p3A0K8B6J4UR7rb6jEEwOEiLh/CiQFJYGv5u8hZJfUs031d8lMVwD6hLq BwAB2+iRqBs23i0fCXVE753sjgxOUdWj7LViAo86Bqz6K1hkqaxYymg/0 kC6LLzu31oxqvXJZSejU4Jwj+LQ6gT46m58Nq6OjiZ2hRbP58MNAcXNCM lgqRHdoNMvHTjQyhhbXAbOfKyaGwpbK2tfRtpvK71jIUqEdEzQJpf7NPX g==; X-IronPort-AV: E=McAfee;i="6400,9594,10439"; a="289427592" X-IronPort-AV: E=Sophos;i="5.93,237,1654585200"; d="scan'208";a="289427592" Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 14 Aug 2022 16:03:51 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.93,237,1654585200"; d="scan'208";a="934296679" Received: from dpdk-qzhan15-test02.sh.intel.com ([10.67.115.4]) by fmsmga005.fm.intel.com with ESMTP; 14 Aug 2022 16:03:50 -0700 From: Qi Zhang To: qiming.yang@intel.com Cc: dev@dpdk.org, Qi Zhang , stable@dpdk.org, Junfeng Guo Subject: [PATCH 25/70] net/ice/base: fix incorrect function descriptions for parser Date: Mon, 15 Aug 2022 03:12:21 -0400 Message-Id: <20220815071306.2910599-26-qi.z.zhang@intel.com> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20220815071306.2910599-1-qi.z.zhang@intel.com> References: <20220815071306.2910599-1-qi.z.zhang@intel.com> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Some function descriptions for parser are mismatched, thus fixed with this patch. Fixes: 7fe2d98070e0 ("net/ice/base: add parser create and destroy skeleton") Fixes: 1792942b2df6 ("net/ice/base: init boost TCAM table for parser") Fixes: f787952d13d2 ("net/ice/base: init flag redirect table for parser") Fixes: b3e73a812f98 ("net/ice/base: init IMEM table for parser") Fixes: 2f7a1864cc19 ("net/ice/base: init metainit table for parser") Fixes: 90bbd7d9545f ("net/ice/base: init marker group table for parser") Fixes: c55b1ba93f07 ("net/ice/base: init parse graph CAM table for parser") Fixes: 7b61be517fd5 ("net/ice/base: init protocol group table for parser") Fixes: 111871087cdf ("net/ice/base: init ptype marker TCAM table for parser") Fixes: 0cbacf60dce7 ("net/ice/base: init XLT key builder for parser") Cc: stable@dpdk.org Signed-off-by: Junfeng Guo Signed-off-by: Qi Zhang --- drivers/net/ice/base/ice_bst_tcam.c | 6 +++--- drivers/net/ice/base/ice_flg_rd.c | 4 ++-- drivers/net/ice/base/ice_imem.c | 4 ++-- drivers/net/ice/base/ice_metainit.c | 4 ++-- drivers/net/ice/base/ice_mk_grp.c | 4 ++-- drivers/net/ice/base/ice_parser.c | 7 ++++--- drivers/net/ice/base/ice_pg_cam.c | 12 ++++++------ drivers/net/ice/base/ice_proto_grp.c | 4 ++-- drivers/net/ice/base/ice_ptype_mk.c | 4 ++-- drivers/net/ice/base/ice_xlt_kb.c | 10 +++++----- 10 files changed, 30 insertions(+), 29 deletions(-) diff --git a/drivers/net/ice/base/ice_bst_tcam.c b/drivers/net/ice/base/ice_bst_tcam.c index 306f62db2a..74a2de869e 100644 --- a/drivers/net/ice/base/ice_bst_tcam.c +++ b/drivers/net/ice/base/ice_bst_tcam.c @@ -53,7 +53,7 @@ static void _bst_alu_dump(struct ice_hw *hw, struct ice_alu *alu, int index) /** * ice_bst_tcam_dump - dump a boost tcam info - * @ice_hw: pointer to the hardware structure + * @hw: pointer to the hardware structure * @item: boost tcam to dump */ void ice_bst_tcam_dump(struct ice_hw *hw, struct ice_bst_tcam_item *item) @@ -205,7 +205,7 @@ static void _bst_parse_item(struct ice_hw *hw, u16 idx, void *item, /** * ice_bst_tcam_table_get - create a boost tcam table - * @ice_hw: pointer to the hardware structure + * @hw: pointer to the hardware structure */ struct ice_bst_tcam_item *ice_bst_tcam_table_get(struct ice_hw *hw) { @@ -228,7 +228,7 @@ static void _parse_lbl_item(struct ice_hw *hw, u16 idx, void *item, /** * ice_bst_lbl_table_get - create a boost label table - * @ice_hw: pointer to the hardware structure + * @hw: pointer to the hardware structure */ struct ice_lbl_item *ice_bst_lbl_table_get(struct ice_hw *hw) { diff --git a/drivers/net/ice/base/ice_flg_rd.c b/drivers/net/ice/base/ice_flg_rd.c index 833986cac3..80d3b51ad6 100644 --- a/drivers/net/ice/base/ice_flg_rd.c +++ b/drivers/net/ice/base/ice_flg_rd.c @@ -9,7 +9,7 @@ /** * ice_flg_rd_dump - dump a flag redirect item info - * @ice_hw: pointer to the hardware structure + * @hw: pointer to the hardware structure * @item: flag redirect item to dump */ void ice_flg_rd_dump(struct ice_hw *hw, struct ice_flg_rd_item *item) @@ -40,7 +40,7 @@ static void _flg_rd_parse_item(struct ice_hw *hw, u16 idx, void *item, /** * ice_flg_rd_table_get - create a flag redirect table - * @ice_hw: pointer to the hardware structure + * @hw: pointer to the hardware structure */ struct ice_flg_rd_item *ice_flg_rd_table_get(struct ice_hw *hw) { diff --git a/drivers/net/ice/base/ice_imem.c b/drivers/net/ice/base/ice_imem.c index 2136e0393b..9a76d21ce5 100644 --- a/drivers/net/ice/base/ice_imem.c +++ b/drivers/net/ice/base/ice_imem.c @@ -69,7 +69,7 @@ static void _imem_alu_dump(struct ice_hw *hw, struct ice_alu *alu, int index) /** * ice_imem_dump - dump an imem item info - * @ice_hw: pointer to the hardware structure + * @hw: pointer to the hardware structure * @item: imem item to dump */ void ice_imem_dump(struct ice_hw *hw, struct ice_imem_item *item) @@ -231,7 +231,7 @@ static void _imem_parse_item(struct ice_hw *hw, u16 idx, void *item, /** * ice_imem_table_get - create an imem table - * @ice_hw: pointer to the hardware structure + * @hw: pointer to the hardware structure */ struct ice_imem_item *ice_imem_table_get(struct ice_hw *hw) { diff --git a/drivers/net/ice/base/ice_metainit.c b/drivers/net/ice/base/ice_metainit.c index 3f9e5d6833..a899125b37 100644 --- a/drivers/net/ice/base/ice_metainit.c +++ b/drivers/net/ice/base/ice_metainit.c @@ -9,7 +9,7 @@ /** * ice_metainit_dump - dump an metainit item info - * @ice_hw: pointer to the hardware structure + * @hw: pointer to the hardware structure * @item: metainit item to dump */ void ice_metainit_dump(struct ice_hw *hw, struct ice_metainit_item *item) @@ -130,7 +130,7 @@ static void _metainit_parse_item(struct ice_hw *hw, u16 idx, void *item, /** * ice_metainit_table_get - create a metainit table - * @ice_hw: pointer to the hardware structure + * @hw: pointer to the hardware structure */ struct ice_metainit_item *ice_metainit_table_get(struct ice_hw *hw) { diff --git a/drivers/net/ice/base/ice_mk_grp.c b/drivers/net/ice/base/ice_mk_grp.c index 4e9ab5c13a..814001c49e 100644 --- a/drivers/net/ice/base/ice_mk_grp.c +++ b/drivers/net/ice/base/ice_mk_grp.c @@ -10,7 +10,7 @@ /** * ice_mk_grp_dump - dump an marker group item info - * @ice_hw: pointer to the hardware structure + * @hw: pointer to the hardware structure * @item: marker group item to dump */ void ice_mk_grp_dump(struct ice_hw *hw, struct ice_mk_grp_item *item) @@ -42,7 +42,7 @@ static void _mk_grp_parse_item(struct ice_hw *hw, u16 idx, void *item, /** * ice_mk_grp_table_get - create a marker group table - * @ice_hw: pointer to the hardware structure + * @hw: pointer to the hardware structure */ struct ice_mk_grp_item *ice_mk_grp_table_get(struct ice_hw *hw) { diff --git a/drivers/net/ice/base/ice_parser.c b/drivers/net/ice/base/ice_parser.c index 6529f5d635..5a461d83be 100644 --- a/drivers/net/ice/base/ice_parser.c +++ b/drivers/net/ice/base/ice_parser.c @@ -106,7 +106,7 @@ void *ice_parser_sect_item_get(u32 sect_type, void *section, * @item_size: item size in byte * @length: number of items in the table to create * @item_get: the function will be parsed to ice_pkg_enum_entry - * @parser_item: the function to parse the item + * @parse_item: the function to parse the item * @no_offset: ignore header offset, calculate index from 0 */ void *ice_parser_create_table(struct ice_hw *hw, u32 sect_type, @@ -359,6 +359,7 @@ static void _bst_vm_set(struct ice_parser *psr, const char *prefix, bool on) /** * ice_parser_dvm_set - configure double vlan mode for parser * @psr: pointer to a parser instance + * @on: true to turn on; false to turn off */ void ice_parser_dvm_set(struct ice_parser *psr, bool on) { @@ -478,8 +479,8 @@ static bool _nearest_proto_id(struct ice_parser_result *rslt, u16 offset, * ice_parser_profile_init - initialize a FXP profile base on parser result * @rslt: a instance of a parser result * @pkt_buf: packet data buffer - * @pkt_msk: packet mask buffer - * @pkt_len: packet length + * @msk_buf: packet mask buffer + * @buf_len: packet length * @blk: FXP pipeline stage * @prefix_match: match protocol stack exactly or only prefix * @prof: input/output parameter to save the profile diff --git a/drivers/net/ice/base/ice_pg_cam.c b/drivers/net/ice/base/ice_pg_cam.c index fe461ad849..73f7c34ffd 100644 --- a/drivers/net/ice/base/ice_pg_cam.c +++ b/drivers/net/ice/base/ice_pg_cam.c @@ -50,7 +50,7 @@ static void _pg_cam_action_dump(struct ice_hw *hw, /** * ice_pg_cam_dump - dump an parse graph cam info - * @ice_hw: pointer to the hardware structure + * @hw: pointer to the hardware structure * @item: parse graph cam to dump */ void ice_pg_cam_dump(struct ice_hw *hw, struct ice_pg_cam_item *item) @@ -62,7 +62,7 @@ void ice_pg_cam_dump(struct ice_hw *hw, struct ice_pg_cam_item *item) /** * ice_pg_nm_cam_dump - dump an parse graph no match cam info - * @ice_hw: pointer to the hardware structure + * @hw: pointer to the hardware structure * @item: parse graph no match cam to dump */ void ice_pg_nm_cam_dump(struct ice_hw *hw, struct ice_pg_nm_cam_item *item) @@ -243,7 +243,7 @@ static void _pg_nm_sp_cam_parse_item(struct ice_hw *hw, u16 idx, void *item, /** * ice_pg_cam_table_get - create a parse graph cam table - * @ice_hw: pointer to the hardware structure + * @hw: pointer to the hardware structure */ struct ice_pg_cam_item *ice_pg_cam_table_get(struct ice_hw *hw) { @@ -257,7 +257,7 @@ struct ice_pg_cam_item *ice_pg_cam_table_get(struct ice_hw *hw) /** * ice_pg_sp_cam_table_get - create a parse graph spill cam table - * @ice_hw: pointer to the hardware structure + * @hw: pointer to the hardware structure */ struct ice_pg_cam_item *ice_pg_sp_cam_table_get(struct ice_hw *hw) { @@ -271,7 +271,7 @@ struct ice_pg_cam_item *ice_pg_sp_cam_table_get(struct ice_hw *hw) /** * ice_pg_nm_cam_table_get - create a parse graph no match cam table - * @ice_hw: pointer to the hardware structure + * @hw: pointer to the hardware structure */ struct ice_pg_nm_cam_item *ice_pg_nm_cam_table_get(struct ice_hw *hw) { @@ -285,7 +285,7 @@ struct ice_pg_nm_cam_item *ice_pg_nm_cam_table_get(struct ice_hw *hw) /** * ice_pg_nm_sp_cam_table_get - create a parse graph no match spill cam table - * @ice_hw: pointer to the hardware structure + * @hw: pointer to the hardware structure */ struct ice_pg_nm_cam_item *ice_pg_nm_sp_cam_table_get(struct ice_hw *hw) { diff --git a/drivers/net/ice/base/ice_proto_grp.c b/drivers/net/ice/base/ice_proto_grp.c index 7ce87de110..5dbe07d258 100644 --- a/drivers/net/ice/base/ice_proto_grp.c +++ b/drivers/net/ice/base/ice_proto_grp.c @@ -17,7 +17,7 @@ static void _proto_off_dump(struct ice_hw *hw, struct ice_proto_off *po, /** * ice_proto_grp_dump - dump a proto group item info - * @ice_hw: pointer to the hardware structure + * @hw: pointer to the hardware structure * @item: proto group item to dump */ void ice_proto_grp_dump(struct ice_hw *hw, struct ice_proto_grp_item *item) @@ -94,7 +94,7 @@ static void _proto_grp_parse_item(struct ice_hw *hw, u16 idx, void *item, /** * ice_proto_grp_table_get - create a proto group table - * @ice_hw: pointer to the hardware structure + * @hw: pointer to the hardware structure */ struct ice_proto_grp_item *ice_proto_grp_table_get(struct ice_hw *hw) { diff --git a/drivers/net/ice/base/ice_ptype_mk.c b/drivers/net/ice/base/ice_ptype_mk.c index 97c41cb586..9807e688b1 100644 --- a/drivers/net/ice/base/ice_ptype_mk.c +++ b/drivers/net/ice/base/ice_ptype_mk.c @@ -9,7 +9,7 @@ /** * ice_ptype_mk_tcam_dump - dump an ptype marker tcam info_ - * @ice_hw: pointer to the hardware structure + * @hw: pointer to the hardware structure * @item: ptype marker tcam to dump */ void ice_ptype_mk_tcam_dump(struct ice_hw *hw, @@ -41,7 +41,7 @@ static void _parse_ptype_mk_tcam_item(struct ice_hw *hw, u16 idx, void *item, /** * ice_ptype_mk_tcam_table_get - create a ptype marker tcam table - * @ice_hw: pointer to the hardware structure + * @hw: pointer to the hardware structure */ struct ice_ptype_mk_tcam_item *ice_ptype_mk_tcam_table_get(struct ice_hw *hw) { diff --git a/drivers/net/ice/base/ice_xlt_kb.c b/drivers/net/ice/base/ice_xlt_kb.c index 4c1ab747cf..5efe209cad 100644 --- a/drivers/net/ice/base/ice_xlt_kb.c +++ b/drivers/net/ice/base/ice_xlt_kb.c @@ -25,7 +25,7 @@ static void _xlt_kb_entry_dump(struct ice_hw *hw, /** * ice_imem_dump - dump a xlt key build info - * @ice_hw: pointer to the hardware structure + * @hw: pointer to the hardware structure * @kb: key build to dump */ void ice_xlt_kb_dump(struct ice_hw *hw, struct ice_xlt_kb *kb) @@ -154,7 +154,7 @@ static struct ice_xlt_kb *_xlt_kb_get(struct ice_hw *hw, u32 sect_type) /** * ice_xlt_kb_get_sw - create switch xlt key build - * @ice_hw: pointer to the hardware structure + * @hw: pointer to the hardware structure */ struct ice_xlt_kb *ice_xlt_kb_get_sw(struct ice_hw *hw) { @@ -163,7 +163,7 @@ struct ice_xlt_kb *ice_xlt_kb_get_sw(struct ice_hw *hw) /** * ice_xlt_kb_get_acl - create acl xlt key build - * @ice_hw: pointer to the hardware structure + * @hw: pointer to the hardware structure */ struct ice_xlt_kb *ice_xlt_kb_get_acl(struct ice_hw *hw) { @@ -172,7 +172,7 @@ struct ice_xlt_kb *ice_xlt_kb_get_acl(struct ice_hw *hw) /** * ice_xlt_kb_get_fd - create fdir xlt key build - * @ice_hw: pointer to the hardware structure + * @hw: pointer to the hardware structure */ struct ice_xlt_kb *ice_xlt_kb_get_fd(struct ice_hw *hw) { @@ -181,7 +181,7 @@ struct ice_xlt_kb *ice_xlt_kb_get_fd(struct ice_hw *hw) /** * ice_xlt_kb_get_fd - create rss xlt key build - * @ice_hw: pointer to the hardware structure + * @hw: pointer to the hardware structure */ struct ice_xlt_kb *ice_xlt_kb_get_rss(struct ice_hw *hw) {