From patchwork Mon Aug 15 07:31:05 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Qi Zhang X-Patchwork-Id: 115037 X-Patchwork-Delegate: qi.z.zhang@intel.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id D8422A00C3; Mon, 15 Aug 2022 01:23:06 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 87A6442BB3; Mon, 15 Aug 2022 01:22:30 +0200 (CEST) Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by mails.dpdk.org (Postfix) with ESMTP id 12EF342BAC; Mon, 15 Aug 2022 01:22:28 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1660519349; x=1692055349; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=p77R4R0J+AVOeaL1WtnwJ1cMxjxaO/qW/w5bItqRueQ=; b=GgrUPjRU/adgltfBpxJDiL6hpSFtq8GBPHomUMREQEKEYQPV24X/6P95 a7lmTLzs99DGSfEll5yovUKV7lXfl9nVeOCd+UrLVpOQ72q6bNdkZahLl YNxMlqGdgc/UaLbijqtV6+oQSwoMd9K8gIuby9fPJS739JTLJOoVuoyfz tUw4pskBE090TSyxyVgoEaJPamDeYhDZuvyagDSzp1gFFM3wN/0XOECG8 EgmeiBbbt08Xm/AWnQLoXc+ssXicGPCsqeOlMNRp/BHUktWB3Xv6ICpvu 4W1+7YOZzuDt1a5uYfOkplfUfqvdxaXib6C3YyyviEn+0bCHjPyEHHE0M Q==; X-IronPort-AV: E=McAfee;i="6400,9594,10439"; a="291857927" X-IronPort-AV: E=Sophos;i="5.93,237,1654585200"; d="scan'208";a="291857927" Received: from orsmga008.jf.intel.com ([10.7.209.65]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 14 Aug 2022 16:22:28 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.93,237,1654585200"; d="scan'208";a="635283017" Received: from dpdk-qzhan15-test02.sh.intel.com ([10.67.115.4]) by orsmga008.jf.intel.com with ESMTP; 14 Aug 2022 16:22:27 -0700 From: Qi Zhang To: qiming.yang@intel.com Cc: dev@dpdk.org, Qi Zhang , stable@dpdk.org, Dave Ertman Subject: [PATCH v2 09/70] net/ice/base: fix DSCP PFC TLV creation Date: Mon, 15 Aug 2022 03:31:05 -0400 Message-Id: <20220815073206.2917968-10-qi.z.zhang@intel.com> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20220815073206.2917968-1-qi.z.zhang@intel.com> References: <20220815071306.2910599-1-qi.z.zhang@intel.com> <20220815073206.2917968-1-qi.z.zhang@intel.com> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org When creating the TLV to send to the FW for configuring DSCP mode PFC, the PFCENABLE field was being masked with a 4 bit mask (0xF), but this is an 8 bit bitmask for enabled classes for PFC. This means that traffic classes 4-7 could not be enabled for PFC. Remove the mask completely, as it is not necessary, as we are assigning 8bits to an 8 bit field. Fixes: 8ea78b169603 ("net/ice/base: support L3 DSCP QoS") Cc: stable@dpdk.org Signed-off-by: Dave Ertman Signed-off-by: Qi Zhang --- drivers/net/ice/base/ice_dcb.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ice/base/ice_dcb.c b/drivers/net/ice/base/ice_dcb.c index cb6c5ba182..3d630757f8 100644 --- a/drivers/net/ice/base/ice_dcb.c +++ b/drivers/net/ice/base/ice_dcb.c @@ -1376,7 +1376,7 @@ ice_add_dscp_pfc_tlv(struct ice_lldp_org_tlv *tlv, struct ice_dcbx_cfg *dcbcfg) tlv->ouisubtype = HTONL(ouisubtype); buf[0] = dcbcfg->pfc.pfccap & 0xF; - buf[1] = dcbcfg->pfc.pfcena & 0xF; + buf[1] = dcbcfg->pfc.pfcena; } /**