[v2,31/70] net/ice/base: move function to internal

Message ID 20220815073206.2917968-32-qi.z.zhang@intel.com (mailing list archive)
State Accepted, archived
Delegated to: Qi Zhang
Headers
Series ice base code update |

Checks

Context Check Description
ci/checkpatch success coding style OK

Commit Message

Qi Zhang Aug. 15, 2022, 7:31 a.m. UTC
  The function ice_disable_fd_swap should be defined as static.

Signed-off-by: Junfeng Guo <junfeng.guo@intel.com>
Signed-off-by: Qi Zhang <qi.z.zhang@intel.com>
---
 drivers/net/ice/base/ice_flex_pipe.c | 2 +-
 drivers/net/ice/base/ice_flex_pipe.h | 1 -
 2 files changed, 1 insertion(+), 2 deletions(-)
  

Comments

Qiming Yang Aug. 22, 2022, 5:34 a.m. UTC | #1
> -----Original Message-----
> From: Zhang, Qi Z <qi.z.zhang@intel.com>
> Sent: Monday, August 15, 2022 3:31 PM
> To: Yang, Qiming <qiming.yang@intel.com>
> Cc: dev@dpdk.org; Zhang, Qi Z <qi.z.zhang@intel.com>; Guo, Junfeng
> <junfeng.guo@intel.com>
> Subject: [PATCH v2 31/70] net/ice/base: move function to internal
> 
> The function ice_disable_fd_swap should be defined as static.
> 
> Signed-off-by: Junfeng Guo <junfeng.guo@intel.com>
> Signed-off-by: Qi Zhang <qi.z.zhang@intel.com>
> ---
>  drivers/net/ice/base/ice_flex_pipe.c | 2 +-
> drivers/net/ice/base/ice_flex_pipe.h | 1 -
>  2 files changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/drivers/net/ice/base/ice_flex_pipe.c
> b/drivers/net/ice/base/ice_flex_pipe.c
> index 0840b976aa..aea0d97b9d 100644
> --- a/drivers/net/ice/base/ice_flex_pipe.c
> +++ b/drivers/net/ice/base/ice_flex_pipe.c
> @@ -3133,7 +3133,7 @@ ice_add_prof_attrib(struct ice_prof_map *prof, u8
> ptg, u16 ptype,
>   * @hw: pointer to the HW struct
>   * @prof_id: profile ID
>   */
> -void ice_disable_fd_swap(struct ice_hw *hw, u16 prof_id)
> +static void ice_disable_fd_swap(struct ice_hw *hw, u16 prof_id)
>  {
>  	u8 swap_val = ICE_SWAP_VALID;
>  	u8 i;
> diff --git a/drivers/net/ice/base/ice_flex_pipe.h
> b/drivers/net/ice/base/ice_flex_pipe.h
> index 777790a9c0..8fde36dfa6 100644
> --- a/drivers/net/ice/base/ice_flex_pipe.h
> +++ b/drivers/net/ice/base/ice_flex_pipe.h
> @@ -38,7 +38,6 @@ bool ice_hw_ptype_ena(struct ice_hw *hw, u16 ptype);
>  /* XLT2/VSI group functions */
>  enum ice_status
>  ice_vsig_find_vsi(struct ice_hw *hw, enum ice_block blk, u16 vsi, u16 *vsig);
> -void ice_disable_fd_swap(struct ice_hw *hw, u16 prof_id);  enum ice_status
> ice_add_prof(struct ice_hw *hw, enum ice_block blk, u64 id,
>  	     ice_bitmap_t *ptypes, const struct ice_ptype_attributes *attr,
> --
> 2.31.1

31/70 ~ 50/70
Acked-by: Qiming Yang <qiming.yang@intel.com>
  

Patch

diff --git a/drivers/net/ice/base/ice_flex_pipe.c b/drivers/net/ice/base/ice_flex_pipe.c
index 0840b976aa..aea0d97b9d 100644
--- a/drivers/net/ice/base/ice_flex_pipe.c
+++ b/drivers/net/ice/base/ice_flex_pipe.c
@@ -3133,7 +3133,7 @@  ice_add_prof_attrib(struct ice_prof_map *prof, u8 ptg, u16 ptype,
  * @hw: pointer to the HW struct
  * @prof_id: profile ID
  */
-void ice_disable_fd_swap(struct ice_hw *hw, u16 prof_id)
+static void ice_disable_fd_swap(struct ice_hw *hw, u16 prof_id)
 {
 	u8 swap_val = ICE_SWAP_VALID;
 	u8 i;
diff --git a/drivers/net/ice/base/ice_flex_pipe.h b/drivers/net/ice/base/ice_flex_pipe.h
index 777790a9c0..8fde36dfa6 100644
--- a/drivers/net/ice/base/ice_flex_pipe.h
+++ b/drivers/net/ice/base/ice_flex_pipe.h
@@ -38,7 +38,6 @@  bool ice_hw_ptype_ena(struct ice_hw *hw, u16 ptype);
 /* XLT2/VSI group functions */
 enum ice_status
 ice_vsig_find_vsi(struct ice_hw *hw, enum ice_block blk, u16 vsi, u16 *vsig);
-void ice_disable_fd_swap(struct ice_hw *hw, u16 prof_id);
 enum ice_status
 ice_add_prof(struct ice_hw *hw, enum ice_block blk, u64 id,
 	     ice_bitmap_t *ptypes, const struct ice_ptype_attributes *attr,