diff mbox series

eal: make eal_parse_coremask external

Message ID 20220819223301.2980316-1-timothy.mcdaniel@intel.com (mailing list archive)
State Superseded, archived
Delegated to: Thomas Monjalon
Headers
Series eal: make eal_parse_coremask external |

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/github-robot: build success github build: passed
ci/iol-aarch64-compile-testing success Testing PASS
ci/iol-intel-Functional success Functional Testing PASS
ci/iol-mellanox-Performance success Performance Testing PASS
ci/iol-aarch64-unit-testing success Testing PASS
ci/iol-intel-Performance success Performance Testing PASS
ci/iol-x86_64-unit-testing fail Testing issues
ci/iol-x86_64-compile-testing fail Testing issues

Commit Message

Timothy McDaniel Aug. 19, 2022, 10:33 p.m. UTC 
  DLB2 has a need to parse a user supplied coremask as part
of an optimization that associates optimal core/resource
pairs.  Therefore eal_parse_coremask has been renamed
to rte_eal_parse_coremask and exported.

Signed-off-by: Timothy McDaniel <timothy.mcdaniel@intel.com>
---
 lib/eal/common/eal_common_options.c | 6 +++---
 lib/eal/common/eal_options.h        | 2 ++
 lib/eal/version.map                 | 3 +++
 3 files changed, 8 insertions(+), 3 deletions(-)

Comments

Dmitry Kozlyuk Aug. 20, 2022, 10 a.m. UTC | #1 
2022-08-19 17:33 (UTC-0500), Timothy McDaniel:
> DLB2 has a need to parse a user supplied coremask as part
> of an optimization that associates optimal core/resource
> pairs.  Therefore eal_parse_coremask has been renamed
> to rte_eal_parse_coremask and exported.

INTERNAL would be sufficient since the function is only used within DPDK.
EXPERIMENTAL is for symbols that would be used by consumer apps.
diff mbox series

Patch

diff --git a/lib/eal/common/eal_common_options.c b/lib/eal/common/eal_common_options.c
index 4c2def0155..2d6535781b 100644
--- a/lib/eal/common/eal_common_options.c
+++ b/lib/eal/common/eal_common_options.c
@@ -742,8 +742,8 @@  check_core_list(int *lcores, unsigned int count)
 	return -1;
 }
 
-static int
-eal_parse_coremask(const char *coremask, int *cores)
+int
+rte_eal_parse_coremask(const char *coremask, int *cores)
 {
 	const char *coremask_orig = coremask;
 	int lcores[RTE_MAX_LCORE];
@@ -1649,7 +1649,7 @@  eal_parse_common_option(int opt, const char *optarg,
 		if (eal_service_cores_parsed())
 			RTE_LOG(WARNING, EAL,
 				"Service cores parsed before dataplane cores. Please ensure -c is before -s or -S\n");
-		if (eal_parse_coremask(optarg, lcore_indexes) < 0) {
+		if (rte_eal_parse_coremask(optarg, lcore_indexes) < 0) {
 			RTE_LOG(ERR, EAL, "invalid coremask syntax\n");
 			return -1;
 		}
diff --git a/lib/eal/common/eal_options.h b/lib/eal/common/eal_options.h
index 3cc9cb6412..21df6886f8 100644
--- a/lib/eal/common/eal_options.h
+++ b/lib/eal/common/eal_options.h
@@ -108,5 +108,7 @@  int eal_plugins_init(void);
 int eal_save_args(int argc, char **argv);
 int handle_eal_info_request(const char *cmd, const char *params __rte_unused,
 		struct rte_tel_data *d);
+__rte_experimental
+int rte_eal_parse_coremask(const char *coremask, int *cores);
 
 #endif /* EAL_OPTIONS_H */
diff --git a/lib/eal/version.map b/lib/eal/version.map
index 1f293e768b..3780853443 100644
--- a/lib/eal/version.map
+++ b/lib/eal/version.map
@@ -424,6 +424,9 @@  EXPERIMENTAL {
 	rte_thread_self;
 	rte_thread_set_affinity_by_id;
 	rte_thread_set_priority;
+
+	#added in 22.11
+	rte_eal_parse_coremask;
 };
 
 INTERNAL {