From patchwork Tue Aug 23 10:57:42 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Amit Prakash Shukla X-Patchwork-Id: 115360 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 950A3A0093; Tue, 23 Aug 2022 12:58:35 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 8A0D5427F4; Tue, 23 Aug 2022 12:58:35 +0200 (CEST) Received: from mx0b-0016f401.pphosted.com (mx0a-0016f401.pphosted.com [67.231.148.174]) by mails.dpdk.org (Postfix) with ESMTP id 2908540DFD; Tue, 23 Aug 2022 12:58:33 +0200 (CEST) Received: from pps.filterd (m0045849.ppops.net [127.0.0.1]) by mx0a-0016f401.pphosted.com (8.17.1.5/8.17.1.5) with ESMTP id 27NAIWpN025507; Tue, 23 Aug 2022 03:58:29 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com; h=from : to : cc : subject : date : message-id : in-reply-to : references : mime-version : content-transfer-encoding : content-type; s=pfpt0220; bh=2EVdwCIvRXHULNHqKCu5PKc4Xh6YVZ2CwXFPAhllZMI=; b=Blar+8ZKVdqVmyOX3dErkmKd3DNBJjV2eUUv1r5wkdW99gaYbR5TfJQwcVuo7rcL0lJr VMbl0DQzHLzlLQDdTzbLZJnNXh7+er66xaiNFzjTrH9CCvUHcTsXYQo5tFP9N3/Ax5LO 6jHfxWfsDt6HSaZ/kSw6sQqM99uEzj3rKp/M5POP4GWBOCGwFlvv9J8PXtdQeTWK1qJK MeZBi43qaT7UtzaoZxcY9dW9geV/sq+hsw9he+o4LRPHiW2xgYcincV92vx6YWGZ35zR SAHp/Y9FYgSY1fuVRQS0oguJCjQDMLAsEENPLh33N8ScdsQ/uNpGFnV3UrcGe6WehJSm og== Received: from dc5-exch01.marvell.com ([199.233.59.181]) by mx0a-0016f401.pphosted.com (PPS) with ESMTPS id 3j4ubj8hnf-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT); Tue, 23 Aug 2022 03:58:29 -0700 Received: from DC5-EXCH02.marvell.com (10.69.176.39) by DC5-EXCH01.marvell.com (10.69.176.38) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Tue, 23 Aug 2022 03:58:28 -0700 Received: from maili.marvell.com (10.69.176.80) by DC5-EXCH02.marvell.com (10.69.176.39) with Microsoft SMTP Server id 15.0.1497.18 via Frontend Transport; Tue, 23 Aug 2022 03:58:28 -0700 Received: from localhost.localdomain (unknown [10.28.36.157]) by maili.marvell.com (Postfix) with ESMTP id DC27F5B6929; Tue, 23 Aug 2022 03:58:25 -0700 (PDT) From: Amit Prakash Shukla To: Ruifeng Wang , Radu Nicolau , Akhil Goyal CC: , , Amit Prakash Shukla , Subject: [PATCH 3/3] examples/ipsec-secgw: compilation fix for GCC-12 Date: Tue, 23 Aug 2022 16:27:42 +0530 Message-ID: <20220823105742.2276506-3-amitprakashs@marvell.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220823105742.2276506-1-amitprakashs@marvell.com> References: <20220823105742.2276506-1-amitprakashs@marvell.com> MIME-Version: 1.0 X-Proofpoint-GUID: 3xE0iCpviO4iQmtZmQR3amdRZi40Nw8U X-Proofpoint-ORIG-GUID: 3xE0iCpviO4iQmtZmQR3amdRZi40Nw8U X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.205,Aquarius:18.0.895,Hydra:6.0.517,FMLib:17.11.122.1 definitions=2022-08-23_04,2022-08-22_02,2022-06-22_01 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org GCC 12 raises the following warning: meson --werror --buildtype=debugoptimized --cross-file config/arm/arm64_armv8_linux_gcc -Ddefault_library=shared -Dexamples=all build ninja -C build In file included from ../examples/ipsec-secgw/ipsec_lpm_neon.h:9, from ../examples/ipsec-secgw/ipsec_worker.c:16: In function 'send_multi_pkts', inlined from 'route6_pkts_neon' at ../examples/ipsec-secgw/ipsec_lpm_neon.h:170:2, inlined from 'ipsec_poll_mode_wrkr_inl_pr' at ../examples/ipsec-secgw/ipsec_worker.c:1257:4: ../examples/ipsec-secgw/ipsec_neon.h:261:21: error: 'dst_port' may be used uninitialized [-Werror=maybe-uninitialized] 261 | dlp = dst_port[i - 1]; | ~~~~^~~~~~~~~~~~~~~~~ In file included from ../examples/ipsec-secgw/ipsec_worker.c:16: ../examples/ipsec-secgw/ipsec_worker.c: In function 'ipsec_poll_mode_wrkr_inl_pr': ../examples/ipsec-secgw/ipsec_lpm_neon.h:118:17: note: 'dst_port' declared here 118 | int32_t dst_port[MAX_PKT_BURST]; | ^~~~~~~~ Fixes: ce23f7ceec6b (examples/ipsec-secgw: add support of NEON with poll mode) Cc: stable@dpdk.org Signed-off-by: Amit Prakash Shukla --- examples/ipsec-secgw/ipsec_lpm_neon.h | 10 ++++------ 1 file changed, 4 insertions(+), 6 deletions(-) diff --git a/examples/ipsec-secgw/ipsec_lpm_neon.h b/examples/ipsec-secgw/ipsec_lpm_neon.h index 959a5a8666..25f0abcaf3 100644 --- a/examples/ipsec-secgw/ipsec_lpm_neon.h +++ b/examples/ipsec-secgw/ipsec_lpm_neon.h @@ -115,7 +115,7 @@ static inline void route6_pkts_neon(struct rt_ctx *rt_ctx, struct rte_mbuf **pkts, int nb_rx) { uint8_t dst_ip6[MAX_PKT_BURST][16]; - int32_t dst_port[MAX_PKT_BURST]; + uint16_t dst_port[MAX_PKT_BURST]; struct rte_ether_hdr *eth_hdr; struct rte_ipv6_hdr *ipv6_hdr; int32_t hop[MAX_PKT_BURST]; @@ -157,17 +157,15 @@ route6_pkts_neon(struct rt_ctx *rt_ctx, struct rte_mbuf **pkts, int nb_rx) pkt = pkts[i]; if (pkt->ol_flags & RTE_MBUF_F_TX_SEC_OFFLOAD) { /* Read hop from the SA */ - dst_port[i] = get_hop_for_offload_pkt(pkt, 1); + dst_port[i] = (uint16_t)get_hop_for_offload_pkt(pkt, 1); } else { /* Need to use hop returned by lookup */ - dst_port[i] = hop[lpm_pkts++]; + dst_port[i] = (uint16_t)hop[lpm_pkts++]; } - if (dst_port[i] == -1) - dst_port[i] = BAD_PORT; } /* Send packets */ - send_multi_pkts(pkts, (uint16_t *)dst_port, nb_rx, 0, 0, false); + send_multi_pkts(pkts, dst_port, nb_rx, 0, 0, false); } /*