diff mbox series

[v6,1/2] Fix build of apps with external dependencies

Message ID 20220902084533.675698-2-felix.moessbauer@siemens.com (mailing list archive)
State Changes Requested, archived
Delegated to: David Marchand
Headers
Series Add l2reflect measurement application |

Checks

Context Check Description
ci/checkpatch success coding style OK

Commit Message

Moessbauer, Felix Sept. 2, 2022, 8:45 a.m. UTC 
This fix initializes the dependency object with the external
dependency list. Previously, the external dependencies were
just ignored.

Signed-off-by: Felix Moessbauer <felix.moessbauer@siemens.com>
Acked-by: Bruce Richardson <bruce.richardson@intel.com>
---
 app/meson.build | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Maxime Coquelin Sept. 20, 2022, 12:33 p.m. UTC | #1 
On 9/2/22 10:45, Felix Moessbauer wrote:
> This fix initializes the dependency object with the external
> dependency list. Previously, the external dependencies were
> just ignored.
> 
> Signed-off-by: Felix Moessbauer <felix.moessbauer@siemens.com>
> Acked-by: Bruce Richardson <bruce.richardson@intel.com>
> ---
>   app/meson.build | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/app/meson.build b/app/meson.build
> index 93d8c15032..0ea04cadeb 100644
> --- a/app/meson.build
> +++ b/app/meson.build
> @@ -44,7 +44,7 @@ foreach app:apps
>       subdir(name)
>   
>       if build
> -        dep_objs = []
> +        dep_objs = ext_deps
>           foreach d:deps
>               var_name = get_option('default_library') + '_rte_' + d
>               if not is_variable(var_name)

Reviewed-by: Maxime Coquelin <maxime.coquelin@redhat.com>

Thanks,
Maxime
diff mbox series

Patch

diff --git a/app/meson.build b/app/meson.build
index 93d8c15032..0ea04cadeb 100644
--- a/app/meson.build
+++ b/app/meson.build
@@ -44,7 +44,7 @@  foreach app:apps
     subdir(name)
 
     if build
-        dep_objs = []
+        dep_objs = ext_deps
         foreach d:deps
             var_name = get_option('default_library') + '_rte_' + d
             if not is_variable(var_name)