[RESEND] config/arm: add PHYTIUM fts2500

Message ID 20220907081055.491-1-luzhipeng@cestc.cn (mailing list archive)
State Superseded, archived
Delegated to: Thomas Monjalon
Headers
Series [RESEND] config/arm: add PHYTIUM fts2500 |

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/github-robot: build success github build: passed
ci/iol-mellanox-Performance success Performance Testing PASS
ci/iol-aarch64-unit-testing success Testing PASS
ci/iol-aarch64-compile-testing success Testing PASS
ci/iol-x86_64-unit-testing fail Testing issues
ci/iol-x86_64-compile-testing success Testing PASS
ci/iol-intel-Performance success Performance Testing PASS
ci/iol-intel-Functional success Functional Testing PASS
ci/Intel-compilation fail Compilation issues
ci/intel-Testing success Testing PASS

Commit Message

luzhipeng Sept. 7, 2022, 8:10 a.m. UTC
  Here adds configs for PHYTIUM server.

Signed-off-by: luzhipeng <luzhipeng@cestc.cn>
---
 config/arm/arm64_fts2500_linux_gcc | 16 ++++++++++++++++
 config/arm/meson.build             | 22 ++++++++++++++++++++--
 2 files changed, 36 insertions(+), 2 deletions(-)
 create mode 100644 config/arm/arm64_fts2500_linux_gcc
  

Comments

Ruifeng Wang Sept. 8, 2022, 7:12 a.m. UTC | #1
> -----Original Message-----
> From: luzhipeng <luzhipeng@cestc.cn>
> Sent: Wednesday, September 7, 2022 4:11 PM
> To: dev@dpdk.org
> Cc: Jan Viktorin <viktorin@rehivetech.com>; Ruifeng Wang <Ruifeng.Wang@arm.com>; Bruce
> Richardson <bruce.richardson@intel.com>; luzhipeng <luzhipeng@cestc.cn>
> Subject: [PATCH RESEND] config/arm: add PHYTIUM fts2500
> 
> Here adds configs for PHYTIUM server.
> 
> Signed-off-by: luzhipeng <luzhipeng@cestc.cn>
> ---
>  config/arm/arm64_fts2500_linux_gcc | 16 ++++++++++++++++
>  config/arm/meson.build             | 22 ++++++++++++++++++++--
>  2 files changed, 36 insertions(+), 2 deletions(-)  create mode 100644
> config/arm/arm64_fts2500_linux_gcc
> 
> diff --git a/config/arm/arm64_fts2500_linux_gcc b/config/arm/arm64_fts2500_linux_gcc
> new file mode 100644
> index 0000000000..d43c7aad3a
> --- /dev/null
> +++ b/config/arm/arm64_fts2500_linux_gcc
> @@ -0,0 +1,16 @@
> +[binaries]
> +c = 'aarch64-linux-gnu-gcc'
Ccache was enabled to speed up cross build.
To be consistent with other SOCs, please add it here as well.

Thanks.
> +cpp = 'aarch64-linux-gnu-g++'
> +ar = 'aarch64-linux-gnu-gcc-ar'
> +strip = 'aarch64-linux-gnu-strip'
> +pkgconfig = 'aarch64-linux-gnu-pkg-config'
> +pcap-config = ''
> +
> +[host_machine]
> +system = 'linux'
> +cpu_family = 'aarch64'
> +cpu = 'armv8-a'
> +endian = 'little'
> +
> +[properties]
> +platform = 'fts2500'
> diff --git a/config/arm/meson.build b/config/arm/meson.build index 9f1636e0d5..ae0777b46c
> 100644
> --- a/config/arm/meson.build
> +++ b/config/arm/meson.build
> @@ -203,13 +203,22 @@ implementer_phytium = {
>          ['RTE_MACHINE', '"armv8a"'],
>          ['RTE_USE_C11_MEM_MODEL', true],
>          ['RTE_CACHE_LINE_SIZE', 64],
> -        ['RTE_MAX_LCORE', 64],
> -        ['RTE_MAX_NUMA_NODES', 8]
>      ],
>      'part_number_config': {
>          '0x662': {
>              'machine_args': ['-march=armv8-a+crc'],
> +            'flags': [
> +                ['RTE_MAX_LCORE', 64],
> +                ['RTE_MAX_NUMA_NODES', 8]
> +             ]
>          },
> +       '0x663': {
> +            'machine_args': ['-march=armv8-a+crc'],
> +            'flags': [
> +                ['RTE_MAX_LCORE', 128],
> +                ['RTE_MAX_NUMA_NODES', 16]
> +            ]
> +        }
>      }
>  }
> 
> @@ -328,6 +337,13 @@ soc_ft2000plus = {
>      'numa': true
>  }
> 
> +soc_fts2500 = {
> +    'description': 'Phytium FT-S2500',
> +    'implementer': '0x70',
> +    'part_number': '0x663',
> +    'numa': true
> +}
> +
>  soc_graviton2 = {
>      'description': 'AWS Graviton2',
>      'implementer': '0x41',
> @@ -414,6 +430,7 @@ cn10k:           Marvell OCTEON 10
>  dpaa:            NXP DPAA
>  emag:            Ampere eMAG
>  ft2000plus:      Phytium FT-2000+
> +fts2500:         Phytium FT-S2500
>  graviton2:       AWS Graviton2
>  kunpeng920:      HiSilicon Kunpeng 920
>  kunpeng930:      HiSilicon Kunpeng 930
> @@ -438,6 +455,7 @@ socs = {
>      'dpaa': soc_dpaa,
>      'emag': soc_emag,
>      'ft2000plus': soc_ft2000plus,
> +    'fts2500': soc_fts2500,
>      'graviton2': soc_graviton2,
>      'kunpeng920': soc_kunpeng920,
>      'kunpeng930': soc_kunpeng930,
> --
> 2.27.0
> 
>
  
解建华 Sept. 8, 2022, 7:53 a.m. UTC | #2
Hello Zhipeng, please see inline. 

Thanks a lot,
Jianhua


> -----原始邮件-----发件人:luzhipeng <luzhipeng@cestc.cn>发送时间:2022-09-07 16:10:55 (星期三)收件人:dev@dpdk.org抄送:"Jan Viktorin" <viktorin@rehivetech.com>, "Ruifeng Wang" <ruifeng.wang@arm.com>, "Bruce Richardson" <bruce.richardson@intel.com>, luzhipeng <luzhipeng@cestc.cn>主题:[PATCH RESEND] config/arm: add PHYTIUM fts2500
> 
> Here adds configs for PHYTIUM server.
> 
> Signed-off-by: luzhipeng <luzhipeng@cestc.cn>
> ---
>  config/arm/arm64_fts2500_linux_gcc | 16 ++++++++++++++++
>  config/arm/meson.build             | 22 ++++++++++++++++++++--
>  2 files changed, 36 insertions(+), 2 deletions(-)
>  create mode 100644 config/arm/arm64_fts2500_linux_gcc
> 
> diff --git a/config/arm/arm64_fts2500_linux_gcc b/config/arm/arm64_fts2500_linux_gcc

Phytium released 3 series of CPU including TengYun S - server,
TengRui D - desktop and TengLong E - embedded. please refer to the introduction link:
https://www.phytium.com.cn/en/class/11

so it would be better if you change config/arm/arm64_fts2500_linux_gcc  to
config/arm/arm64_tys2500_linux_gcc

> new file mode 100644
> index 0000000000..d43c7aad3a
> --- /dev/null
> +++ b/config/arm/arm64_fts2500_linux_gcc
> @@ -0,0 +1,16 @@
> +[binaries]
> +c = 'aarch64-linux-gnu-gcc'
> +cpp = 'aarch64-linux-gnu-g++'
> +ar = 'aarch64-linux-gnu-gcc-ar'
> +strip = 'aarch64-linux-gnu-strip'
> +pkgconfig = 'aarch64-linux-gnu-pkg-config'
> +pcap-config = ''
> +
> +[host_machine]
> +system = 'linux'
> +cpu_family = 'aarch64'
> +cpu = 'armv8-a'
> +endian = 'little'
> +
> +[properties]
> +platform = 'fts2500'

tys2500 looks better.


> diff --git a/config/arm/meson.build b/config/arm/meson.build
> index 9f1636e0d5..ae0777b46c 100644
> --- a/config/arm/meson.build
> +++ b/config/arm/meson.build
> @@ -203,13 +203,22 @@ implementer_phytium = {
>          ['RTE_MACHINE', '"armv8a"'],
>          ['RTE_USE_C11_MEM_MODEL', true],
>          ['RTE_CACHE_LINE_SIZE', 64],
> -        ['RTE_MAX_LCORE', 64],
> -        ['RTE_MAX_NUMA_NODES', 8]
>      ],
>      'part_number_config': {
>          '0x662': {
>              'machine_args': ['-march=armv8-a+crc'],

please split machine_args like this:
-            'machine_args': ['-march=armv8-a+crc'],
+            'march': 'armv8-a',
+            'march_features': ['crc'],


> +            'flags': [
> +                ['RTE_MAX_LCORE', 64],
> +                ['RTE_MAX_NUMA_NODES', 8]
> +             ]
>          },
> +       '0x663': {
> +            'machine_args': ['-march=armv8-a+crc'],

please split machine_args like this:
-            'machine_args': ['-march=armv8-a+crc'],
+            'march': 'armv8-a',
+            'march_features': ['crc'],


> +            'flags': [
> +                ['RTE_MAX_LCORE', 128],
> +                ['RTE_MAX_NUMA_NODES', 16]

+                ['RTE_MAX_LCORE', 256],
+                ['RTE_MAX_NUMA_NODES', 32]

Phytium TengYun S2500 server series have 2P_128core, 4P_256core
and up to 8P_512core SKUs. Single processor of them is ARMv8-a
architecture with part number 0x663, 8 NUMA nodes, 64 cores.

you may add Phytium TengYun S2500 servers with the
max configuration 4P_256core_32NUMA, and ignore 8P_512core_64NUMA
since this SKU has not been found in current market, can't be tested.


> +            ]
> +        }
>      }
>  }
>  
> @@ -328,6 +337,13 @@ soc_ft2000plus = {
>      'numa': true
>  }
>  
> +soc_fts2500 = {

+soc_tys2500

> +    'description': 'Phytium FT-S2500',

+'description': 'Phytium TengYun S2500',


> +    'implementer': '0x70',
> +    'part_number': '0x663',
> +    'numa': true
> +}
> +
>  soc_graviton2 = {
>      'description': 'AWS Graviton2',
>      'implementer': '0x41',
> @@ -414,6 +430,7 @@ cn10k:           Marvell OCTEON 10
>  dpaa:            NXP DPAA
>  emag:            Ampere eMAG
>  ft2000plus:      Phytium FT-2000+
> +fts2500:         Phytium FT-S2500

+tys2500:         Phytium TengYun S2500

>  graviton2:       AWS Graviton2
>  kunpeng920:      HiSilicon Kunpeng 920
>  kunpeng930:      HiSilicon Kunpeng 930
> @@ -438,6 +455,7 @@ socs = {
>      'dpaa': soc_dpaa,
>      'emag': soc_emag,
>      'ft2000plus': soc_ft2000plus,
> +    'fts2500': soc_fts2500,

+    'tys2500': soc_tys2500,

>      'graviton2': soc_graviton2,
>      'kunpeng920': soc_kunpeng920,
>      'kunpeng930': soc_kunpeng930,
> -- 
> 2.27.0
> 
> 


信息安全声明:本邮件包含信息归发件人所在组织所有,发件人所在组织对该邮件拥有所有权利。请接收者注意保密,未经发件人书面许可,不得向任何第三方组织和个人透露本邮件所含信息。
Information Security Notice: The information contained in this mail is solely property of the sender's organization.This mail communication is confidential.Recipients named above are obligated to maintain secrecy and are not permitted to disclose the contents of this communication to others.
  

Patch

diff --git a/config/arm/arm64_fts2500_linux_gcc b/config/arm/arm64_fts2500_linux_gcc
new file mode 100644
index 0000000000..d43c7aad3a
--- /dev/null
+++ b/config/arm/arm64_fts2500_linux_gcc
@@ -0,0 +1,16 @@ 
+[binaries]
+c = 'aarch64-linux-gnu-gcc'
+cpp = 'aarch64-linux-gnu-g++'
+ar = 'aarch64-linux-gnu-gcc-ar'
+strip = 'aarch64-linux-gnu-strip'
+pkgconfig = 'aarch64-linux-gnu-pkg-config'
+pcap-config = ''
+
+[host_machine]
+system = 'linux'
+cpu_family = 'aarch64'
+cpu = 'armv8-a'
+endian = 'little'
+
+[properties]
+platform = 'fts2500'
diff --git a/config/arm/meson.build b/config/arm/meson.build
index 9f1636e0d5..ae0777b46c 100644
--- a/config/arm/meson.build
+++ b/config/arm/meson.build
@@ -203,13 +203,22 @@  implementer_phytium = {
         ['RTE_MACHINE', '"armv8a"'],
         ['RTE_USE_C11_MEM_MODEL', true],
         ['RTE_CACHE_LINE_SIZE', 64],
-        ['RTE_MAX_LCORE', 64],
-        ['RTE_MAX_NUMA_NODES', 8]
     ],
     'part_number_config': {
         '0x662': {
             'machine_args': ['-march=armv8-a+crc'],
+            'flags': [
+                ['RTE_MAX_LCORE', 64],
+                ['RTE_MAX_NUMA_NODES', 8]
+             ]
         },
+       '0x663': {
+            'machine_args': ['-march=armv8-a+crc'],
+            'flags': [
+                ['RTE_MAX_LCORE', 128],
+                ['RTE_MAX_NUMA_NODES', 16]
+            ]
+        }
     }
 }
 
@@ -328,6 +337,13 @@  soc_ft2000plus = {
     'numa': true
 }
 
+soc_fts2500 = {
+    'description': 'Phytium FT-S2500',
+    'implementer': '0x70',
+    'part_number': '0x663',
+    'numa': true
+}
+
 soc_graviton2 = {
     'description': 'AWS Graviton2',
     'implementer': '0x41',
@@ -414,6 +430,7 @@  cn10k:           Marvell OCTEON 10
 dpaa:            NXP DPAA
 emag:            Ampere eMAG
 ft2000plus:      Phytium FT-2000+
+fts2500:         Phytium FT-S2500
 graviton2:       AWS Graviton2
 kunpeng920:      HiSilicon Kunpeng 920
 kunpeng930:      HiSilicon Kunpeng 930
@@ -438,6 +455,7 @@  socs = {
     'dpaa': soc_dpaa,
     'emag': soc_emag,
     'ft2000plus': soc_ft2000plus,
+    'fts2500': soc_fts2500,
     'graviton2': soc_graviton2,
     'kunpeng920': soc_kunpeng920,
     'kunpeng930': soc_kunpeng930,