diff mbox series

[v3] dumpcap: fix interface parameter check.

Message ID 20220915081609.77312-1-arshdeep.kaur@intel.com (mailing list archive)
State Accepted, archived
Delegated to: Thomas Monjalon
Headers
Series [v3] dumpcap: fix interface parameter check. |

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/iol-mellanox-Performance success Performance Testing PASS
ci/iol-intel-Performance success Performance Testing PASS
ci/iol-aarch64-compile-testing success Testing PASS
ci/iol-x86_64-unit-testing fail Testing issues
ci/iol-aarch64-unit-testing success Testing PASS
ci/iol-intel-Functional success Functional Testing PASS
ci/iol-x86_64-compile-testing success Testing PASS
ci/github-robot: build success github build: passed
ci/Intel-compilation success Compilation OK
ci/intel-Testing success Testing PASS

Commit Message

Kaur, Arshdeep Sept. 15, 2022, 8:16 a.m. UTC 
  Correction in handling 'IF' condition for -i parameter.
Fixes: cbb44143be74 ("app/dumpcap: add new packet capture application")
Signed-off-by: Arshdeep Kaur <arshdeep.kaur@intel.com>
---
 app/dumpcap/main.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Pattan, Reshma Sept. 15, 2022, 8:44 a.m. UTC | #1 
> -----Original Message-----
> From: Arshdeep Kaur <arshdeep.kaur@intel.com>
> Subject: [PATCH v3] dumpcap: fix interface parameter check.
> 
> Correction in handling 'IF' condition for -i parameter.
> Fixes: cbb44143be74 ("app/dumpcap: add new packet capture application")
> Signed-off-by: Arshdeep Kaur <arshdeep.kaur@intel.com>

Acked-by: Reshma Pattan <reshma.pattan@intel.com>
Thomas Monjalon Oct. 31, 2022, 1:45 p.m. UTC | #2 
15/09/2022 10:44, Pattan, Reshma:
> From: Arshdeep Kaur <arshdeep.kaur@intel.com>
> > 
> > Correction in handling 'IF' condition for -i parameter.
> > Fixes: cbb44143be74 ("app/dumpcap: add new packet capture application")
> > Signed-off-by: Arshdeep Kaur <arshdeep.kaur@intel.com>
> 
> Acked-by: Reshma Pattan <reshma.pattan@intel.com>

Sorry for not noticing, it was merged in DPDK 22.11-rc1.
diff mbox series

Patch

diff --git a/app/dumpcap/main.c b/app/dumpcap/main.c
index a6041d4ff4..8972c45a71 100644
--- a/app/dumpcap/main.c
+++ b/app/dumpcap/main.c
@@ -240,7 +240,7 @@  static void select_interface(const char *arg)
 {
 	uint16_t port;
 
-	if (strcmp(arg, "*"))
+	if (!strcmp(arg, "*"))
 		select_all_interfaces();
 	else if (rte_eth_dev_get_port_by_name(arg, &port) == 0)
 		add_interface(port, arg);