From patchwork Wed Sep 28 05:25:02 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Gagandeep Singh X-Patchwork-Id: 117023 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id C3C37A00C2; Wed, 28 Sep 2022 07:25:45 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 1E4914281C; Wed, 28 Sep 2022 07:25:40 +0200 (CEST) Received: from EUR04-DB3-obe.outbound.protection.outlook.com (mail-eopbgr60088.outbound.protection.outlook.com [40.107.6.88]) by mails.dpdk.org (Postfix) with ESMTP id 7F68341145 for ; Wed, 28 Sep 2022 07:25:38 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Y922YxrL0i2RU/Jwgrs8652zFvwRRJAggz0Q1YeBhDvPLx9XSNFN2aVquRaKLgz54dvl/psVkdus5cJPw87FPAU6CLK2MUV2u00oNtr/+2ckQfz47V7UvcGdWX0qCmMotChK5l6fP1sKDq74figFy3NJpXWbBecXJPUXnbs5EElb2lCghhx1aM+2c5Qts2dJR7AZ1fU3ulb7o/1lf8DE+/inochrOwi1xDsbPIUjjOs5ENqY1jzT5Q3S8VSo2ZzlVsmFZOVX/n4nbHWSi/2qdjfAzdtrEtRfxiWyRd32sb9KV7CyETJR7G7A3ORGLdN9v2T/HioAx3PfF3+jFPXvqw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=1rnnjtM9nYJ3R6kkkt2a0cTqPcoJwiwORFBckVqRzp4=; b=WfIraMBPOG+d6J8ICsunVkaFaEthVvIqsAI2tQZjhyv7iY53rCFVpZ9i038td3wBTZk+D+MhzOdtevz3yJ4sfLwwdt7od3BA1jw4ltN4JmGPQjHHqd2xoduvN5Yk1DO+MUWl20A11lpSM9EyWAhCK1PFI8c1WL+1N5i+WZ+ZhvFPixjim/b9O/3tigLAabuAedVGHNXyGbo3KuPZoFdOt6CALIvinZCasGJzjpHcpJC4/sFKk11g9H3ZwaVHZoXYpjJa88rwNHF5PJsnr56fezC+TjSThXO0l4yKEIMU/JPxqTL8ZXGDp/oMNP0hDtA797iA5W0EgA7kiyq0zSF/2A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com; dkim=pass header.d=nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=1rnnjtM9nYJ3R6kkkt2a0cTqPcoJwiwORFBckVqRzp4=; b=jDNCvtZFQw7oPXY2jswGlZ+xkQoezXUIv/Q8KXgsP5hSQje7lzSSEBKHfK0QNT0UIBRZGLj2/nyV65pKcZbxT0xlnqBM7Oi9/YxqBi1LRe7a6q9XR0e6dsebLjRJBK+KnN+/lgGpocR4inLYk5B3swVV1Cnoip5YPN0UXcFJm1E= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nxp.com; Received: from AS8PR04MB8198.eurprd04.prod.outlook.com (2603:10a6:20b:3b0::14) by PA4PR04MB7504.eurprd04.prod.outlook.com (2603:10a6:102:e6::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5654.25; Wed, 28 Sep 2022 05:25:37 +0000 Received: from AS8PR04MB8198.eurprd04.prod.outlook.com ([fe80::14d0:4458:d6ec:b8b1]) by AS8PR04MB8198.eurprd04.prod.outlook.com ([fe80::14d0:4458:d6ec:b8b1%7]) with mapi id 15.20.5676.017; Wed, 28 Sep 2022 05:25:37 +0000 From: Gagandeep Singh To: ferruh.yigit@amd.com, dev@dpdk.org Cc: Vanshika Shukla Subject: [PATCH 01/15] bus/dpaa: use non-block mode for FD open Date: Wed, 28 Sep 2022 10:55:02 +0530 Message-Id: <20220928052516.1279442-2-g.singh@nxp.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220928052516.1279442-1-g.singh@nxp.com> References: <20220928052516.1279442-1-g.singh@nxp.com> X-ClientProxiedBy: SGBP274CA0015.SGPP274.PROD.OUTLOOK.COM (2603:1096:4:b0::27) To AS8PR04MB8198.eurprd04.prod.outlook.com (2603:10a6:20b:3b0::14) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: AS8PR04MB8198:EE_|PA4PR04MB7504:EE_ X-MS-Office365-Filtering-Correlation-Id: d4494d9d-f71b-4ef2-5225-08daa111dff3 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: ZJ5l2pKGxOyxUM1m+aYA/DDR8ufBq+l1preUqRUz/coi8lFUrQo6cBaN5L7gAb5wb8koMtw091pH2S5+ZctEtm0DBsCE0tTbhvbYuHClLil8KfLChB0n1k1e2puHahRGsPTAukQQxqtoNBlafd6Le+Wg1N/MWiSN3KieDWWwp1mMwuCbf253jVpa3D03gX5ZlsxIw+FSlWE2SIWubGQ6KrdOXoscN7wZI8M+GO1+U+heVshPOUROv4XnMD7JL/yl3dQta3mkswgpSaNJpCrTW27dkMnlEko4JwGflHUR5M3J898bSX0+3u7I01qHC7A88/MbbwSMnZofrTaLi/+LEASsNbZPE/e0y584waG3pSRoDl9Vz+TAcbOvqrqXkOo5/t1F8j/CvC1TSoxy142DNUN1NTZ1Gs82nzdFqwvERJTJFTw3CUU3KrSRQy6ey/jcv1sU6txYSalEoIFexjRKmQoqMEUUXUzp8OAoYQKdoOdIfGiSv1CLczYQeiCmX7q+Y0JYyNSV/I0QNZiM1hRSfCyMDkJ+uJiIq15JZVlXS7xVrbpTStrqhJdo6stEnzsREgO6WgkG3T2i2LvF/6JlNjoGVdx0Q4WAn/MzI732SBa9WCi8CcigIpjtHjQQ4LvJ3QRMkcN07ZijIKAt4TIMTW2J5Ar6VWVGffSmM26/T262bLD6GGJvjmAPRiaU32Rxx+EUlG2Wc4o8pOqqyaK0HBxCK5IxmigdalSrX02/QJ9+PbP+UF3TZe4ZqdRnpNjkDLGJhKW4zWgom857chJv8Q== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:AS8PR04MB8198.eurprd04.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230022)(4636009)(346002)(366004)(376002)(396003)(136003)(39860400002)(451199015)(1076003)(186003)(2616005)(8676002)(83380400001)(38350700002)(8936002)(6506007)(38100700002)(26005)(86362001)(6512007)(6666004)(2906002)(5660300002)(52116002)(478600001)(66556008)(66476007)(66946007)(316002)(36756003)(41300700001)(4326008)(6486002); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: TG4PDhcGEU0lxdddwC7UBNO/Zsv1D+ILwRzapMQn5fwCUx0AFBg1/f3kQnUw8EsLx1jzQk4e8zyg1MtTrkbiuaS1DYpmxodRfkbLg8qIyyubm5sWQYQFAh4JRJ/bYUcAagYbojr2H0t4mwblBR4X4fWn0+dBikn+IDJTfEoMagoMtRIaZMCBEAtRFoVM5h2HKFpylNr7SntXZXnR1Zw2CTyTlgqAH2TKYjIZvQshFAjPtwQAUXft5TOAcgalcVQ863mykVqNHWMkjjWYqjq7ysQ0vZRBIeu4hrp7d2b9HdCCnQtdilDvkfn0KCRzCvXC5ncHhbiHtzV45UnVW7q/aQAIMvDcCILJm+rgSg8QqcD7oUov4S0ruKdNYU0ib1naE8Ql0FxnsvkWfeYpArzVXYnOsavfV91uSlbMGXNGXv46S8y+UIX8ZsCa5hpNEnQy8Z/GEiMY2Sgcz7U3R5wGPjEXOG5may2q4+J4DTy3SZ8D1ABs+03izqtRhhY0eamez30TspMKcgrRRRJjgoTGM6QQA/iQl8hSlJvM0tLAtY1WSh5WzenU4fQ5F63vyLPsdoW8O1hwtT/FS/ZIrDJV5KSoQa+gs+eSJckStnFfRL2zp8Z6GZqfqtqNKbBjMI4a359ew5f+Ie7KseD9WRiy8IYuWOe4XMRejhx06NS5qS4KzoF8YsvqAFANv3RKrVChDc4Tb0mLEq/ZqXjGVLGLm2mQWZK4UU+b8w3R3r3jy66uHdMRLuRis3caSBQwEy6oVBvpAzsSuA4HuGgS2f4O/upRieLzoVDPE1ReJMebUxaS7s5cLE8hYx1+VwjAirB6dXeIyTO0BHeVtLT8ekZdYrbOaQAbtCSjS2VnlK0I7pMFDg18MQDzDkU03WEnh5lW0XJXlQgFmYwAXyXQGJ7QUceif9x8RKnHi6TzLQdiMuWbrr7ervBK6C555yuweHtL4Y9q9uDqfxx53RzxtqypahKfGKorp4W6ZZSvMi/VhxYg5VDd4W8Rh8ycsYqMDMcelixVFA5R5L4W/c57sNKWSujRf1Wvsj4byGcKziX6rLRVWqkc3mrlXoxnHDcUS4iGs0HBXYS5S6LctAR+G0/s9AX6G8FlTH/iV6hbh+BcpbkAhRsV0qF8KETYBXvsPWE9v7qSp9EOCwQAd8Q9Fo+JjebjEmpZTkDYoln3btJVmQBQdP7eTft8VWY1bfMn5Fz5zkIfeEOWzLhYwyeZd9sY68MtGcAdlOcw+aoAHtPjm20AjZOeHq3Fn9vCDvmfrTuwzRAzjOBpAhMXx/5xtCsDV8uLLREWtjRQmZ9iGevzN14jDCNGEVWqy7z/p/SchxtCXL+romk1PHS3Was1R7YwFwG0mZdbPfFlGq/d5zdQGzCTu8RFbacaR66ZEZi4m7MoVa3Di3+X0WpEyYfu3iDfs8JPK7gwgEm6MpQzLK1lJ1g4DOSeCMg26RSGPsyCrP8q4Ycpu1uurgEQR7TeoJe941psvi5lH9ROmy1TACDCOuy5p4CyCxBYPPMFd19Tn1HGRnJ530/RTBnnPh/o1gOZLYI09lzDYzn86d49u3dQYPFnVgrdZCkXUYD8VASqdohP X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: d4494d9d-f71b-4ef2-5225-08daa111dff3 X-MS-Exchange-CrossTenant-AuthSource: AS8PR04MB8198.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Sep 2022 05:25:37.2783 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: zkXB/XDm4L4DvZH9pns+Nu3kQWHgVqh7YhQ3OSLmjVPgj2lag/4sTbJqvC1mgoV8 X-MS-Exchange-Transport-CrossTenantHeadersStamped: PA4PR04MB7504 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org From: Vanshika Shukla This patch sets qman portal file descriptors used for interrupts IO processing in non-blocking mode to avoid any unwanted blocks while IO operations over the FD. Signed-off-by: Vanshika Shukla --- drivers/bus/dpaa/base/qbman/qman_driver.c | 6 +++--- drivers/net/dpaa/dpaa_ethdev.c | 2 +- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/bus/dpaa/base/qbman/qman_driver.c b/drivers/bus/dpaa/base/qbman/qman_driver.c index dfbafe581a..7a129a2d86 100644 --- a/drivers/bus/dpaa/base/qbman/qman_driver.c +++ b/drivers/bus/dpaa/base/qbman/qman_driver.c @@ -1,7 +1,7 @@ /* SPDX-License-Identifier: (BSD-3-Clause OR GPL-2.0) * * Copyright 2008-2016 Freescale Semiconductor Inc. - * Copyright 2017,2019 NXP + * Copyright 2017-2022 NXP * */ @@ -64,7 +64,7 @@ static int fsl_qman_portal_init(uint32_t index, int is_shared) qpcfg.addr_virt[DPAA_PORTAL_CE] = map.addr.cena; qpcfg.addr_virt[DPAA_PORTAL_CI] = map.addr.cinh; - qmfd = open(QMAN_PORTAL_IRQ_PATH, O_RDONLY); + qmfd = open(QMAN_PORTAL_IRQ_PATH, O_RDONLY | O_NONBLOCK); if (qmfd == -1) { pr_err("QMan irq init failed\n"); process_portal_unmap(&map.addr); @@ -174,7 +174,7 @@ struct qman_portal *fsl_qman_fq_portal_create(int *fd) q_pcfg->addr_virt[DPAA_PORTAL_CE] = q_map.addr.cena; q_pcfg->addr_virt[DPAA_PORTAL_CI] = q_map.addr.cinh; - q_fd = open(QMAN_PORTAL_IRQ_PATH, O_RDONLY); + q_fd = open(QMAN_PORTAL_IRQ_PATH, O_RDONLY | O_NONBLOCK); if (q_fd == -1) { pr_err("QMan irq init failed\n"); goto err; diff --git a/drivers/net/dpaa/dpaa_ethdev.c b/drivers/net/dpaa/dpaa_ethdev.c index f21cbba0d9..abcb1bc9ec 100644 --- a/drivers/net/dpaa/dpaa_ethdev.c +++ b/drivers/net/dpaa/dpaa_ethdev.c @@ -1496,7 +1496,7 @@ static int dpaa_dev_queue_intr_disable(struct rte_eth_dev *dev, temp1 = read(rxq->q_fd, &temp, sizeof(temp)); if (temp1 != sizeof(temp)) - DPAA_PMD_ERR("irq read error"); + DPAA_PMD_DEBUG("read did not return anything"); qman_fq_portal_thread_irq(rxq->qp);