From patchwork Thu Sep 29 01:32:59 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Sevincer, Abdullah" X-Patchwork-Id: 117084 X-Patchwork-Delegate: jerinj@marvell.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id DBF2AA00C4; Thu, 29 Sep 2022 03:33:35 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 65C1C4282D; Thu, 29 Sep 2022 03:33:23 +0200 (CEST) Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by mails.dpdk.org (Postfix) with ESMTP id 9073C42802 for ; Thu, 29 Sep 2022 03:33:21 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1664415201; x=1695951201; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=fEcc1VsWRe+dkbfKigdMRZ7ibY+2QiTT5nCouS0SBYQ=; b=lCjqX/1CMJmPDwfhkgmZB5SIUB+9sIyfuXdGQv4akd1yllZFwcjdgPHu 341daZlWCk3kKuLpcOn5pnXnJReF3p16gF+guKCVGQEYVgyvYl2+i5zj2 2I2dCb3+05oY3KMiqXJ14FbrdBPB5/HkPRDbvUjqj79gVyK8B8DElCT7d uCFnhhmx2J1q7kBzzgjRdnhhRHUxQl8xLwtcc5RHU1Vv93CETY7KWXEk6 uVWFjLV+TqLD4ReaC2UEHEy2BiN51JNUXneGEcnDUgKVgeb9AqWzraSBj BGLGxO+zSg66NbI+j22KZ/iY5ZUhrMP1UUuxME8wXUrpiiNQs3qcLLuzl w==; X-IronPort-AV: E=McAfee;i="6500,9779,10484"; a="328135450" X-IronPort-AV: E=Sophos;i="5.93,353,1654585200"; d="scan'208";a="328135450" Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 28 Sep 2022 18:33:07 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10484"; a="764516640" X-IronPort-AV: E=Sophos;i="5.93,353,1654585200"; d="scan'208";a="764516640" Received: from txanpdk02.an.intel.com ([10.123.117.76]) by fmsmga001.fm.intel.com with ESMTP; 28 Sep 2022 18:33:04 -0700 From: Abdullah Sevincer To: dev@dpdk.org Cc: jerinj@marvell.com, Abdullah Sevincer Subject: [PATCH v8 3/3] event/dlb2: optimize credit allocations Date: Wed, 28 Sep 2022 20:32:59 -0500 Message-Id: <20220929013259.1661509-3-abdullah.sevincer@intel.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220929013259.1661509-1-abdullah.sevincer@intel.com> References: <20220927014204.1401746-1-abdullah.sevincer@intel.com> <20220929013259.1661509-1-abdullah.sevincer@intel.com> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org This commit implements the changes required for using suggested port type hint feature. Each port uses different credit quanta based on port type specified using port configuration flags. Each port has separate quanta defined in dlb2_priv.h Producer and consumer ports will need larger quanta value to reduce number of credit calls they make. Workers can use small quanta as they mostly work out of locally cached credits and don't request/return credits often. Signed-off-by: Abdullah Sevincer --- drivers/event/dlb2/dlb2.c | 20 +++++++++++++++++++- 1 file changed, 19 insertions(+), 1 deletion(-) diff --git a/drivers/event/dlb2/dlb2.c b/drivers/event/dlb2/dlb2.c index 4dd1d55ddc..164ebbcfe2 100644 --- a/drivers/event/dlb2/dlb2.c +++ b/drivers/event/dlb2/dlb2.c @@ -1965,8 +1965,8 @@ dlb2_eventdev_port_setup(struct rte_eventdev *dev, { struct dlb2_eventdev *dlb2; struct dlb2_eventdev_port *ev_port; - int ret; uint32_t hw_credit_quanta, sw_credit_quanta; + int ret; if (dev == NULL || port_conf == NULL) { DLB2_LOG_ERR("Null parameter\n"); @@ -2067,6 +2067,24 @@ dlb2_eventdev_port_setup(struct rte_eventdev *dev, ev_port->inflight_credits = 0; ev_port->dlb2 = dlb2; /* reverse link */ + /* Default for worker ports */ + sw_credit_quanta = dlb2->sw_credit_quanta; + hw_credit_quanta = dlb2->hw_credit_quanta; + + if (port_conf->event_port_cfg & RTE_EVENT_PORT_CFG_HINT_PRODUCER) { + /* Producer type ports. Mostly enqueue */ + sw_credit_quanta = DLB2_SW_CREDIT_P_QUANTA_DEFAULT; + hw_credit_quanta = DLB2_SW_CREDIT_P_BATCH_SZ; + } + if (port_conf->event_port_cfg & RTE_EVENT_PORT_CFG_HINT_CONSUMER) { + /* Consumer type ports. Mostly dequeue */ + sw_credit_quanta = DLB2_SW_CREDIT_C_QUANTA_DEFAULT; + hw_credit_quanta = DLB2_SW_CREDIT_C_BATCH_SZ; + } + ev_port->credit_update_quanta = sw_credit_quanta; + ev_port->qm_port.hw_credit_quanta = hw_credit_quanta; + + /* Tear down pre-existing port->queue links */ if (dlb2->run_state == DLB2_RUN_STATE_STOPPED) dlb2_port_link_teardown(dlb2, &dlb2->ev_ports[ev_port_id]);