diff mbox series

net/qede/base: fix 32-bit build with GCC 12

Message ID 20221004111811.1502920-1-thomas@monjalon.net (mailing list archive)
State Superseded, archived
Delegated to: Jerin Jacob
Headers
Series net/qede/base: fix 32-bit build with GCC 12 |

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/iol-mellanox-Performance success Performance Testing PASS
ci/iol-intel-Functional success Functional Testing PASS
ci/iol-aarch64-unit-testing success Testing PASS
ci/iol-x86_64-unit-testing success Testing PASS
ci/iol-intel-Performance success Performance Testing PASS
ci/github-robot: build success github build: passed
ci/iol-x86_64-compile-testing success Testing PASS
ci/iol-aarch64-compile-testing success Testing PASS

Commit Message

Thomas Monjalon Oct. 4, 2022, 11:18 a.m. UTC 
  A pointer is passed to a macro and it seems mistakenly referenced.
This issue is seen only when compiling with GCC 12 for 32-bit:

drivers/net/qede/base/ecore_init_fw_funcs.c:1418:25:
        error: array subscript 1 is outside array bounds of ‘u32[1]’
        {aka ‘unsigned int[1]’} [-Werror=array-bounds]
 1418 |                 ecore_wr(dev, ptt, ((addr) + (4 * i)),  \
      |                 ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
 1419 |                          ((u32 *)&(arr))[i]);           \
      |                          ~~~~~~~~~~~~~~~~~~~
drivers/net/qede/base/ecore_init_fw_funcs.c:1465:17:
        note: in expansion of macro ‘ARR_REG_WR’
 1465 |         ARR_REG_WR(p_hwfn, p_ptt, addr, pData, len_in_dwords);
      |         ^~~~~~~~~~
drivers/net/qede/base/ecore_init_fw_funcs.c:1439:35:
        note: at offset 4 into object ‘pData’ of size 4
 1439 |                              u32 *pData,
      |                              ~~~~~^~~~~

Fixes: 3b307c55f2ac ("net/qede/base: update FW to 8.40.25.0")
Cc: stable@dpdk.org

Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
---
 drivers/net/qede/base/ecore_init_fw_funcs.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

David Marchand Oct. 5, 2022, 7:28 p.m. UTC | #1 
On Tue, Oct 4, 2022 at 1:18 PM Thomas Monjalon <thomas@monjalon.net> wrote:
>
> A pointer is passed to a macro and it seems mistakenly referenced.
> This issue is seen only when compiling with GCC 12 for 32-bit:
>
> drivers/net/qede/base/ecore_init_fw_funcs.c:1418:25:
>         error: array subscript 1 is outside array bounds of ‘u32[1]’
>         {aka ‘unsigned int[1]’} [-Werror=array-bounds]
>  1418 |                 ecore_wr(dev, ptt, ((addr) + (4 * i)),  \
>       |                 ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>  1419 |                          ((u32 *)&(arr))[i]);           \
>       |                          ~~~~~~~~~~~~~~~~~~~
> drivers/net/qede/base/ecore_init_fw_funcs.c:1465:17:
>         note: in expansion of macro ‘ARR_REG_WR’
>  1465 |         ARR_REG_WR(p_hwfn, p_ptt, addr, pData, len_in_dwords);
>       |         ^~~~~~~~~~
> drivers/net/qede/base/ecore_init_fw_funcs.c:1439:35:
>         note: at offset 4 into object ‘pData’ of size 4
>  1439 |                              u32 *pData,
>       |                              ~~~~~^~~~~
>
> Fixes: 3b307c55f2ac ("net/qede/base: update FW to 8.40.25.0")
> Cc: stable@dpdk.org
>
> Signed-off-by: Thomas Monjalon <thomas@monjalon.net>

Reproduced and tested build fix.
Tested-by: David Marchand <david.marchand@redhat.com>
Thomas Monjalon Oct. 6, 2022, 10:27 a.m. UTC | #2 
04/10/2022 13:18, Thomas Monjalon:
> A pointer is passed to a macro and it seems mistakenly referenced.
> This issue is seen only when compiling with GCC 12 for 32-bit:
> 
> drivers/net/qede/base/ecore_init_fw_funcs.c:1418:25:
>         error: array subscript 1 is outside array bounds of ‘u32[1]’
>         {aka ‘unsigned int[1]’} [-Werror=array-bounds]
>  1418 |                 ecore_wr(dev, ptt, ((addr) + (4 * i)),  \
>       |                 ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>  1419 |                          ((u32 *)&(arr))[i]);           \
>       |                          ~~~~~~~~~~~~~~~~~~~
> drivers/net/qede/base/ecore_init_fw_funcs.c:1465:17:
>         note: in expansion of macro ‘ARR_REG_WR’
>  1465 |         ARR_REG_WR(p_hwfn, p_ptt, addr, pData, len_in_dwords);
>       |         ^~~~~~~~~~
> drivers/net/qede/base/ecore_init_fw_funcs.c:1439:35:
>         note: at offset 4 into object ‘pData’ of size 4
>  1439 |                              u32 *pData,
>       |                              ~~~~~^~~~~
> 
> Fixes: 3b307c55f2ac ("net/qede/base: update FW to 8.40.25.0")
> Cc: stable@dpdk.org
> 
> Signed-off-by: Thomas Monjalon <thomas@monjalon.net>

A similar patch was sent 6 weeks ago by Amit Prakash Shukla.
diff mbox series

Patch

diff --git a/drivers/net/qede/base/ecore_init_fw_funcs.c b/drivers/net/qede/base/ecore_init_fw_funcs.c
index 6a52f32cc9..0aa7f85567 100644
--- a/drivers/net/qede/base/ecore_init_fw_funcs.c
+++ b/drivers/net/qede/base/ecore_init_fw_funcs.c
@@ -1416,7 +1416,7 @@  void ecore_init_brb_ram(struct ecore_hwfn *p_hwfn,
 		u32 i;						\
 		for (i = 0; i < (arr_size); i++)		\
 			ecore_wr(dev, ptt, ((addr) + (4 * i)),	\
-				 ((u32 *)&(arr))[i]);		\
+				 ((u32 *)arr)[i]);		\
 	} while (0)
 
 #ifndef DWORDS_TO_BYTES