From patchwork Fri Oct 7 03:27:36 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Gagandeep Singh X-Patchwork-Id: 117539 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 8AFF9A00C2; Fri, 7 Oct 2022 05:29:41 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 389AF42B96; Fri, 7 Oct 2022 05:28:53 +0200 (CEST) Received: from EUR04-DB3-obe.outbound.protection.outlook.com (mail-eopbgr60069.outbound.protection.outlook.com [40.107.6.69]) by mails.dpdk.org (Postfix) with ESMTP id 911DC42B71 for ; Fri, 7 Oct 2022 05:28:51 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=nGedynBSxypWdUgJgphyfdwvNhoQ7n/UdbCwbgaHW59kwoSU8lt/mQnjYVzFtQJ74Q7kZmk0Ci8vyz6KDS0316Naku7Rr+EcGZTPvWAiC+1hiNtpaoX/sKdSHKRKanI3fwYXRsTCjBgZohEbtEwzqNZnmI1gOYb7WQbsXpRyjL0fWIXCTv1KlJ7qjPscQzYBDlebMlzIfk3lzYN38aq9NCyyC17FRzx7d6bZIyE4biRYwoFM/6YbUjhvz/8xOOwpH12DLD2DLVDrETyYrWcXuMxWvp/PQ+YkQ8Z68CpR5C7l8xAMUJ+PqrRIG/QmIigw1bSXJGWUXmOEFj8bmXFBUQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=NgwqLhJh7thY5whrvNk4Kl1QzQXpXDsXC+1/90sqYwM=; b=nBkgTtP3SqCy2xQYQUi/MoYFv6qKJx4t7XkReDYq9Ndcduz004Cgm9rZgOziXhLyRXKGDS4KITENkpD+ndaHKHYRb4EM4IOdBkq9M92Vmp+2Rt3zzEc55lEJQ9abvOjWQg9w/v7cmx5u5kz1EeCmBRr8aFv1f+9LVmHgW43KENp/5VNVSSH9VVszYcvznuCB4QTsw7AgQ3/zILIZ0U/sT2vUfkKUQUyVV9SGGWfC3nGelwTysS8mEiaZuJODLpEtHGO2FVlK7gJVvydgYBuOpdTeRlRTtq+ImN0SZFppAsxlVJFUhgmE7c0yRRmlwUckgFQp36bWg2VQs+DrIzlRJw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com; dkim=pass header.d=nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=NgwqLhJh7thY5whrvNk4Kl1QzQXpXDsXC+1/90sqYwM=; b=N9B5zowqjY8t+KAug99tv1EIj4csHQIRi5fuqXX7t1QZvKUXHExoRLGTqWo2rtt2G14bo0SbsJWyqIJOtX2Bela8SmUCFPJheyLeCaUM8nbOUl5NwRHqeCs3mAuLTWwB8eGNHSrRrIlv/gEM5hnxbivUO96BzI6a/cz09MozDmU= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nxp.com; Received: from AS8PR04MB8198.eurprd04.prod.outlook.com (2603:10a6:20b:3b0::14) by PAXPR04MB9326.eurprd04.prod.outlook.com (2603:10a6:102:2b8::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5676.28; Fri, 7 Oct 2022 03:28:50 +0000 Received: from AS8PR04MB8198.eurprd04.prod.outlook.com ([fe80::9ee7:dafa:ba51:c71e]) by AS8PR04MB8198.eurprd04.prod.outlook.com ([fe80::9ee7:dafa:ba51:c71e%7]) with mapi id 15.20.5676.032; Fri, 7 Oct 2022 03:28:50 +0000 From: Gagandeep Singh To: ferruh.yigit@amd.com, dev@dpdk.org Cc: Rohit Raj , Hemant Agrawal Subject: [PATCH v2 09/16] bus/fslmc: add timeout in MC send command API Date: Fri, 7 Oct 2022 08:57:36 +0530 Message-Id: <20221007032743.2129353-10-g.singh@nxp.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20221007032743.2129353-1-g.singh@nxp.com> References: <20220928052516.1279442-1-g.singh@nxp.com> <20221007032743.2129353-1-g.singh@nxp.com> X-ClientProxiedBy: SG2P153CA0033.APCP153.PROD.OUTLOOK.COM (2603:1096:4:c7::20) To AS8PR04MB8198.eurprd04.prod.outlook.com (2603:10a6:20b:3b0::14) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: AS8PR04MB8198:EE_|PAXPR04MB9326:EE_ X-MS-Office365-Filtering-Correlation-Id: f0e61118-2f67-42ea-784a-08daa8140d3d X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: IMbRu9NAJSRdrxBV9uAJIwc42Gwyzj4meG6S0GiB6m7Tqa/6yD1Qky22to1mJJKRbRTdGcYlUIZml8E++Qm+mHVH1fgj2HAvWq9tF6KU8lx5wqLUXEoyT7hgsInXG+0xlXLKjzOvHQ6I3g3WvQ7w0c+JwT8UVF0oixKBpK1UO/viS2MJAz5s/JglVm9XkDUSlQeqP+FvM0H6gUYEXLH0YBpfGxaUo+0lYTv+eNhgn/6T4DAQgUEitOHS0hFixnDtImUPMLBRtHsEDhOhs0l86AbfBqa+5TvyAfPRRRvGtNae9aM8tdSpkP76nhwPs9diq3ozQT48fQtTXKFZOxuqggy3H6DLBsLMMGs9RfsmgbX1l8bcRVXyTf9mwmobWubL8THhyyyJHUNz0Y9ntAHLk7L9Ea29abhHSXwP8pczUwetygSwuK35OPqnSY9Qh++xD3YTm49j69WxQNXJpFYuyri7a53l08GaYjKceoPdra9M70xtxDR17P20kvfk2c11xKwngYhmiZbUEIWI7psMowo7VWGhLv5ZxSd1q+DS7hvu8g6LdO+6Y6Ch8pgV4ddUCxHcsjYLSdJp8Um5UIDVMzXDSrIz2dLDuDCCUixJYPbMgRegla2UPH+eyo1Pv5KthrTteKG3ziDh2vr7ey0av3LHcP9lfVNfM1jD2ZEOQwqHmNqwq9CQ3uERa/+9GbXDOHSiWKl2XJLpDmcx4fRPmW7TSJkt6EbUg0/coOXNJ4wTS78Bxig5MHm383Yt1CkSe/3bGj+r9uoZOkZu+X59ww== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:AS8PR04MB8198.eurprd04.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230022)(4636009)(376002)(136003)(396003)(39860400002)(346002)(366004)(451199015)(2906002)(5660300002)(66946007)(66556008)(66476007)(54906003)(478600001)(8676002)(316002)(86362001)(6486002)(4326008)(41300700001)(6666004)(6506007)(38100700002)(26005)(52116002)(6512007)(38350700002)(83380400001)(8936002)(36756003)(2616005)(1076003)(186003); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: KTmWNJShMmu92uEgE/Gz/zmfvRLEd5kAQryyhRK137DCceslKkOsttYJshSThdvXuUFTDYDJIEqVKAmCL4RU1rBSo/Yq3W/+2JeWjQcmsDXHAcL3VN3IQ3tEbF6gHNrKFEY2knmjrKuAt1n6xOh45t29njOz0y8UjYMJtII45IFFWHfCeO8WkttLOhn3yEJzcfySP7mYKzqw5LiZxGzsKnSwTr55EuFqhOuT7ZVxThypqavqW6a4LaJ0/npnBw9gTgWH+LJdHlS+0xIj7ii1Ku3rg5GgcNnTTP5cDgUSxvnIaPQ4uDTbfJuX/l/Az1ClPiduFujPQvapoc5UjxTTMcuqXIYxqVle2bz5XOORYZ/JlWeJkIIcQjPkvLDGAbzHKmXqWFU5Hfq+vrRc1hWrbJQBmuxBaVs+NQKAOkxUym/y+rvskEfo3rw/HDB+lxir9/zhaAbEWCIqUa2/taFFQ4nhwKbjFhwqYhnoXjcwKtBP/K11rJhepqv2GOeEMLgOvKAqoCpxghEbXYCtVSaMGeuUvKqbEvvhtpUptlFqeyqMdMqqqGBRSzcMIAs6PHXrmguc8qj87EBnqamKzBH16p7PFkOOQ8j+nxdQ56yg3qwTpW7Ocl9RbNZoNoJP2PqTR0tMMAO/hgWAWMnwfHUwK7ZFAL+QHQlJ+F3nh8lBzHo4bPsEjkPo49Epd2hcxkhfyTwwBnAPHwgSsrh+MpJedLELb2fjjSSYC/dqKSopK7px5gIIUbWI04UZu+QycRTsAB2dTToDUJD9cmmR30tvNkpgys9qq8O8IIGXsgIyJX/5/c/pPp4GqfL4YqhMyxUgxrdRDduKX0mkkxvauG8vHW/W0Bw9bDZRCJjSiP0+YPVl2VziGdAmkCnNyp3HgwJCoe9vnEEk0MKylwl7f9RWJCO+IH1T6isvJ+ihm8F7LkshB+e+gQvHUBmxb03Zh7JsjUGihFW2F1rgOMkR6p35n11sUzaqdLi8unhjogOOcy0UspArOrMG6fNDj2q+0fmVM9ooFx9WhZ+jd2u1Sd3mCaDg/xO8y5afztiuPY5As5/OXjkPTKVdcRJF8f0u0NyQ1fmTEEhT5iG03xC3agFNhnR6Sswyg+V/g2Wf8j8M6GTw57sNqtzy0NYDSSYn3QEiZ8YukRGnBMroGkKa7IgGZEtlpXceZCPBAwCrsQ37aFJriMu0czN7BBvfMtB6c/Nu6R/MF0lCROzmL8ZTCMdgYtBDhIl14/X782LeR2lF+wwTAwA2/8mpdollWDSow3+lItZJWEi3Nji/iZ62WJZFryXrUYY6hMMm0PkNIWcx45rC96bDtxNnDctnyrzMq2JumaQesPv+RyHUloLMvUnMpHgv3yq0AGL3x0sw82+wKSwQ8d6+ypI5u9hcRPXLpw0RIQ7t0xAo2aTwMBM75watRAvMSHage7+13AR8nxUll4kPJJ9iDTxOy4rN35h3xMg/+/xbrWdZ77ExuohYUrSaxUH2HJsybYoixE5tg6GCh+ZMOYlSQ4xLyqoQYLa6nEm9ujgYUXICmxGrQmnTrzlPaJPpplxXhea0waKWwknsK9GzyAyz/ys1NMTZPpGY4PAO X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: f0e61118-2f67-42ea-784a-08daa8140d3d X-MS-Exchange-CrossTenant-AuthSource: AS8PR04MB8198.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Oct 2022 03:28:50.4571 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: /nS6+hZW/gcU3KFOKjOPtvmT9TnGpltDDkGm4wVuMk6YnAkDsTj2yhFEtBs2ucVG X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR04MB9326 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org From: Rohit Raj Adding one second timeout in MC send command API to ensure it doesn't gets stuck in case of failure. Signed-off-by: Rohit Raj Acked-by: Hemant Agrawal --- drivers/bus/fslmc/mc/mc_sys.c | 18 ++++++++++++------ 1 file changed, 12 insertions(+), 6 deletions(-) diff --git a/drivers/bus/fslmc/mc/mc_sys.c b/drivers/bus/fslmc/mc/mc_sys.c index efafdc3101..ab9a074835 100644 --- a/drivers/bus/fslmc/mc/mc_sys.c +++ b/drivers/bus/fslmc/mc/mc_sys.c @@ -1,13 +1,14 @@ /* SPDX-License-Identifier: (BSD-3-Clause OR GPL-2.0) * * Copyright 2013-2015 Freescale Semiconductor Inc. - * Copyright 2017 NXP + * Copyright 2017,2022 NXP * */ #include #include #include +#include /** User space framework uses MC Portal in shared mode. Following change * introduces lock in MC FLIB @@ -54,7 +55,7 @@ static int mc_status_to_error(enum mc_cmd_status status) int mc_send_command(struct fsl_mc_io *mc_io, struct mc_command *cmd) { enum mc_cmd_status status; - uint64_t response; + uint64_t response, start_time, total_time, time_to_wait; if (!mc_io || !mc_io->regs) return -EACCES; @@ -64,15 +65,20 @@ int mc_send_command(struct fsl_mc_io *mc_io, struct mc_command *cmd) mc_write_command(mc_io->regs, cmd); + /* Wait for one second. rte_get_timer_hz() returns frequency of CPU */ + time_to_wait = rte_get_timer_hz(); + total_time = 0; + start_time = rte_get_timer_cycles(); + /* Spin until status changes */ do { response = ioread64(mc_io->regs); status = mc_cmd_read_status((struct mc_command *)&response); + total_time = rte_get_timer_cycles() - start_time; + } while (status == MC_CMD_STATUS_READY && total_time <= time_to_wait); - /* --- Call wait function here to prevent blocking --- - * Change the loop condition accordingly to exit on timeout. - */ - } while (status == MC_CMD_STATUS_READY); + if (status == MC_CMD_STATUS_READY) + return mc_status_to_error(MC_CMD_STATUS_TIMEOUT); /* Read the response back into the command buffer */ mc_read_response(mc_io->regs, cmd);