From patchwork Fri Oct 7 03:27:31 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Gagandeep Singh X-Patchwork-Id: 117534 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 1DC19A00C2; Fri, 7 Oct 2022 05:29:04 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 8564142B72; Fri, 7 Oct 2022 05:28:42 +0200 (CEST) Received: from EUR02-AM5-obe.outbound.protection.outlook.com (mail-eopbgr00050.outbound.protection.outlook.com [40.107.0.50]) by mails.dpdk.org (Postfix) with ESMTP id 2BA1640042; Fri, 7 Oct 2022 05:28:41 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=HOPU83r5TFHRpCyGfiuz9W6JA0fY12YycOkvXT4XJQLuuJ5DS++CJokJnQ61LICCg4iymStgUFBIc1mhTx5aM8/07FFaODfsa3f7LS7IdQHUTyY6Rb7I+KaTG1FqpL5t088NaFSFZDpQtd5Yb8b1Dgq32Y6IFoEMmJNpvYW2FquDiEUEA8eheDU06Ga/vBeFCcSn0G68IV5SAXXuc6y+sbivQnDMvMWwRysbmLkNapyUEIlvjOzl0zO3ObsgaqAZBEKu2qtVwrvL02Tr1pvudOztX5f41XvsS1/5M6YEGoGfAjwHn5w6Zup2p5KPZUWLAAsBnaO2fZklXxfZnkvzQg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=OR5xn3GuATQlY2iJfQAg355HmPhmYQfs7//idlb9Sks=; b=km2WufTKJVgRhkdRkyw1Zvn2OmECKaJ8kHBwn3R7C3ivSrwyVO0bHeup4FMVr83s2jTwifuRV4EU1ivEkADTkm/azyk3tF69Lt9PedLNVLJH+Myq0SowHrVzDuPX5cbQXbA+guaHqU+SxkLYJlrcOPZAjt1l18Nz6YoIAEs3AGWifbtPnib89boW1QnoTsj1N1wXeSx+FM8i8P8A1maM0z5zEYXJLniZxYpEbSw0/AmpvaOmKG5pRzZre+vA2AWgpHryncPH7Mt0GVdGEcENe4QyNipIKqR4Gf3Oel5PwJHamo73VHGeZgF7bY6K9MP7fJFc5ase8DmWPz3mFOR7Wg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com; dkim=pass header.d=nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=OR5xn3GuATQlY2iJfQAg355HmPhmYQfs7//idlb9Sks=; b=qaOAZ4KgLL6ng1OgIuf+f+UuxNJNfzdit7nRde2LHTQ0FEtow37TUrMu2aVZjgGBJYCR4ARJkXnEhFpXpdNouZKDay83Ceovx68wOcuBKKcjlpSwnGVtdW1UKuqkHus7UN+KnBizR7k++iJTI6jMbn7HvKa+K60lcGrgF2P6qh8= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nxp.com; Received: from AS8PR04MB8198.eurprd04.prod.outlook.com (2603:10a6:20b:3b0::14) by AS8PR04MB8641.eurprd04.prod.outlook.com (2603:10a6:20b:428::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5676.38; Fri, 7 Oct 2022 03:28:40 +0000 Received: from AS8PR04MB8198.eurprd04.prod.outlook.com ([fe80::9ee7:dafa:ba51:c71e]) by AS8PR04MB8198.eurprd04.prod.outlook.com ([fe80::9ee7:dafa:ba51:c71e%7]) with mapi id 15.20.5676.032; Fri, 7 Oct 2022 03:28:40 +0000 From: Gagandeep Singh To: ferruh.yigit@amd.com, dev@dpdk.org Cc: Vanshika Shukla , stable@dpdk.org, Hemant Agrawal Subject: [PATCH v2 04/16] net/dpaa2: fix dpdmux configuration for error behaviour Date: Fri, 7 Oct 2022 08:57:31 +0530 Message-Id: <20221007032743.2129353-5-g.singh@nxp.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20221007032743.2129353-1-g.singh@nxp.com> References: <20220928052516.1279442-1-g.singh@nxp.com> <20221007032743.2129353-1-g.singh@nxp.com> X-ClientProxiedBy: SG2P153CA0033.APCP153.PROD.OUTLOOK.COM (2603:1096:4:c7::20) To AS8PR04MB8198.eurprd04.prod.outlook.com (2603:10a6:20b:3b0::14) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: AS8PR04MB8198:EE_|AS8PR04MB8641:EE_ X-MS-Office365-Filtering-Correlation-Id: 2077b02a-242d-46b6-51b5-08daa814075c X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 7fEGQd3QCLgGZcyC2aWY/L9MefKqp8cC41O2VDEeqO2COO1miT/itKTqjI3qyOCdlh+VB7wywEMv4ckksJbDQRWDyLRPvjHlTDbo5Xwo1QbHR1i4rsWrutqnifuq470uePUM8CxkoCGzHKmrFkxWqv4avNTUjCDrJCVKPJD2xMnx8TLcFHJNTimddpFIT1OIeXxuUOz9Yjk4req/P7sMcupke/fEr5bUmi1n+cJ1e318aGweDHq/pD2nwHVSwLqHhTG5o15unnIAEO6ntOG7huxKR2BZA1hMcgb6Wh7zOWSzH0S7T/G3T1tq70KP/zCH1za2RjewM4FLHgZhoU8vnUXJ5eJAhVYJqrXCl8zmYuxSbdU7qfGGFJWHmEYhoixSuOGEK5tkjJQ9F8PntQzgdU0PuWTLqwWCJziW+YW3s4w1swzMr3nkbI0X6z/COv4W7Q0qWKuw4GBN+nonbN8/oaS7hTuT7xIEyXuvJAu6IznZI3ox0FoB5AM/RoWBXq/E2kalRY+zsP4olQcEk8Y75JnnARQGJUhAEtJSIg0qEmmhqv/cVHAqr803pENJojoqkYZxZ9IBnrc59Pj7ZXpU8ProEjxVasbzkPLEMqdEYwDTm+DpkpF5i80PwfVLD5HqruB+N4GuCj8j5WRLZEbwBRJFX/mloSiJs2QXXrhCXf3S3EDiowjGSyq9WQBi1UAuXyIVJnp1Xq2WjUDOr2zFcz6w6todh6lNFqsevy7YpqP1irtkTZUKjGxWEVfK3HKuFSoUZ/g2TIt/iB8v7aXgnw== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:AS8PR04MB8198.eurprd04.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230022)(4636009)(39860400002)(136003)(366004)(396003)(376002)(346002)(451199015)(36756003)(54906003)(6486002)(6512007)(52116002)(26005)(83380400001)(6506007)(86362001)(5660300002)(8936002)(41300700001)(2906002)(38100700002)(316002)(38350700002)(8676002)(4326008)(478600001)(186003)(1076003)(6666004)(66476007)(66556008)(2616005)(66946007); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: Q5QRa29jrHnxBAkLRX5CL/3xXbo99vfch+hQTgRvg9ctgBZbPY6nFllyNow0H3Q3adA1fqhRUOauirJs8zCDTD+vzi2i8yhhf2Oo69nyEGry5mq1S/pg0DsanWPKekE4u2borPPRp2bpTeJcncijbga+uwXr38zd2w+PyLhCMfmSMTL7otZuwHqeQD7EBEG/DuDm/1hONtzIHVPTUHV2i5PxcrohmGdhjFsvNxaKCIghBSSU47BTTzLJgLKheVjbAxlV6rBeWmTJ61KAOzc8Cl7Z66o8nOjbHd6WZC++S38DBY1FEASkslfOAfDZ+p0MyUkcM9ZYPnYIgB1XUHRuM/okyer2ustRGYAu8dbuWDrUtZwPpbuqefwLLLnvZVincIh4vivtw+wj1XdnyIjjc2ixp7qm2R4WdSiUzhrb7qmuqGMr+dFdtIae/Zve++NHso9s5lwXDpmoUvY4bfw+07ZRPh7jhhf6dbs26tB4ERSqJNxYbdiKFNNDcQURSH+tOWptLDkHUMHPHXe9LNLZ1Pdee6rJapGo61fuqed6ALsgD4lS1tNmlEdmsObnysylkJijTvMyxu4RBgY+H+GhlP7523Ju0xeWTheuYYF8TRHU7S048Tz3XPWgllzK5hvsscl+8qrdxSwOedbZp1SeoaQlS/jIFfJiR2cxRKPDV6Ef+gQo6r1zavdwhdItREIpuHE278PkQS6SyQzsKFeDTCQSDK4ZGU4G8qIFeGX9I8pzPlYfpRPDbiBXuP8HsAUhSO2QBMX5xtzfIflMz5qHuEXaP2uWzeORd50B/loeHmoebj4A8Xzj4TbLsxr9zAUu/OMLPmlR9fcCqErdP8IY8E7vs5k/Dz0TBcODpdtPAZ5cxlXjKO8hwzGnJzWwDmU26rEE4caWO5oSZIWaYK7gOGBitMeexRK48FZGSPwZeRT2HvNyFukMbIsSIK2FvDzflxLdCTLvPh6DsFpG+pG3Pa4iQqXfM3aaLrYsTcEiREgjS/RzZVA4JsS6Kby8okVuxVyLaRxuzan0BH4SLzS9bpeEaCVaBaw9uO3p4lTZ3gbaI7h7zYL3dHmWbo7WjDu/hFA6sEOBYWrR9lv+t/zK9rfhofDKLTlUoAl9gRRgXmJQIxKHE6GYeQVo9BLd/9TC1vr/8IKOCbNKR5kaMGgRahnfKb7U0pVOQVwMQ6ShF6MU9NkMskqcTbVEHhpIGceiIyeFOkLGP0mbM4kACJ3rB7NN2HSnF0HuZdBKzDzbkhF5N04D5+Shfzl2Ua7Nxb7UxKGbp56Ri/NWxWXMngm8gcxzLAIfMqBITOC1cuOKr7KUEoYQDqrQ+Fk3+H3iB0BPTxuWaLbrye0COFFlR+YPLfnFtgDUs6ymQcFfYkxNgMY0et7GMvTUnBKLN2ACMjS+Nd8ad77LIfJKZXdyISQGnK6m2sDVTOU/4nh3I/U6B/KaDMXtlbg/lieaFah9zIOIeZH82yxKKPf4Fpua2Em5avNDZgq5u4pyKu1KJzXQ/MZwSY5x56u1wsrt7TB6nax9bAHYQoR+A+JFcIjTw+JM4Jrqz9X6X4LIzvi0QSws1G2fb70NEp0rWrmoEa24CHEL X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 2077b02a-242d-46b6-51b5-08daa814075c X-MS-Exchange-CrossTenant-AuthSource: AS8PR04MB8198.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Oct 2022 03:28:40.4680 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: EvbdO33KbYpdyfbAuzkxtbWV0d3nMSj7PCrpctZxUkXWkKT0v9+4Ph007HugkEA6 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR04MB8641 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org From: Vanshika Shukla Driver is giving the wrong interface ID while setting the error behaviour. This patch fixes the issue by passing the correct MAC interface index value to the API. Fixes: 3d43972b1b42 ("net/dpaa2: do not drop parse error packets by dpdmux") Cc: stable@dpdk.org Signed-off-by: Vanshika Shukla Acked-by: Hemant Agrawal --- drivers/net/dpaa2/dpaa2_ethdev.h | 3 +++ drivers/net/dpaa2/dpaa2_mux.c | 2 +- 2 files changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/net/dpaa2/dpaa2_ethdev.h b/drivers/net/dpaa2/dpaa2_ethdev.h index f69df95253..32ae762e4a 100644 --- a/drivers/net/dpaa2/dpaa2_ethdev.h +++ b/drivers/net/dpaa2/dpaa2_ethdev.h @@ -66,6 +66,9 @@ /* Tx confirmation enabled */ #define DPAA2_TX_CONF_ENABLE 0x06 +/* DPDMUX index for DPMAC */ +#define DPAA2_DPDMUX_DPMAC_IDX 0 + /* HW loopback the egress traffic to self ingress*/ #define DPAA2_TX_MAC_LOOPBACK_MODE 0x20 diff --git a/drivers/net/dpaa2/dpaa2_mux.c b/drivers/net/dpaa2/dpaa2_mux.c index 3289f388e1..7456f43f42 100644 --- a/drivers/net/dpaa2/dpaa2_mux.c +++ b/drivers/net/dpaa2/dpaa2_mux.c @@ -336,7 +336,7 @@ dpaa2_create_dpdmux_device(int vdev_fd __rte_unused, ret = dpdmux_if_set_errors_behavior(&dpdmux_dev->dpdmux, CMD_PRI_LOW, - dpdmux_dev->token, dpdmux_id, + dpdmux_dev->token, DPAA2_DPDMUX_DPMAC_IDX, &mux_err_cfg); if (ret) { DPAA2_PMD_ERR("dpdmux_if_set_errors_behavior %s err %d",