[v2] power: fix pstate number parsing
Checks
Commit Message
From: Markus Theil <markus.theil@secunet.com>
When converting atoi to strtol in a revision
of introducing sysfs support for turbo percentage,
a necessary check against '\n' returned by sysfs
was not introduced.
Fixes: de254dac608e ("power: read P-state turbo percentage from sysfs")
Reviewed-by: Reshma Pattan <reshma.pattan@intel.com>
Acked-by: Reshma Pattan <reshma.pattan@intel.com>
Signed-off-by: Markus Theil <markus.theil@secunet.com>
---
lib/power/power_pstate_cpufreq.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--
2.38.0
Comments
12/10/2022 14:36, Markus Theil:
> From: Markus Theil <markus.theil@secunet.com>
>
> When converting atoi to strtol in a revision
> of introducing sysfs support for turbo percentage,
> a necessary check against '\n' returned by sysfs
> was not introduced.
>
> Fixes: de254dac608e ("power: read P-state turbo percentage from sysfs")
> Reviewed-by: Reshma Pattan <reshma.pattan@intel.com>
> Acked-by: Reshma Pattan <reshma.pattan@intel.com>
> Signed-off-by: Markus Theil <markus.theil@secunet.com>
Applied, thanks.
@@ -96,7 +96,7 @@ power_read_turbo_pct(uint64_t *outVal)
errno = 0;
*outVal = (uint64_t) strtol(val, &endptr, 10);
- if (*endptr != 0 || errno != 0) {
+ if (errno != 0 || (*endptr != 0 && *endptr != '\n')) {
RTE_LOG(ERR, POWER, "Error converting str to digits, read from %s: %s\n",
POWER_SYSFILE_TURBO_PCT, strerror(errno));
ret = -1;