From patchwork Fri Oct 14 08:09:44 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Markus Theil X-Patchwork-Id: 118198 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 8A163A00C2; Fri, 14 Oct 2022 10:09:51 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 6FD84410F2; Fri, 14 Oct 2022 10:09:51 +0200 (CEST) Received: from smail.rz.tu-ilmenau.de (smail.rz.tu-ilmenau.de [141.24.186.67]) by mails.dpdk.org (Postfix) with ESMTP id 307B0410F1 for ; Fri, 14 Oct 2022 10:09:50 +0200 (CEST) Received: from isengard.fritz.box (p54aef542.dip0.t-ipconnect.de [84.174.245.66]) by smail.rz.tu-ilmenau.de (Postfix) with ESMTPA id C8A7C580095; Fri, 14 Oct 2022 10:09:49 +0200 (CEST) From: Markus Theil To: dev@dpdk.org Cc: Ferruh Yigit , Markus Theil Subject: [PATCH] doc: add deprecation notice for inconsistent socket_id types Date: Fri, 14 Oct 2022 10:09:44 +0200 Message-Id: <20221014080944.10992-1-markus.theil@tu-ilmenau.de> X-Mailer: git-send-email 2.38.0 MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org DPDK uses many different types for socket_id's in its whole code base. This leads to many warnings and casts in DPDK-based applications compiled with -Wconversion. Announce a treewide consolidation to the return type of rte_socket_id in DPDK 23.11. Signed-off-by: Markus Theil Acked-by: Jerin Jacob --- doc/guides/rel_notes/deprecation.rst | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/doc/guides/rel_notes/deprecation.rst b/doc/guides/rel_notes/deprecation.rst index 05cacb3ea8..7f4c468542 100644 --- a/doc/guides/rel_notes/deprecation.rst +++ b/doc/guides/rel_notes/deprecation.rst @@ -96,3 +96,10 @@ Deprecation Notices to have another parameter ``qp_id`` to return the queue pair ID which got error interrupt to the application, so that application can reset that particular queue pair. + +* eal/treewide: currently socket_id's use many different data types + throughout the codebase. This complicates compiling DPDK-based + applications with enabled -Wconversion. Fix this, by changing + all occurences to the return type of rte_socket_id(). + DPDK 23.11 should receive a batch cleanup to a single, consistent + data type.