From patchwork Tue Oct 18 13:53:33 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arkadiusz Kusztal X-Patchwork-Id: 118428 X-Patchwork-Delegate: gakhil@marvell.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id DF402A0560; Tue, 18 Oct 2022 17:07:17 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 15858410EE; Tue, 18 Oct 2022 17:07:13 +0200 (CEST) Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by mails.dpdk.org (Postfix) with ESMTP id 9AB3F4021D for ; Tue, 18 Oct 2022 17:07:10 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1666105630; x=1697641630; h=from:to:cc:subject:date:message-id:in-reply-to: references; bh=6TOvieTjonAMXREOenQP6PmacZKL3XhhguBbeMPiH1o=; b=S8KCC30y4dgf2H5D1VcEpVB1pbnVtXxNlbAziGkjb+gChlWS/RK604N6 sUDMXXZ48Fye1EGblVJgfhppTbdeehloyzP0hEcAB5vJqJ1Jx2mlFtN4a bKADUfUh6orcsLONOKVE0O7GTgToBnYoYtb1MFAMVpiEIZ6Kc0G1wmKCx IpmwhpQY357JHqxwOs7qfYEMNsMKmxQmYjBC2XYdN1iYCDymFaY79oMdk yrEQ2qkBOD0PN2GYhfzYcVaU58BfDp+w1mSJJz4f84howX4F0DD4BMmVA xtVYbpxK52AOAwnxGwiAwN4bXoRBSJ6s6d2mtrUWwP7P2Peo34lAM8XJS w==; X-IronPort-AV: E=McAfee;i="6500,9779,10504"; a="307792752" X-IronPort-AV: E=Sophos;i="5.95,193,1661842800"; d="scan'208";a="307792752" Received: from orsmga003.jf.intel.com ([10.7.209.27]) by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 18 Oct 2022 08:02:31 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10504"; a="579825410" X-IronPort-AV: E=Sophos;i="5.95,193,1661842800"; d="scan'208";a="579825410" Received: from silpixa00399302.ir.intel.com ([10.237.214.136]) by orsmga003.jf.intel.com with ESMTP; 18 Oct 2022 08:02:30 -0700 From: Arek Kusztal To: dev@dpdk.org Cc: gakhil@marvell.com, kai.ji@intel.com, Arek Kusztal Subject: [PATCH v2 2/3] crypto/qat: fix unnecessary session check Date: Tue, 18 Oct 2022 14:53:33 +0100 Message-Id: <20221018135334.34873-2-arkadiuszx.kusztal@intel.com> X-Mailer: git-send-email 2.13.6 In-Reply-To: <20221018135334.34873-1-arkadiuszx.kusztal@intel.com> References: <20221018135334.34873-1-arkadiuszx.kusztal@intel.com> X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Removed unncessary session check which could lead to segfault, in case api was changed. Fixes: 002486db239e ("crypto/qat: refactor asymmetric session") Signed-off-by: Arek Kusztal Acked-by: Ciara Power --- v2: - fixed compilation issues - split into 3 patches drivers/crypto/qat/qat_asym.c | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/crypto/qat/qat_asym.c b/drivers/crypto/qat/qat_asym.c index 3d7a800392..0eb5ba79bc 100644 --- a/drivers/crypto/qat/qat_asym.c +++ b/drivers/crypto/qat/qat_asym.c @@ -808,15 +808,15 @@ qat_asym_build_request(void *in_op, uint8_t *out_msg, void *op_cookie, int err = 0; op->status = RTE_CRYPTO_OP_STATUS_NOT_PROCESSED; - if (unlikely(qat_session == NULL)) { - QAT_DP_LOG(ERR, "Session was not created for this device"); - op->status = RTE_CRYPTO_OP_STATUS_INVALID_SESSION; - goto error; - } - switch (op->sess_type) { case RTE_CRYPTO_OP_WITH_SESSION: request_init(qat_req); + if (unlikely(qat_session == NULL)) { + QAT_DP_LOG(ERR, + "Session was not created for this device"); + op->status = RTE_CRYPTO_OP_STATUS_INVALID_SESSION; + goto error; + } xform = &qat_session->xform; break; case RTE_CRYPTO_OP_SESSIONLESS: