From patchwork Wed Oct 26 19:46:07 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: John Miller X-Patchwork-Id: 119174 X-Patchwork-Delegate: maxime.coquelin@redhat.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id C5ED1A04FD; Wed, 26 Oct 2022 21:47:13 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id CC48F42B9D; Wed, 26 Oct 2022 21:46:43 +0200 (CEST) Received: from mail-io1-f42.google.com (mail-io1-f42.google.com [209.85.166.42]) by mails.dpdk.org (Postfix) with ESMTP id 09D2942B79 for ; Wed, 26 Oct 2022 21:46:39 +0200 (CEST) Received: by mail-io1-f42.google.com with SMTP id 63so4853339iov.8 for ; Wed, 26 Oct 2022 12:46:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=atomicrules-com.20210112.gappssmtp.com; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=qx/Zort/csrO4lUnWuRlLW9FinO1I1YhZcG+4h7Axfs=; b=4pspfPtln9qYsrwCHBM1d6mSkjx1mBFWCiAJZ92FjtgQI4ZWRGhP8JhPwpwlFtA9ND jL0M2Q+7p3z9qIKVmNZHtEoiBFfxqA8kfdHZuIItvH66uwK6MHu+6eXGakIC0DEeWVpv LeBsRBYv6QdwChxBEe+cMAZwR3s3A7fG8Sj/dhuxMBjf9Is+b625y/9/+8X/JytXfJBq 2qbjVFMsI16GOip1t5/S56Cb0BEWeqfDojuUS5JNbLKUTMDb5wyqm7rjpvEuSH7k5zE/ vvz6XLF7aGQG9f9HYLoFVjgayriOksmKmRaSJAxTEznc/tyLY6/btGv6gtbN7RTR6U0O UnSg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=qx/Zort/csrO4lUnWuRlLW9FinO1I1YhZcG+4h7Axfs=; b=dy8FFrMRau6gHYpgeeA5hLKPXllNTfV5oSGtvWjo0zue+q68CBoD+5ux5iAFZwVMBx KroD8klxJt71gkhlys7fFh9Z/4id9f1kBb2PUXZzqIClCXz1J7ZEYdukNnjFc2diOMva J2vGRa7gqwq3X4d4lnu/6YgwzNEIZRNLppc+d4TX94tBPJd0VFztvmQRqUPs1FPAYYCk WWCcOnbPbaMhzQHjTK6wvzAleMclAM7LsmJlF1urOEmsVOqTUa4dvfbz7jNH4u9kdsHh WKg4R/7fzeV8ToHADl8qr3lZ6KhYnTRteev9rJGUApYtL0SfamxO5NnyXHSe7AKz968Y fT/g== X-Gm-Message-State: ACrzQf2gF+ZPf3tzhvmKKRNFBImL7TrPlSCP8tHl4CaGVymog5glk8sr lqZ79mIsInlz/GjENfcwXL0onQ== X-Google-Smtp-Source: AMsMyM7iqOoecgs4/n+cEkXNDdVGAbYbK1g57kvTbAiodDrREYKH6L0TNT6mNGI4x6GUA8vOgOu53A== X-Received: by 2002:a05:6638:2714:b0:363:af62:f457 with SMTP id m20-20020a056638271400b00363af62f457mr30016507jav.307.1666813598480; Wed, 26 Oct 2022 12:46:38 -0700 (PDT) Received: from john-System-Product-Name.tds (h64-35-205-155.cntcnh.broadband.dynamic.tds.net. [64.35.205.155]) by smtp.googlemail.com with ESMTPSA id m1-20020a056e020de100b002faecf63c48sm2336169ilj.79.2022.10.26.12.46.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 26 Oct 2022 12:46:38 -0700 (PDT) From: John Miller To: nicolas.chautru@intel.com Cc: dev@dpdk.org, ed.czeck@atomicrules.com, shepard.siegel@atomicrules.com, John Miller Subject: [PATCH 08/14] net/ark: add ark PMD log interface Date: Wed, 26 Oct 2022 15:46:07 -0400 Message-Id: <20221026194613.1008232-8-john.miller@atomicrules.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20221026194613.1008232-1-john.miller@atomicrules.com> References: <20221026194613.1008232-1-john.miller@atomicrules.com> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Added ark PMD log interface for use in arkville devices. Signed-off-by: John Miller --- drivers/net/ark/ark_ethdev.c | 86 ++++++++++++------------------- drivers/net/ark/ark_ethdev_logs.c | 8 +++ drivers/net/ark/ark_ethdev_logs.h | 25 +++++++++ drivers/net/ark/ark_ethdev_rx.c | 36 ++++++------- drivers/net/ark/ark_ethdev_tx.c | 10 ++-- drivers/net/ark/ark_logs.h | 34 ------------ 6 files changed, 89 insertions(+), 110 deletions(-) create mode 100644 drivers/net/ark/ark_ethdev_logs.c create mode 100644 drivers/net/ark/ark_ethdev_logs.h delete mode 100644 drivers/net/ark/ark_logs.h diff --git a/drivers/net/ark/ark_ethdev.c b/drivers/net/ark/ark_ethdev.c index c654a229f7..3c8a952a6c 100644 --- a/drivers/net/ark/ark_ethdev.c +++ b/drivers/net/ark/ark_ethdev.c @@ -11,7 +11,7 @@ #include #include "ark_global.h" -#include "ark_logs.h" +#include "ark_ethdev_logs.h" #include "ark_ethdev_tx.h" #include "ark_ethdev_rx.h" #include "ark_mpu.h" @@ -102,26 +102,6 @@ static const struct rte_pci_id pci_id_ark_map[] = { {.vendor_id = 0, /* sentinel */ }, }; -/* - * This structure is used to statically define the capabilities - * of supported devices. - * Capabilities: - * rqpacing - - * Some HW variants require that PCIe read-requests be correctly throttled. - * This is called "rqpacing" and has to do with credit and flow control - * on certain Arkville implementations. - */ -struct ark_caps { - bool rqpacing; - bool isvf; -}; -struct ark_dev_caps { - uint32_t device_id; - struct ark_caps caps; -}; -#define SET_DEV_CAPS(id, rqp, vf) \ - {id, {.rqpacing = rqp, .isvf = vf} } - static const struct ark_dev_caps ark_device_caps[] = { SET_DEV_CAPS(0x100d, true, false), @@ -211,26 +191,26 @@ check_for_ext(struct ark_adapter *ark) const char *dllpath = getenv("ARK_EXT_PATH"); if (dllpath == NULL) { - ARK_PMD_LOG(DEBUG, "EXT NO dll path specified\n"); + ARK_ETHDEV_LOG(DEBUG, "EXT NO dll path specified\n"); return 0; } - ARK_PMD_LOG(NOTICE, "EXT found dll path at %s\n", dllpath); + ARK_ETHDEV_LOG(NOTICE, "EXT found dll path at %s\n", dllpath); /* Open and load the .so */ ark->d_handle = dlopen(dllpath, RTLD_LOCAL | RTLD_LAZY); if (ark->d_handle == NULL) { - ARK_PMD_LOG(ERR, "Could not load user extension %s\n", + ARK_ETHDEV_LOG(ERR, "Could not load user extension %s\n", dllpath); return -1; } - ARK_PMD_LOG(DEBUG, "SUCCESS: loaded user extension %s\n", + ARK_ETHDEV_LOG(DEBUG, "SUCCESS: loaded user extension %s\n", dllpath); /* Get the entry points */ ark->user_ext.dev_init = (void *(*)(struct rte_eth_dev *, void *, int)) dlsym(ark->d_handle, "rte_pmd_ark_dev_init"); - ARK_PMD_LOG(DEBUG, "device ext init pointer = %p\n", + ARK_ETHDEV_LOG(DEBUG, "device ext init pointer = %p\n", ark->user_ext.dev_init); ark->user_ext.dev_get_port_count = (int (*)(struct rte_eth_dev *, void *)) @@ -303,7 +283,7 @@ eth_ark_dev_init(struct rte_eth_dev *dev) ark->eth_dev = dev; - ARK_PMD_LOG(DEBUG, "\n"); + ARK_ETHDEV_LOG(DEBUG, "\n"); /* Check to see if there is an extension that we need to load */ ret = check_for_ext(ark); @@ -351,15 +331,15 @@ eth_ark_dev_init(struct rte_eth_dev *dev) ark->started = 0; ark->pkt_dir_v = ARK_PKT_DIR_INIT_VAL; - ARK_PMD_LOG(INFO, "Sys Ctrl Const = 0x%x HW Commit_ID: %08x\n", + ARK_ETHDEV_LOG(INFO, "Sys Ctrl Const = 0x%x HW Commit_ID: %08x\n", ark->sysctrl.t32[4], rte_be_to_cpu_32(ark->sysctrl.t32[0x20 / 4])); - ARK_PMD_LOG(NOTICE, "Arkville HW Commit_ID: %08x\n", + ARK_ETHDEV_LOG(NOTICE, "Arkville HW Commit_ID: %08x\n", rte_be_to_cpu_32(ark->sysctrl.t32[0x20 / 4])); /* If HW sanity test fails, return an error */ if (ark->sysctrl.t32[4] != 0xcafef00d) { - ARK_PMD_LOG(ERR, + ARK_ETHDEV_LOG(ERR, "HW Sanity test has failed, expected constant" " 0x%x, read 0x%x (%s)\n", 0xcafef00d, @@ -369,16 +349,16 @@ eth_ark_dev_init(struct rte_eth_dev *dev) if (ark->sysctrl.t32[3] != 0) { if (ark->rqpacing) { if (ark_rqp_lasped(ark->rqpacing)) { - ARK_PMD_LOG(ERR, "Arkville Evaluation System - " + ARK_ETHDEV_LOG(ERR, "Arkville Evaluation System - " "Timer has Expired\n"); return -1; } - ARK_PMD_LOG(WARNING, "Arkville Evaluation System - " + ARK_ETHDEV_LOG(WARNING, "Arkville Evaluation System - " "Timer is Running\n"); } } - ARK_PMD_LOG(DEBUG, + ARK_ETHDEV_LOG(DEBUG, "HW Sanity test has PASSED, expected constant" " 0x%x, read 0x%x (%s)\n", 0xcafef00d, ark->sysctrl.t32[4], __func__); @@ -393,7 +373,7 @@ eth_ark_dev_init(struct rte_eth_dev *dev) dev->data->mac_addrs = rte_zmalloc("ark", RTE_ETHER_ADDR_LEN, 0); if (!dev->data->mac_addrs) { - ARK_PMD_LOG(ERR, + ARK_ETHDEV_LOG(ERR, "Failed to allocated memory for storing mac address" ); } @@ -402,7 +382,7 @@ eth_ark_dev_init(struct rte_eth_dev *dev) ark->user_data[dev->data->port_id] = ark->user_ext.dev_init(dev, ark->a_bar, 0); if (!ark->user_data[dev->data->port_id]) { - ARK_PMD_LOG(WARNING, + ARK_ETHDEV_LOG(WARNING, "Failed to initialize PMD extension!" " continuing without it\n"); memset(&ark->user_ext, 0, sizeof(struct ark_user_ext)); @@ -413,7 +393,7 @@ eth_ark_dev_init(struct rte_eth_dev *dev) if (pci_dev->device.devargs) ret = eth_ark_check_args(ark, pci_dev->device.devargs->args); else - ARK_PMD_LOG(INFO, "No Device args found\n"); + ARK_ETHDEV_LOG(INFO, "No Device args found\n"); if (ret) goto error; @@ -444,7 +424,7 @@ eth_ark_dev_init(struct rte_eth_dev *dev) /* reserve an ethdev entry */ eth_dev = rte_eth_dev_allocate(name); if (!eth_dev) { - ARK_PMD_LOG(ERR, + ARK_ETHDEV_LOG(ERR, "Could not allocate eth_dev for port %d\n", p); goto error; @@ -462,7 +442,7 @@ eth_ark_dev_init(struct rte_eth_dev *dev) eth_dev->data->mac_addrs = rte_zmalloc(name, RTE_ETHER_ADDR_LEN, 0); if (!eth_dev->data->mac_addrs) { - ARK_PMD_LOG(ERR, + ARK_ETHDEV_LOG(ERR, "Memory allocation for MAC failed!" " Exiting.\n"); goto error; @@ -608,7 +588,7 @@ eth_ark_dev_start(struct rte_eth_dev *dev) if (rte_ctrl_thread_create(&thread, tname, NULL, ark_pktgen_delay_start, ark->pg)) { - ARK_PMD_LOG(ERR, "Could not create pktgen " + ARK_ETHDEV_LOG(ERR, "Could not create pktgen " "starter thread\n"); return -1; } @@ -657,7 +637,7 @@ eth_ark_dev_stop(struct rte_eth_dev *dev) status = eth_ark_tx_queue_stop(dev, i); if (status != 0) { uint16_t port = dev->data->port_id; - ARK_PMD_LOG(ERR, + ARK_ETHDEV_LOG(ERR, "tx_queue stop anomaly" " port %u, queue %u\n", port, i); @@ -757,7 +737,7 @@ eth_ark_dev_info_get(struct rte_eth_dev *dev, static int eth_ark_dev_link_update(struct rte_eth_dev *dev, int wait_to_complete) { - ARK_PMD_LOG(DEBUG, "link status = %d\n", + ARK_ETHDEV_LOG(DEBUG, "link status = %d\n", dev->data->dev_link.link_status); struct ark_adapter *ark = dev->data->dev_private; @@ -892,20 +872,20 @@ static inline int process_pktdir_arg(const char *key, const char *value, void *extra_args) { - ARK_PMD_LOG(DEBUG, "key = %s, value = %s\n", + ARK_ETHDEV_LOG(DEBUG, "key = %s, value = %s\n", key, value); struct ark_adapter *ark = (struct ark_adapter *)extra_args; ark->pkt_dir_v = strtol(value, NULL, 16); - ARK_PMD_LOG(DEBUG, "pkt_dir_v = 0x%x\n", ark->pkt_dir_v); + ARK_ETHDEV_LOG(DEBUG, "pkt_dir_v = 0x%x\n", ark->pkt_dir_v); return 0; } static inline int process_file_args(const char *key, const char *value, void *extra_args) { - ARK_PMD_LOG(DEBUG, "key = %s, value = %s\n", + ARK_ETHDEV_LOG(DEBUG, "key = %s, value = %s\n", key, value); char *args = (char *)extra_args; @@ -916,7 +896,7 @@ process_file_args(const char *key, const char *value, void *extra_args) int first = 1; if (file == NULL) { - ARK_PMD_LOG(ERR, "Unable to open " + ARK_ETHDEV_LOG(ERR, "Unable to open " "config file %s\n", value); return -1; } @@ -924,7 +904,7 @@ process_file_args(const char *key, const char *value, void *extra_args) while (fgets(line, sizeof(line), file)) { size += strlen(line); if (size >= ARK_MAX_ARG_LEN) { - ARK_PMD_LOG(ERR, "Unable to parse file %s args, " + ARK_ETHDEV_LOG(ERR, "Unable to parse file %s args, " "parameter list is too long\n", value); fclose(file); return -1; @@ -936,7 +916,7 @@ process_file_args(const char *key, const char *value, void *extra_args) strncat(args, line, ARK_MAX_ARG_LEN); } } - ARK_PMD_LOG(DEBUG, "file = %s\n", args); + ARK_ETHDEV_LOG(DEBUG, "file = %s\n", args); fclose(file); return 0; } @@ -958,7 +938,7 @@ eth_ark_check_args(struct ark_adapter *ark, const char *params) for (k_idx = 0; k_idx < kvlist->count; k_idx++) { pair = &kvlist->pairs[k_idx]; - ARK_PMD_LOG(DEBUG, "**** Arg passed to PMD = %s:%s\n", + ARK_ETHDEV_LOG(DEBUG, "**** Arg passed to PMD = %s:%s\n", pair->key, pair->value); } @@ -967,7 +947,7 @@ eth_ark_check_args(struct ark_adapter *ark, const char *params) ARK_PKTDIR_ARG, &process_pktdir_arg, ark) != 0) { - ARK_PMD_LOG(ERR, "Unable to parse arg %s\n", ARK_PKTDIR_ARG); + ARK_ETHDEV_LOG(ERR, "Unable to parse arg %s\n", ARK_PKTDIR_ARG); goto free_kvlist; } @@ -975,7 +955,7 @@ eth_ark_check_args(struct ark_adapter *ark, const char *params) ARK_PKTGEN_ARG, &process_file_args, ark->pkt_gen_args) != 0) { - ARK_PMD_LOG(ERR, "Unable to parse arg %s\n", ARK_PKTGEN_ARG); + ARK_ETHDEV_LOG(ERR, "Unable to parse arg %s\n", ARK_PKTGEN_ARG); goto free_kvlist; } @@ -983,7 +963,7 @@ eth_ark_check_args(struct ark_adapter *ark, const char *params) ARK_PKTCHKR_ARG, &process_file_args, ark->pkt_chkr_args) != 0) { - ARK_PMD_LOG(ERR, "Unable to parse arg %s\n", ARK_PKTCHKR_ARG); + ARK_ETHDEV_LOG(ERR, "Unable to parse arg %s\n", ARK_PKTCHKR_ARG); goto free_kvlist; } @@ -991,13 +971,13 @@ eth_ark_check_args(struct ark_adapter *ark, const char *params) ret = 0; goto free_kvlist; } - ARK_PMD_LOG(INFO, "packet director set to 0x%x\n", ark->pkt_dir_v); + ARK_ETHDEV_LOG(INFO, "packet director set to 0x%x\n", ark->pkt_dir_v); /* Setup the packet director */ ark_pktdir_setup(ark->pd, ark->pkt_dir_v); /* Setup the packet generator */ if (ark->pkt_gen_args[0]) { - ARK_PMD_LOG(DEBUG, "Setting up the packet generator\n"); + ARK_ETHDEV_LOG(DEBUG, "Setting up the packet generator\n"); ark_pktgen_parse(ark->pkt_gen_args); ark_pktgen_reset(ark->pg); ark_pktgen_setup(ark->pg); diff --git a/drivers/net/ark/ark_ethdev_logs.c b/drivers/net/ark/ark_ethdev_logs.c new file mode 100644 index 0000000000..a8c2fe8404 --- /dev/null +++ b/drivers/net/ark/ark_ethdev_logs.c @@ -0,0 +1,8 @@ +/* SPDX-License-Identifier: BSD-3-Clause + * Copyright (c) 2020-2021 Atomic Rules LLC + */ + +#include "ark_ethdev_logs.h" + + +int ark_ethdev_logtype; diff --git a/drivers/net/ark/ark_ethdev_logs.h b/drivers/net/ark/ark_ethdev_logs.h new file mode 100644 index 0000000000..6db80655d7 --- /dev/null +++ b/drivers/net/ark/ark_ethdev_logs.h @@ -0,0 +1,25 @@ +/* SPDX-License-Identifier: BSD-3-Clause + * Copyright (c) 2015-2018 Atomic Rules LLC + */ + +#ifndef _ARK_ETHDEV_LOG_H_ +#define _ARK_ETHDEV_LOG_H_ + +#include +#include +#include "ark_common.h" + +extern int ark_ethdev_logtype; + +#define ARK_ETHDEV_LOG(level, fmt, args...) \ + rte_log(RTE_LOG_ ##level, ark_ethdev_logtype, "ARK: " fmt, ## args) + + +/* Debug macro to enable core debug code */ +#ifdef RTE_LIBRTE_ETHDEV_DEBUG +#define ARK_DEBUG_CORE 1 +#else +#define ARK_DEBUG_CORE 0 +#endif + +#endif diff --git a/drivers/net/ark/ark_ethdev_rx.c b/drivers/net/ark/ark_ethdev_rx.c index cbc0416bc2..36ea92363a 100644 --- a/drivers/net/ark/ark_ethdev_rx.c +++ b/drivers/net/ark/ark_ethdev_rx.c @@ -6,7 +6,7 @@ #include "ark_ethdev_rx.h" #include "ark_global.h" -#include "ark_logs.h" +#include "ark_ethdev_logs.h" #include "ark_mpu.h" #include "ark_udm.h" @@ -82,7 +82,7 @@ eth_ark_rx_hw_setup(struct rte_eth_dev *dev, /* Verify HW */ if (ark_mpu_verify(queue->mpu, sizeof(rte_iova_t))) { - ARK_PMD_LOG(ERR, "Illegal configuration rx queue\n"); + ARK_ETHDEV_LOG(ERR, "Illegal configuration rx queue\n"); return -1; } @@ -134,19 +134,19 @@ eth_ark_dev_rx_queue_setup(struct rte_eth_dev *dev, if (rx_conf != NULL && warning1 == 0) { warning1 = 1; - ARK_PMD_LOG(NOTICE, + ARK_ETHDEV_LOG(NOTICE, "Arkville ignores rte_eth_rxconf argument.\n"); } if (RTE_PKTMBUF_HEADROOM < ARK_RX_META_SIZE) { - ARK_PMD_LOG(ERR, + ARK_ETHDEV_LOG(ERR, "Error: DPDK Arkville requires head room > %d bytes (%s)\n", ARK_RX_META_SIZE, __func__); return -1; /* ERROR CODE */ } if (!rte_is_power_of_2(nb_desc)) { - ARK_PMD_LOG(ERR, + ARK_ETHDEV_LOG(ERR, "DPDK Arkville configuration queue size must be power of two %u (%s)\n", nb_desc, __func__); return -1; /* ERROR CODE */ @@ -158,7 +158,7 @@ eth_ark_dev_rx_queue_setup(struct rte_eth_dev *dev, 64, socket_id); if (queue == 0) { - ARK_PMD_LOG(ERR, "Failed to allocate memory in %s\n", __func__); + ARK_ETHDEV_LOG(ERR, "Failed to allocate memory in %s\n", __func__); return -ENOMEM; } @@ -186,7 +186,7 @@ eth_ark_dev_rx_queue_setup(struct rte_eth_dev *dev, socket_id); if (queue->reserve_q == 0 || queue->paddress_q == 0) { - ARK_PMD_LOG(ERR, + ARK_ETHDEV_LOG(ERR, "Failed to allocate queue memory in %s\n", __func__); rte_free(queue->reserve_q); @@ -209,7 +209,7 @@ eth_ark_dev_rx_queue_setup(struct rte_eth_dev *dev, status = eth_ark_rx_seed_mbufs(queue); if (queue->seed_index != nb_desc) { - ARK_PMD_LOG(ERR, "Failed to allocate %u mbufs for RX queue %d\n", + ARK_ETHDEV_LOG(ERR, "Failed to allocate %u mbufs for RX queue %d\n", nb_desc, qidx); status = -1; } @@ -220,7 +220,7 @@ eth_ark_dev_rx_queue_setup(struct rte_eth_dev *dev, if (unlikely(status != 0)) { struct rte_mbuf **mbuf; - ARK_PMD_LOG(ERR, "Failed to initialize RX queue %d %s\n", + ARK_ETHDEV_LOG(ERR, "Failed to initialize RX queue %d %s\n", qidx, __func__); /* Free the mbufs allocated */ @@ -279,7 +279,7 @@ eth_ark_recv_pkts(void *rx_queue, if ((meta->pkt_len > (1024 * 16)) || (meta->pkt_len == 0)) { - ARK_PMD_LOG(DEBUG, "RX: Bad Meta Q: %u" + ARK_ETHDEV_LOG(DEBUG, "RX: Bad Meta Q: %u" " cons: %" PRIU32 " prod: %" PRIU32 " seed_index %" PRIU32 @@ -290,7 +290,7 @@ eth_ark_recv_pkts(void *rx_queue, queue->seed_index); - ARK_PMD_LOG(DEBUG, " : UDM" + ARK_ETHDEV_LOG(DEBUG, " : UDM" " prod: %" PRIU32 " len: %u\n", queue->udm->rt_cfg.prod_idx, @@ -458,7 +458,7 @@ eth_ark_rx_seed_mbufs(struct ark_rx_queue *queue) int status = rte_pktmbuf_alloc_bulk(queue->mb_pool, mbufs, nb); if (unlikely(status != 0)) { - ARK_PMD_LOG(NOTICE, + ARK_ETHDEV_LOG(NOTICE, "Could not allocate %u mbufs from pool" " for RX queue %u;" " %u free buffers remaining in queue\n", @@ -591,8 +591,8 @@ ark_ethdev_rx_dump(const char *name, struct ark_rx_queue *queue) { if (queue == NULL) return; - ARK_PMD_LOG(DEBUG, "RX QUEUE %d -- %s", queue->phys_qid, name); - ARK_PMD_LOG(DEBUG, ARK_SU32 ARK_SU32 ARK_SU32 ARK_SU32 "\n", + ARK_ETHDEV_LOG(DEBUG, "RX QUEUE %d -- %s", queue->phys_qid, name); + ARK_ETHDEV_LOG(DEBUG, ARK_SU32 ARK_SU32 ARK_SU32 ARK_SU32 "\n", "queue_size", queue->queue_size, "seed_index", queue->seed_index, "prod_index", queue->prod_index, @@ -615,15 +615,15 @@ dump_mbuf_data(struct rte_mbuf *mbuf, uint16_t lo, uint16_t hi) { uint16_t i, j; - ARK_PMD_LOG(DEBUG, " MBUF: %p len %d, off: %d\n", + ARK_ETHDEV_LOG(DEBUG, " MBUF: %p len %d, off: %d\n", mbuf, mbuf->pkt_len, mbuf->data_off); for (i = lo; i < hi; i += 16) { uint8_t *dp = RTE_PTR_ADD(mbuf->buf_addr, i); - ARK_PMD_LOG(DEBUG, " %6d: ", i); + ARK_ETHDEV_LOG(DEBUG, " %6d: ", i); for (j = 0; j < 16; j++) - ARK_PMD_LOG(DEBUG, " %02x", dp[j]); + ARK_ETHDEV_LOG(DEBUG, " %02x", dp[j]); - ARK_PMD_LOG(DEBUG, "\n"); + ARK_ETHDEV_LOG(DEBUG, "\n"); } } diff --git a/drivers/net/ark/ark_ethdev_tx.c b/drivers/net/ark/ark_ethdev_tx.c index 5940a592a2..898e5a8a6f 100644 --- a/drivers/net/ark/ark_ethdev_tx.c +++ b/drivers/net/ark/ark_ethdev_tx.c @@ -8,7 +8,7 @@ #include "ark_global.h" #include "ark_mpu.h" #include "ark_ddm.h" -#include "ark_logs.h" +#include "ark_ethdev_logs.h" #define ARK_TX_META_SIZE 32 #define ARK_TX_META_OFFSET (RTE_PKTMBUF_HEADROOM - ARK_TX_META_SIZE) @@ -166,7 +166,7 @@ eth_ark_xmit_pkts(void *vtxq, struct rte_mbuf **tx_pkts, uint16_t nb_pkts) } if (ARK_DEBUG_CORE && nb != nb_pkts) { - ARK_PMD_LOG(DEBUG, "TX: Failure to send:" + ARK_ETHDEV_LOG(DEBUG, "TX: Failure to send:" " req: %" PRIU32 " sent: %" PRIU32 " prod: %" PRIU32 @@ -232,7 +232,7 @@ eth_ark_tx_queue_setup(struct rte_eth_dev *dev, int qidx = queue_idx; if (!rte_is_power_of_2(nb_desc)) { - ARK_PMD_LOG(ERR, + ARK_ETHDEV_LOG(ERR, "DPDK Arkville configuration queue size" " must be power of two %u (%s)\n", nb_desc, __func__); @@ -248,7 +248,7 @@ eth_ark_tx_queue_setup(struct rte_eth_dev *dev, 64, socket_id); if (queue == 0) { - ARK_PMD_LOG(ERR, "Failed to allocate tx " + ARK_ETHDEV_LOG(ERR, "Failed to allocate tx " "queue memory in %s\n", __func__); return -ENOMEM; @@ -275,7 +275,7 @@ eth_ark_tx_queue_setup(struct rte_eth_dev *dev, socket_id); if (queue->meta_q == 0 || queue->bufs == 0) { - ARK_PMD_LOG(ERR, "Failed to allocate " + ARK_ETHDEV_LOG(ERR, "Failed to allocate " "queue memory in %s\n", __func__); rte_free(queue->meta_q); rte_free(queue->bufs); diff --git a/drivers/net/ark/ark_logs.h b/drivers/net/ark/ark_logs.h deleted file mode 100644 index ca46d86c99..0000000000 --- a/drivers/net/ark/ark_logs.h +++ /dev/null @@ -1,34 +0,0 @@ -/* SPDX-License-Identifier: BSD-3-Clause - * Copyright (c) 2015-2018 Atomic Rules LLC - */ - -#ifndef _ARK_DEBUG_H_ -#define _ARK_DEBUG_H_ - -#include -#include - -/* system camel case definition changed to upper case */ -#define PRIU32 PRIu32 -#define PRIU64 PRIu64 - -/* Format specifiers for string data pairs */ -#define ARK_SU32 "\n\t%-20s %'20" PRIU32 -#define ARK_SU64 "\n\t%-20s %'20" PRIU64 -#define ARK_SU64X "\n\t%-20s %#20" PRIx64 -#define ARK_SPTR "\n\t%-20s %20p" - -extern int ark_logtype; - -#define ARK_PMD_LOG(level, fmt, args...) \ - rte_log(RTE_LOG_ ##level, ark_logtype, "ARK: " fmt, ## args) - - -/* Debug macro to enable core debug code */ -#ifdef RTE_LIBRTE_ETHDEV_DEBUG -#define ARK_DEBUG_CORE 1 -#else -#define ARK_DEBUG_CORE 0 -#endif - -#endif