diff mbox series

maintainers: update for gve

Message ID 20221109072352.1387300-1-junfeng.guo@intel.com (mailing list archive)
State Superseded, archived
Delegated to: Thomas Monjalon
Headers
Series maintainers: update for gve |

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/iol-mellanox-Performance success Performance Testing PASS
ci/iol-aarch64-unit-testing success Testing PASS
ci/Intel-compilation success Compilation OK
ci/github-robot: build success github build: passed
ci/intel-Testing success Testing PASS
ci/iol-x86_64-compile-testing success Testing PASS
ci/iol-x86_64-unit-testing success Testing PASS
ci/iol-aarch64-compile-testing success Testing PASS
ci/iol-intel-Functional success Functional Testing PASS
ci/iol-intel-Performance success Performance Testing PASS

Commit Message

Junfeng Guo Nov. 9, 2022, 7:23 a.m. UTC 
  Add co-maintainers from Google team for gve (Google Virtual Ethernet).

Signed-off-by: Junfeng Guo <junfeng.guo@intel.com>
---
 MAINTAINERS | 3 +++
 1 file changed, 3 insertions(+)

Comments

Rushil Gupta Nov. 9, 2022, 7:37 p.m. UTC | #1 
Thanks a lot Junfeng!

On Tue, Nov 8, 2022 at 11:26 PM Junfeng Guo <junfeng.guo@intel.com> wrote:

> Add co-maintainers from Google team for gve (Google Virtual Ethernet).
>
> Signed-off-by: Junfeng Guo <junfeng.guo@intel.com>
> ---
>  MAINTAINERS | 3 +++
>  1 file changed, 3 insertions(+)
>
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 1c9922123e..d8c1d5272b 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -698,6 +698,9 @@ F: doc/guides/nics/features/enic.ini
>
>  Google Virtual Ethernet
>  M: Junfeng Guo <junfeng.guo@intel.com>
> +M: Jeroen de Borst <jeroendb@google.com>
> +M: Rushil Gupta <rushilg@google.com>
> +M: Jordan Kimbrough <jrkim@google.com>
>  F: drivers/net/gve/
>  F: doc/guides/nics/gve.rst
>  F: doc/guides/nics/features/gve.ini
> --
> 2.34.1
>
>
Thomas Monjalon Nov. 15, 2022, 8:33 a.m. UTC | #2 
09/11/2022 20:37, Rushil Gupta:
> Thanks a lot Junfeng!
> 
> On Tue, Nov 8, 2022 at 11:26 PM Junfeng Guo <junfeng.guo@intel.com> wrote:
> 
> > Add co-maintainers from Google team for gve (Google Virtual Ethernet).
> >
> > Signed-off-by: Junfeng Guo <junfeng.guo@intel.com>
> > ---
> >  Google Virtual Ethernet
> >  M: Junfeng Guo <junfeng.guo@intel.com>
> > +M: Jeroen de Borst <jeroendb@google.com>
> > +M: Rushil Gupta <rushilg@google.com>
> > +M: Jordan Kimbrough <jrkim@google.com>

They were not part of the patch review process in the mailing list,
why do you want them to become maintainers?
I think it would be saner to have them involved first.
Junfeng Guo Nov. 15, 2022, 9:22 a.m. UTC | #3 
> -----Original Message-----
> From: Thomas Monjalon <thomas@monjalon.net>
> Sent: Tuesday, November 15, 2022 16:33
> To: Guo, Junfeng <junfeng.guo@intel.com>
> Cc: dev@dpdk.org; Zhang, Qi Z <qi.z.zhang@intel.com>; Wu, Jingjing
> <jingjing.wu@intel.com>; ferruh.yigit@xilinx.com; Xing, Beilei
> <beilei.xing@intel.com>; dev@dpdk.org; jeroendb@google.com;
> jrkim@google.com; Zhang, Helin <helin.zhang@intel.com>; Rushil Gupta
> <rushilg@google.com>; Jeroen de Borst <jeroendb@google.com>;
> Jordan Kimbrough <jrkim@google.com>
> Subject: Re: [PATCH] maintainers: update for gve
> 
> 09/11/2022 20:37, Rushil Gupta:
> > Thanks a lot Junfeng!
> >
> > On Tue, Nov 8, 2022 at 11:26 PM Junfeng Guo <junfeng.guo@intel.com>
> wrote:
> >
> > > Add co-maintainers from Google team for gve (Google Virtual
> Ethernet).
> > >
> > > Signed-off-by: Junfeng Guo <junfeng.guo@intel.com>
> > > ---
> > >  Google Virtual Ethernet
> > >  M: Junfeng Guo <junfeng.guo@intel.com>
> > > +M: Jeroen de Borst <jeroendb@google.com>
> > > +M: Rushil Gupta <rushilg@google.com>
> > > +M: Jordan Kimbrough <jrkim@google.com>
> 
> They were not part of the patch review process in the mailing list,
> why do you want them to become maintainers?
> I think it would be saner to have them involved first.

Yes, make sense! Thanks for reminding this!

Hi @Rushil Gupta @Jeroen de Borst @Jordan Kimbrough,
could you help register for dev@dpdk.org 
at https://www.dpdk.org/contribute/#Mailing-Lists as well as for
the patchwork at http://patchwork.dpdk.org/project/dpdk/list/ first? 
Then you can add more info & explanation for your maintaining plan here.
Thanks!

>
Rushil Gupta Nov. 15, 2022, 8:04 p.m. UTC | #4 
Done. Thanks Junfeng!



On Tue, Nov 15, 2022 at 1:22 AM Guo, Junfeng <junfeng.guo@intel.com> wrote:
>
>
>
> > -----Original Message-----
> > From: Thomas Monjalon <thomas@monjalon.net>
> > Sent: Tuesday, November 15, 2022 16:33
> > To: Guo, Junfeng <junfeng.guo@intel.com>
> > Cc: dev@dpdk.org; Zhang, Qi Z <qi.z.zhang@intel.com>; Wu, Jingjing
> > <jingjing.wu@intel.com>; ferruh.yigit@xilinx.com; Xing, Beilei
> > <beilei.xing@intel.com>; dev@dpdk.org; jeroendb@google.com;
> > jrkim@google.com; Zhang, Helin <helin.zhang@intel.com>; Rushil Gupta
> > <rushilg@google.com>; Jeroen de Borst <jeroendb@google.com>;
> > Jordan Kimbrough <jrkim@google.com>
> > Subject: Re: [PATCH] maintainers: update for gve
> >
> > 09/11/2022 20:37, Rushil Gupta:
> > > Thanks a lot Junfeng!
> > >
> > > On Tue, Nov 8, 2022 at 11:26 PM Junfeng Guo <junfeng.guo@intel.com>
> > wrote:
> > >
> > > > Add co-maintainers from Google team for gve (Google Virtual
> > Ethernet).
> > > >
> > > > Signed-off-by: Junfeng Guo <junfeng.guo@intel.com>
> > > > ---
> > > >  Google Virtual Ethernet
> > > >  M: Junfeng Guo <junfeng.guo@intel.com>
> > > > +M: Jeroen de Borst <jeroendb@google.com>
> > > > +M: Rushil Gupta <rushilg@google.com>
> > > > +M: Jordan Kimbrough <jrkim@google.com>
> >
> > They were not part of the patch review process in the mailing list,
> > why do you want them to become maintainers?
> > I think it would be saner to have them involved first.
>
> Yes, make sense! Thanks for reminding this!
>
> Hi @Rushil Gupta @Jeroen de Borst @Jordan Kimbrough,
> could you help register for dev@dpdk.org
> at https://www.dpdk.org/contribute/#Mailing-Lists as well as for
> the patchwork at http://patchwork.dpdk.org/project/dpdk/list/ first?
> Then you can add more info & explanation for your maintaining plan here.
> Thanks!
>
> >
>
>
Jordan Kimbrough Nov. 15, 2022, 8:54 p.m. UTC | #5 
I've also registered

On Tue, Nov 15, 2022 at 12:04 PM Rushil Gupta <rushilg@google.com> wrote:

> Done. Thanks Junfeng!
>
>
>
> On Tue, Nov 15, 2022 at 1:22 AM Guo, Junfeng <junfeng.guo@intel.com>
> wrote:
> >
> >
> >
> > > -----Original Message-----
> > > From: Thomas Monjalon <thomas@monjalon.net>
> > > Sent: Tuesday, November 15, 2022 16:33
> > > To: Guo, Junfeng <junfeng.guo@intel.com>
> > > Cc: dev@dpdk.org; Zhang, Qi Z <qi.z.zhang@intel.com>; Wu, Jingjing
> > > <jingjing.wu@intel.com>; ferruh.yigit@xilinx.com; Xing, Beilei
> > > <beilei.xing@intel.com>; dev@dpdk.org; jeroendb@google.com;
> > > jrkim@google.com; Zhang, Helin <helin.zhang@intel.com>; Rushil Gupta
> > > <rushilg@google.com>; Jeroen de Borst <jeroendb@google.com>;
> > > Jordan Kimbrough <jrkim@google.com>
> > > Subject: Re: [PATCH] maintainers: update for gve
> > >
> > > 09/11/2022 20:37, Rushil Gupta:
> > > > Thanks a lot Junfeng!
> > > >
> > > > On Tue, Nov 8, 2022 at 11:26 PM Junfeng Guo <junfeng.guo@intel.com>
> > > wrote:
> > > >
> > > > > Add co-maintainers from Google team for gve (Google Virtual
> > > Ethernet).
> > > > >
> > > > > Signed-off-by: Junfeng Guo <junfeng.guo@intel.com>
> > > > > ---
> > > > >  Google Virtual Ethernet
> > > > >  M: Junfeng Guo <junfeng.guo@intel.com>
> > > > > +M: Jeroen de Borst <jeroendb@google.com>
> > > > > +M: Rushil Gupta <rushilg@google.com>
> > > > > +M: Jordan Kimbrough <jrkim@google.com>
> > >
> > > They were not part of the patch review process in the mailing list,
> > > why do you want them to become maintainers?
> > > I think it would be saner to have them involved first.
> >
> > Yes, make sense! Thanks for reminding this!
> >
> > Hi @Rushil Gupta @Jeroen de Borst @Jordan Kimbrough,
> > could you help register for dev@dpdk.org
> > at https://www.dpdk.org/contribute/#Mailing-Lists as well as for
> > the patchwork at http://patchwork.dpdk.org/project/dpdk/list/ first?
> > Then you can add more info & explanation for your maintaining plan here.
> > Thanks!
> >
> > >
> >
> >
>
Jeroen de Borst Nov. 15, 2022, 11:43 p.m. UTC | #6 
This driver is for Google's virtual NIC and the team here at Google is
working on DPDK support. We were unaware of this driver until just a few
weeks ago.

There are many features missing from the driver currently released and our
team intends to make sure this driver support all relevant features of our
device (both current and upcoming). Since our team works closely with the
team that develops the virtual device, we can proactively add (and test)
features before they're made publicly available.

Some of these features are:

   - Jumbo-frame support
   - A new queue format (that supports out-of-order completions)
   - RSS support
   - Flow-steering
   - Header-split

We're grateful to the original contributor of this driver and will
closely collaborate with them going forward.

Regards,
Jeroen de Borst
Tech Lead for guest drivers with Google Cloud

On Tue, Nov 15, 2022 at 12:54 PM Jordan Kimbrough <jrkim@google.com> wrote:

> I've also registered
>
> On Tue, Nov 15, 2022 at 12:04 PM Rushil Gupta <rushilg@google.com> wrote:
>
>> Done. Thanks Junfeng!
>>
>>
>>
>> On Tue, Nov 15, 2022 at 1:22 AM Guo, Junfeng <junfeng.guo@intel.com>
>> wrote:
>> >
>> >
>> >
>> > > -----Original Message-----
>> > > From: Thomas Monjalon <thomas@monjalon.net>
>> > > Sent: Tuesday, November 15, 2022 16:33
>> > > To: Guo, Junfeng <junfeng.guo@intel.com>
>> > > Cc: dev@dpdk.org; Zhang, Qi Z <qi.z.zhang@intel.com>; Wu, Jingjing
>> > > <jingjing.wu@intel.com>; ferruh.yigit@xilinx.com; Xing, Beilei
>> > > <beilei.xing@intel.com>; dev@dpdk.org; jeroendb@google.com;
>> > > jrkim@google.com; Zhang, Helin <helin.zhang@intel.com>; Rushil Gupta
>> > > <rushilg@google.com>; Jeroen de Borst <jeroendb@google.com>;
>> > > Jordan Kimbrough <jrkim@google.com>
>> > > Subject: Re: [PATCH] maintainers: update for gve
>> > >
>> > > 09/11/2022 20:37, Rushil Gupta:
>> > > > Thanks a lot Junfeng!
>> > > >
>> > > > On Tue, Nov 8, 2022 at 11:26 PM Junfeng Guo <junfeng.guo@intel.com>
>> > > wrote:
>> > > >
>> > > > > Add co-maintainers from Google team for gve (Google Virtual
>> > > Ethernet).
>> > > > >
>> > > > > Signed-off-by: Junfeng Guo <junfeng.guo@intel.com>
>> > > > > ---
>> > > > >  Google Virtual Ethernet
>> > > > >  M: Junfeng Guo <junfeng.guo@intel.com>
>> > > > > +M: Jeroen de Borst <jeroendb@google.com>
>> > > > > +M: Rushil Gupta <rushilg@google.com>
>> > > > > +M: Jordan Kimbrough <jrkim@google.com>
>> > >
>> > > They were not part of the patch review process in the mailing list,
>> > > why do you want them to become maintainers?
>> > > I think it would be saner to have them involved first.
>> >
>> > Yes, make sense! Thanks for reminding this!
>> >
>> > Hi @Rushil Gupta @Jeroen de Borst @Jordan Kimbrough,
>> > could you help register for dev@dpdk.org
>> > at https://www.dpdk.org/contribute/#Mailing-Lists as well as for
>> > the patchwork at http://patchwork.dpdk.org/project/dpdk/list/ first?
>> > Then you can add more info & explanation for your maintaining plan here.
>> > Thanks!
>> >
>> > >
>> >
>> >
>>
>
diff mbox series

Patch

diff --git a/MAINTAINERS b/MAINTAINERS
index 1c9922123e..d8c1d5272b 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -698,6 +698,9 @@  F: doc/guides/nics/features/enic.ini
 
 Google Virtual Ethernet
 M: Junfeng Guo <junfeng.guo@intel.com>
+M: Jeroen de Borst <jeroendb@google.com>
+M: Rushil Gupta <rushilg@google.com>
+M: Jordan Kimbrough <jrkim@google.com>
 F: drivers/net/gve/
 F: doc/guides/nics/gve.rst
 F: doc/guides/nics/features/gve.ini