From patchwork Wed Nov 9 19:53:23 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephen Hemminger X-Patchwork-Id: 119657 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id E0F51A034C; Wed, 9 Nov 2022 20:54:10 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 814A142D2F; Wed, 9 Nov 2022 20:53:46 +0100 (CET) Received: from mail-pj1-f43.google.com (mail-pj1-f43.google.com [209.85.216.43]) by mails.dpdk.org (Postfix) with ESMTP id 5D248410DE for ; Wed, 9 Nov 2022 20:53:45 +0100 (CET) Received: by mail-pj1-f43.google.com with SMTP id f5-20020a17090a4a8500b002131bb59d61so4087964pjh.1 for ; Wed, 09 Nov 2022 11:53:45 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20210112.gappssmtp.com; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=pvf5DNL7l0QfwfyGig7DFSApyrhi9PfVXc+jMILl/O8=; b=oO8PnKSgFM2betsH7nTymS9+6m4tELA0AOp0gBjRLB5vOhsOKSl+bcH9aaOWO+VS1M t0oMqfT/9aSLHLFqmqeNuPq4blul14TmGCVQWb9wLQw+VKGYlCusfGvfC1wHtqTrMp6W yA+S04JbupfWz1vWk0ijicQsbVNJSbseAfsDcByMGBcSNK7XObm8MIIv9md/+Hd5nyXr cGMw83RxDYmh26LoS4wtGTaeZzChpVEsWOScI6qIuhd1nH5lrogiTVeOVtguhx7kSLFY 6z8HQsjIJXGX273D93I8H+6EcNfR7axECPS+K5Sg5CRXyDw6kH2zQLwUdktvE+A3VZmS MyWQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=pvf5DNL7l0QfwfyGig7DFSApyrhi9PfVXc+jMILl/O8=; b=P87JAAU9mv4AdpfYOHxc1Z/uqr7ZyxDZwl5pehNt1jrLB7DLQ3fOcyT88aTalcKXpg pgeA2XSDpT1f6xrQZF78I+eJ8ITfFSO6NwI857uqC8BNc4Seqvi9792hpYiLYWRtDJTz pfS9IFoQRBV5pL80R5T+mewj1wxlyIaGu0m3CubndnZnSOWE9KpVVuCkEIrEHcELUzBt yyLgqM1r2r5DUarwoaL4CSSMB/ZOzZphdU/5ltdBSo65EJhFQW2SdcJZVbGOgQvyFnkE Nq5YtlFb9AUzE7K59GDxvcvlJ3J/T1cvjMG0JIiGedF3Fqtq4Tx8HpJcrVwCsHB1ghAv J01A== X-Gm-Message-State: ACrzQf15CtoQ6ue0yBS/M7R43IGYbSII/Nc3bbLt5qfUc9GF1V+yMLXN a2NFNcJ1vtafxVVZcS/IuNVyYZeEWQFj1Q== X-Google-Smtp-Source: AMsMyM5RWKJJc8GHLHsQXtcqzbuEyuh3ejnk2y9X7psDk9n7Pw74vuE++igP0AJk1+Pdp5QDyXLc7Q== X-Received: by 2002:a17:902:ecc1:b0:186:b57e:d229 with SMTP id a1-20020a170902ecc100b00186b57ed229mr63331995plh.167.1668023624529; Wed, 09 Nov 2022 11:53:44 -0800 (PST) Received: from hermes.local (204-195-120-218.wavecable.com. [204.195.120.218]) by smtp.gmail.com with ESMTPSA id u14-20020a170902e5ce00b0017f778d4543sm9628875plf.241.2022.11.09.11.53.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 09 Nov 2022 11:53:43 -0800 (PST) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger , Olivier Matz , Yipeng Wang , Sameh Gobriel , Bruce Richardson , Vladimir Medvedkin , Anatoly Burakov Subject: [PATCH v2 06/14] test: fix whitespace Date: Wed, 9 Nov 2022 11:53:23 -0800 Message-Id: <20221109195331.143473-7-stephen@networkplumber.org> X-Mailer: git-send-email 2.35.1 In-Reply-To: <20221109195331.143473-1-stephen@networkplumber.org> References: <20221109191445.140320-1-stephen@networkplumber.org> <20221109195331.143473-1-stephen@networkplumber.org> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Add space after keywords. Signed-off-by: Stephen Hemminger --- app/test/test_cmdline_cirbuf.c | 4 ++-- app/test/test_debug.c | 4 ++-- app/test/test_hash.c | 6 +++--- app/test/test_lpm6_perf.c | 2 +- app/test/test_malloc.c | 14 +++++++------- app/test/test_mbuf.c | 14 ++++++-------- app/test/test_spinlock.c | 2 +- 7 files changed, 22 insertions(+), 24 deletions(-) diff --git a/app/test/test_cmdline_cirbuf.c b/app/test/test_cmdline_cirbuf.c index 8ac326cb02e0..6f7aae6df59a 100644 --- a/app/test/test_cmdline_cirbuf.c +++ b/app/test/test_cmdline_cirbuf.c @@ -708,7 +708,7 @@ test_cirbuf_char_fill(void) return -1; } /* delete buffer from tail */ - for(i = 0; i < CMDLINE_TEST_BUFSIZE; i++) + for (i = 0; i < CMDLINE_TEST_BUFSIZE; i++) cirbuf_del_tail_safe(&cb); /* try to delete from an empty buffer */ if (cirbuf_del_tail_safe(&cb) >= 0) { @@ -737,7 +737,7 @@ test_cirbuf_char_fill(void) return -1; } /* delete buffer from head */ - for(i = 0; i < CMDLINE_TEST_BUFSIZE; i++) + for (i = 0; i < CMDLINE_TEST_BUFSIZE; i++) cirbuf_del_head_safe(&cb); /* try to delete from an empty buffer */ if (cirbuf_del_head_safe(&cb) >= 0) { diff --git a/app/test/test_debug.c b/app/test/test_debug.c index 2704f5b92726..28fc2180e2b0 100644 --- a/app/test/test_debug.c +++ b/app/test/test_debug.c @@ -53,7 +53,7 @@ test_panic(void) return -1; } wait(&status); - if(status == 0){ + if (status == 0) { printf("Child process terminated normally!\n"); return -1; } else @@ -84,7 +84,7 @@ test_exit_val(int exit_val) } wait(&status); printf("Child process status: %d\n", status); - if(!WIFEXITED(status) || WEXITSTATUS(status) != (uint8_t)exit_val){ + if (!WIFEXITED(status) || WEXITSTATUS(status) != (uint8_t)exit_val) { printf("Child process terminated with incorrect status (expected = %d)!\n", exit_val); return -1; diff --git a/app/test/test_hash.c b/app/test/test_hash.c index 3e45afaa67fc..35d9d8a62ef8 100644 --- a/app/test/test_hash.c +++ b/app/test/test_hash.c @@ -724,12 +724,12 @@ static int test_five_keys(void) } /* Lookup */ - for(i = 0; i < 5; i++) + for (i = 0; i < 5; i++) key_array[i] = &keys[i]; ret = rte_hash_lookup_bulk(handle, &key_array[0], 5, (int32_t *)pos); - if(ret == 0) - for(i = 0; i < 5; i++) { + if (ret == 0) + for (i = 0; i < 5; i++) { print_key_info("Lkp", key_array[i], pos[i]); RETURN_IF_ERROR(pos[i] != expected_pos[i], "failed to find key (pos[%u]=%d)", i, pos[i]); diff --git a/app/test/test_lpm6_perf.c b/app/test/test_lpm6_perf.c index aaf2773b6fac..2f9321345e4b 100644 --- a/app/test/test_lpm6_perf.c +++ b/app/test/test_lpm6_perf.c @@ -47,7 +47,7 @@ print_route_distribution(const struct rules_tbl_entry *table, uint32_t n) printf("--------------------------- \n"); /* Count depths. */ - for(i = 1; i <= 128; i++) { + for (i = 1; i <= 128; i++) { unsigned depth_counter = 0; double percent_hits; diff --git a/app/test/test_malloc.c b/app/test/test_malloc.c index de40e506113a..8d3750a3f1f0 100644 --- a/app/test/test_malloc.c +++ b/app/test/test_malloc.c @@ -86,8 +86,8 @@ test_align_overlap_per_lcore(__rte_unused void *arg) ret = -1; break; } - for(j = 0; j < 1000 ; j++) { - if( *(char *)p1 != 0) { + for (j = 0; j < 1000 ; j++) { + if (*(char *)p1 != 0) { printf("rte_zmalloc didn't zero the allocated memory\n"); ret = -1; } @@ -157,8 +157,8 @@ test_reordered_free_per_lcore(__rte_unused void *arg) ret = -1; break; } - for(j = 0; j < 1000 ; j++) { - if( *(char *)p1 != 0) { + for (j = 0; j < 1000 ; j++) { + if (*(char *)p1 != 0) { printf("rte_zmalloc didn't zero the allocated memory\n"); ret = -1; } @@ -331,12 +331,12 @@ test_multi_alloc_statistics(void) /* After freeing both allocations check stats return to original */ rte_malloc_get_socket_stats(socket, &post_stats); - if(second_stats.heap_totalsz_bytes != first_stats.heap_totalsz_bytes) { + if (second_stats.heap_totalsz_bytes != first_stats.heap_totalsz_bytes) { printf("Incorrect heap statistics: Total size \n"); return -1; } /* Check allocated size is equal to two additions plus overhead */ - if(second_stats.heap_allocsz_bytes != + if (second_stats.heap_allocsz_bytes != size + overhead + first_stats.heap_allocsz_bytes) { printf("Incorrect heap statistics: Allocated size \n"); return -1; @@ -495,7 +495,7 @@ test_realloc_socket(int socket) return -1; } /* calc an alignment we don't already have */ - while(RTE_PTR_ALIGN(ptr7, new_align) == ptr7) + while (RTE_PTR_ALIGN(ptr7, new_align) == ptr7) new_align *= 2; char *ptr8 = rte_realloc_socket(ptr7, size7, new_align, socket); if (!ptr8){ diff --git a/app/test/test_mbuf.c b/app/test/test_mbuf.c index 53fe898a384c..fceacb8fead8 100644 --- a/app/test/test_mbuf.c +++ b/app/test/test_mbuf.c @@ -120,7 +120,7 @@ static unsigned refcnt_lcore[RTE_MAX_LCORE]; printf("mbuf test FAILED (l.%d): <" str ">\n", \ __LINE__, ##__VA_ARGS__); \ goto fail; \ -} while(0) +} while (0) /* * test data manipulation in mbuf with non-ascii data @@ -154,9 +154,7 @@ test_pktmbuf_with_non_ascii_data(struct rte_mempool *pktmbuf_pool) return 0; fail: - if(m) { - rte_pktmbuf_free(m); - } + rte_pktmbuf_free(m); return -1; } @@ -701,12 +699,12 @@ test_pktmbuf_pool(struct rte_mempool *pktmbuf_pool) } struct rte_mbuf *extra = NULL; extra = rte_pktmbuf_alloc(pktmbuf_pool); - if(extra != NULL) { + if (extra != NULL) { printf("Error pool not empty"); ret = -1; } extra = rte_pktmbuf_clone(m[0], pktmbuf_pool); - if(extra != NULL) { + if (extra != NULL) { printf("Error pool not empty"); ret = -1; } @@ -966,7 +964,7 @@ test_pktmbuf_free_segment(struct rte_mempool *pktmbuf_pool) struct rte_mbuf *mb, *mt; mb = m[i]; - while(mb != NULL) { + while (mb != NULL) { mt = mb; mb = mb->next; rte_pktmbuf_free_seg(mt); @@ -1195,7 +1193,7 @@ verify_mbuf_check_panics(struct rte_mbuf *buf) return -1; } wait(&status); - if(status == 0) + if (status == 0) return -1; return 0; diff --git a/app/test/test_spinlock.c b/app/test/test_spinlock.c index 3f59372300c3..3ee82fa963a5 100644 --- a/app/test/test_spinlock.c +++ b/app/test/test_spinlock.c @@ -237,7 +237,7 @@ test_spinlock(void) /* * Try to acquire a lock that we already own */ - if(!rte_spinlock_recursive_trylock(&slr)) { + if (!rte_spinlock_recursive_trylock(&slr)) { printf("rte_spinlock_recursive_trylock failed on a lock that " "we already own\n"); ret = -1;