diff mbox series

common/mlx5: fix DevX register read error severity

Message ID 20221110130520.15275-1-getelson@nvidia.com (mailing list archive)
State Accepted, archived
Delegated to: Raslan Darawsheh
Headers
Series common/mlx5: fix DevX register read error severity |

Checks

Context Check Description
ci/checkpatch warning coding style issues
ci/Intel-compilation success Compilation OK
ci/iol-mellanox-Performance success Performance Testing PASS
ci/intel-Testing success Testing PASS
ci/iol-intel-Functional success Functional Testing PASS
ci/iol-intel-Performance success Performance Testing PASS
ci/github-robot: build success github build: passed
ci/iol-aarch64-unit-testing success Testing PASS
ci/iol-x86_64-unit-testing success Testing PASS
ci/iol-x86_64-compile-testing success Testing PASS
ci/iol-aarch64-compile-testing success Testing PASS

Commit Message

Gregory Etelson Nov. 10, 2022, 1:05 p.m. UTC 
  PMD attempt to read HW UTC counter properties can fail because the feature
has no support in port FW or mlx5 kernel module.

In that case PMD still can produce correct time-stamps if it runs on core with
nanosecond time resolution.

Fixes: b0067860959d ("common/mlx5: update log for DevX general command failure")

Cc: stable@dpdk.org

Signed-off-by: Gregory Etelson <getelson@nvidia.com>
Acked-by: Matan Azrad <matan@nvidia.com>
---
 drivers/common/mlx5/mlx5_devx_cmds.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

David Marchand Nov. 10, 2022, 4:18 p.m. UTC | #1 
On Thu, Nov 10, 2022 at 2:06 PM Gregory Etelson <getelson@nvidia.com> wrote:
>
> PMD attempt to read HW UTC counter properties can fail because the feature
> has no support in port FW or mlx5 kernel module.
>
> In that case PMD still can produce correct time-stamps if it runs on core with
> nanosecond time resolution.
>
> Fixes: b0067860959d ("common/mlx5: update log for DevX general command failure")
>

No blank line here.

> Cc: stable@dpdk.org
>

Reported-by: David Marchand <david.marchand@redhat.com>
> Signed-off-by: Gregory Etelson <getelson@nvidia.com>
> Acked-by: Matan Azrad <matan@nvidia.com>

I had tested the same change to pass OVS unit tests.

I did not hit any other error level messages from functions changed in
b0067860959d ("common/mlx5: update log for DevX general command
failure").
So I guess only changing this one is enough.

Acked-by: David Marchand <david.marchand@redhat.com>
Raslan Darawsheh Nov. 10, 2022, 5:17 p.m. UTC | #2 
Hi,

> -----Original Message-----
> From: Gregory Etelson <getelson@nvidia.com>
> Sent: Thursday, November 10, 2022 3:05 PM
> To: dev@dpdk.org
> Cc: Gregory Etelson <getelson@nvidia.com>; Matan Azrad
> <matan@nvidia.com>; Raslan Darawsheh <rasland@nvidia.com>;
> stable@dpdk.org; Slava Ovsiienko <viacheslavo@nvidia.com>
> Subject: [PATCH] common/mlx5: fix DevX register read error severity
> 
> PMD attempt to read HW UTC counter properties can fail because the
> feature
> has no support in port FW or mlx5 kernel module.
> 
> In that case PMD still can produce correct time-stamps if it runs on core with
> nanosecond time resolution.
> 
> Fixes: b0067860959d ("common/mlx5: update log for DevX general command
> failure")
> removed extra blank line
> Cc: stable@dpdk.org
> 
added reported-by tag
> Signed-off-by: Gregory Etelson <getelson@nvidia.com>
> Acked-by: Matan Azrad <matan@nvidia.com>

Patch applied to next-net-mlx,

Kindest regards,
Raslan Darawsheh
diff mbox series

Patch

diff --git a/drivers/common/mlx5/mlx5_devx_cmds.c b/drivers/common/mlx5/mlx5_devx_cmds.c
index 05b9429c7f..59cebb530f 100644
--- a/drivers/common/mlx5/mlx5_devx_cmds.c
+++ b/drivers/common/mlx5/mlx5_devx_cmds.c
@@ -111,7 +111,7 @@  mlx5_devx_cmd_register_read(void *ctx, uint16_t reg_id, uint32_t arg,
 					 MLX5_ST_SZ_BYTES(access_register_out) +
 					 sizeof(uint32_t) * dw_cnt);
 	if (rc || MLX5_FW_STATUS(out)) {
-		DEVX_DRV_LOG(ERR, out, "read access", "NIC register", reg_id);
+		DEVX_DRV_LOG(DEBUG, out, "read access", "NIC register", reg_id);
 		return MLX5_DEVX_ERR_RC(rc);
 	}
 	memcpy(data, &out[MLX5_ST_SZ_DW(access_register_out)],