On 11/11/2022 9:04 AM, Andrew Rybchenko wrote:
> @@ -459,11 +486,16 @@ tx_only_begin(portid_t pi)
> {
> uint16_t pkt_hdr_len, pkt_data_len;
> int dynf;
> - uint8_t ip_proto = IPPROTO_UDP;
> + uint8_t ip_proto;
>
> pkt_hdr_len = (uint16_t)(sizeof(struct rte_ether_hdr) +
> sizeof(struct rte_ipv4_hdr));
> +
> + ip_proto = txonly_tso_segsz > 0 ? IPPROTO_TCP : IPPROTO_UDP;
Instead of detecting protocol via txonly_tso_segsz, what about
introducing '--tx-tcp' and use it?
I put some more comment to have tcp specific parameters in prev version
of the patch.
As far as I understand, '--tx-udp'/'--tx-tcp' parameters are optional,
that is why to detect protocol we can:
a) Use UDP by default if '--tx-udp'/'--tx-tcp' not provided
b) Have another argument to set protocol explicitly, something like
'--tx-proto='. In this case it is better to have '--tx-udp'/'--tx-tcp'
parameter as '--tx-l4-port', because otherwise protocol information will
be duplicated (need to check against '--tx-proto=txp --tx-udp' etc..).
I think both of us think it is not good idea to change existing
parameter name, that is why I prefer option a) above, what do you think?
> switch (ip_proto) {
> + case IPPROTO_TCP:
> + pkt_hdr_len += sizeof(struct rte_tcp_hdr);
> + break;
> case IPPROTO_UDP:
> pkt_hdr_len += sizeof(struct rte_udp_hdr);
> break;
@@ -156,6 +156,7 @@ usage(char* progname)
printf(" --txpkts=X[,Y]*: set TX segment sizes"
" or total packet length.\n");
printf(" --txonly-multi-flow: generate multiple flows in txonly mode\n");
+ printf(" --txonly-tso-mss=N: enable TSO offload and generate packets with specified MSS in txonly mode\n");
printf(" --tx-ip=src,dst: IP addresses in Tx-only mode\n");
printf(" --tx-udp=src[,dst]: UDP ports in Tx-only mode\n");
printf(" --eth-link-speed: force link speed.\n");
@@ -670,6 +671,7 @@ launch_args_parse(int argc, char** argv)
{ "rxhdrs", 1, 0, 0 },
{ "txpkts", 1, 0, 0 },
{ "txonly-multi-flow", 0, 0, 0 },
+ { "txonly-tso-mss", 1, 0, 0 },
{ "rxq-share", 2, 0, 0 },
{ "eth-link-speed", 1, 0, 0 },
{ "disable-link-check", 0, 0, 0 },
@@ -1297,6 +1299,14 @@ launch_args_parse(int argc, char** argv)
}
if (!strcmp(lgopts[opt_idx].name, "txonly-multi-flow"))
txonly_multi_flow = 1;
+ if (!strcmp(lgopts[opt_idx].name, "txonly-tso-mss")) {
+ n = atoi(optarg);
+ if (n >= 0 && n <= UINT16_MAX)
+ txonly_tso_segsz = n;
+ else
+ rte_exit(EXIT_FAILURE,
+ "TSO MSS must be >= 0 and <= UINT16_MAX\n");
+ }
if (!strcmp(lgopts[opt_idx].name, "rxq-share")) {
if (optarg == NULL) {
rxq_share = UINT32_MAX;
@@ -264,6 +264,9 @@ enum tx_pkt_split tx_pkt_split = TX_PKT_SPLIT_OFF;
uint8_t txonly_multi_flow;
/**< Whether multiple flows are generated in TXONLY mode. */
+uint16_t txonly_tso_segsz;
+/**< TSO MSS for generated packets in TXONLY mode. */
+
uint32_t tx_pkt_times_inter;
/**< Timings for send scheduling in TXONLY mode, time between bursts. */
@@ -1615,6 +1618,15 @@ init_config_port_offloads(portid_t pid, uint32_t socket_id)
port->dev_conf.txmode.offloads &=
~RTE_ETH_TX_OFFLOAD_MBUF_FAST_FREE;
+ if (txonly_tso_segsz > 0) {
+ if ((ports[pid].dev_info.tx_offload_capa &
+ RTE_ETH_TX_OFFLOAD_TCP_TSO) == 0) {
+ rte_exit(EXIT_FAILURE,
+ "TSO isn't supported for port %d\n", pid);
+ }
+ port->dev_conf.txmode.offloads |= RTE_ETH_TX_OFFLOAD_TCP_TSO;
+ }
+
/* Apply Rx offloads configuration */
for (i = 0; i < port->dev_info.max_rx_queues; i++)
port->rxq[i].conf.offloads = port->dev_conf.rxmode.offloads;
@@ -611,6 +611,7 @@ enum tx_pkt_split {
extern enum tx_pkt_split tx_pkt_split;
extern uint8_t txonly_multi_flow;
+extern uint16_t txonly_tso_segsz;
extern uint32_t rxq_share;
@@ -60,6 +60,7 @@ RTE_DEFINE_PER_LCORE(uint8_t, _ip_var); /**< IP address variation */
static union pkt_l4_hdr_t {
struct rte_udp_hdr udp; /**< UDP header of tx packets. */
+ struct rte_tcp_hdr tcp; /**< TCP header of tx packets. */
} pkt_l4_hdr; /**< Layer 4 header of tx packets. */
static uint64_t timestamp_mask; /**< Timestamp dynamic flag mask */
@@ -112,8 +113,19 @@ setup_pkt_l4_ip_headers(uint8_t ip_proto, struct rte_ipv4_hdr *ip_hdr,
uint32_t ip_cksum;
uint16_t pkt_len;
struct rte_udp_hdr *udp_hdr;
+ struct rte_tcp_hdr *tcp_hdr;
switch (ip_proto) {
+ case IPPROTO_TCP:
+ /*
+ * Initialize TCP header.
+ */
+ pkt_len = (uint16_t)(pkt_data_len + sizeof(struct rte_tcp_hdr));
+ tcp_hdr = &l4_hdr->tcp;
+ tcp_hdr->src_port = rte_cpu_to_be_16(tx_l4_src_port);
+ tcp_hdr->dst_port = rte_cpu_to_be_16(tx_l4_dst_port);
+ tcp_hdr->data_off = (sizeof(struct rte_tcp_hdr) << 2) & 0xF0;
+ break;
case IPPROTO_UDP:
/*
* Initialize UDP header.
@@ -189,6 +201,8 @@ update_pkt_header(struct rte_mbuf *pkt, uint32_t total_pkt_len)
ip_hdr->hdr_checksum = rte_ipv4_cksum(ip_hdr);
switch (ip_hdr->next_proto_id) {
+ case IPPROTO_TCP:
+ break;
case IPPROTO_UDP:
/* update UDP packet length */
udp_hdr = rte_pktmbuf_mtod_offset(pkt, struct rte_udp_hdr *,
@@ -232,6 +246,12 @@ pkt_burst_prepare(struct rte_mbuf *pkt, struct rte_mempool *mbp,
pkt->l2_len = sizeof(struct rte_ether_hdr);
pkt->l3_len = sizeof(struct rte_ipv4_hdr);
+ if (txonly_tso_segsz > 0) {
+ pkt->tso_segsz = txonly_tso_segsz;
+ pkt->ol_flags |= RTE_MBUF_F_TX_TCP_SEG | RTE_MBUF_F_TX_IPV4 |
+ RTE_MBUF_F_TX_IP_CKSUM;
+ }
+
pkt_len = pkt->data_len;
pkt_seg = pkt;
for (i = 1; i < nb_segs; i++) {
@@ -267,6 +287,12 @@ pkt_burst_prepare(struct rte_mbuf *pkt, struct rte_mempool *mbp,
RTE_PER_LCORE(_ip_var) = ip_var;
}
switch (ip_hdr->next_proto_id) {
+ case IPPROTO_TCP:
+ copy_buf_to_pkt(&pkt_l4_hdr.tcp, sizeof(pkt_l4_hdr.tcp), pkt,
+ sizeof(struct rte_ether_hdr) +
+ sizeof(struct rte_ipv4_hdr));
+ l4_hdr_size = sizeof(pkt_l4_hdr.tcp);
+ break;
case IPPROTO_UDP:
copy_buf_to_pkt(&pkt_l4_hdr.udp, sizeof(pkt_l4_hdr.udp), pkt,
sizeof(struct rte_ether_hdr) +
@@ -277,6 +303,7 @@ pkt_burst_prepare(struct rte_mbuf *pkt, struct rte_mempool *mbp,
l4_hdr_size = 0;
break;
}
+ pkt->l4_len = l4_hdr_size;
if (unlikely(tx_pkt_split == TX_PKT_SPLIT_RND) || txonly_multi_flow)
update_pkt_header(pkt, pkt_len);
@@ -459,11 +486,16 @@ tx_only_begin(portid_t pi)
{
uint16_t pkt_hdr_len, pkt_data_len;
int dynf;
- uint8_t ip_proto = IPPROTO_UDP;
+ uint8_t ip_proto;
pkt_hdr_len = (uint16_t)(sizeof(struct rte_ether_hdr) +
sizeof(struct rte_ipv4_hdr));
+
+ ip_proto = txonly_tso_segsz > 0 ? IPPROTO_TCP : IPPROTO_UDP;
switch (ip_proto) {
+ case IPPROTO_TCP:
+ pkt_hdr_len += sizeof(struct rte_tcp_hdr);
+ break;
case IPPROTO_UDP:
pkt_hdr_len += sizeof(struct rte_udp_hdr);
break;
@@ -369,6 +369,10 @@ The command line options are:
Generate multiple flows in txonly mode.
+* ``--txonly-tso-mss=N```
+
+ Enable TSO offload and generate TCP packets with specified MSS in txonly mode.
+
* ``--rxq-share=[X]``
Create queues in shared Rx queue mode if device supports.