From patchwork Thu Nov 17 08:55:37 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Suanming Mou X-Patchwork-Id: 119929 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id C25F6A00C2; Thu, 17 Nov 2022 09:56:04 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 646A440DDC; Thu, 17 Nov 2022 09:56:04 +0100 (CET) Received: from NAM12-DM6-obe.outbound.protection.outlook.com (mail-dm6nam12on2054.outbound.protection.outlook.com [40.107.243.54]) by mails.dpdk.org (Postfix) with ESMTP id 3A05040DDA for ; Thu, 17 Nov 2022 09:56:03 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=JWCQp4cyojJjeeYqe7CXMtK/oJrpjn+7A06GZtQ8bAgwgPNMJ3eZ3JPkx4OrYPbOa8HQ+5f3wJ6fS3SpXwzuAxnrxc+Qvj/cU5ZoMdWGPtPZaK62YocPAUas15QaPMhAzb0qHisC76qFjME7Un1H1xbxuSvjvaY4NUeq7NFGD4USJcNUvMutdyGs8kbXJqQI7fku7CyhR+WMl5X6q+vxvJ1uWG9etk637iyRL+arBc0BW8X9/ib3999fzloUTmY69Od3ETviKcA4HteANXRN3I9YTQU1lTDZLrGjQrGcUr3CwCU4QqQQ6dyaYpCajXaxoiRfOqoG1ghMnZKIY5WucQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=+QV62ckF4Ym5EoIX6qVnG1mtbInvZx2V1hmYPponb+o=; b=fJTVIGwQdHC5ggvC89SWDaA0n2wmwcsvh9xVbosiXvcaJSlA+hVuWX6VbUrfkY7X7oHF3FndHC0z3B5SoFNJlmPTT7Z1EkNlnwLjQNqGsVq8CES8ze5MMGq0VLvhKa8q4SO1r4eRAX8rJLx/I4KXa4FMaytfLR/2YETEf+rmRFGeSXhm/tWzwpYGmKR96QOVu4pkWNpp0XODmbTwWtYTFBCIKj7Sp4eBC3XPdj2mBnSgsMjOlgmk/Vepf2NAkBb5QFG8Bd0r8UBZheGEgemFLx0KYPrUpnte/7/2BhIzREvB6WjDTe0pVSks6S5yo74+jwGwP3HSl/cNqdVZs+e10w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.117.161) smtp.rcpttodomain=redhat.com smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=+QV62ckF4Ym5EoIX6qVnG1mtbInvZx2V1hmYPponb+o=; b=HhJnm9DgNW5/dtbdGucjtqMP8cRFq9bK7kGoO4W6IjJva4GDeddGWXOdn0NhMIWVaq+BpjkaT41jJu6O6iaZv4HCZ0ykcloHmDcpaZZHdJl7+k2z/XpzJEar77Uv2jsZHVw90sO1xttAGkMTrYQUoCxU9om9CQ48lKpuRyGe6y7vkio8xIm7kUWrPSC3ZFnmCH17fuwBq2+te5MLGAwY60z5npC7rOljHzz2VRPVTvAkY1eRRJd6tWrjcFXwWKLiyGP/mrWxcHuDG3PvX/TZ2En1sflH1WgOw2ef/FZbf2NerMOt+IJews3ukv/Nz+yJv4dCSt1emnvrtE+oByeLrQ== Received: from MW4PR03CA0120.namprd03.prod.outlook.com (2603:10b6:303:b7::35) by DM4PR12MB5939.namprd12.prod.outlook.com (2603:10b6:8:6a::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5813.18; Thu, 17 Nov 2022 08:56:00 +0000 Received: from CO1NAM11FT026.eop-nam11.prod.protection.outlook.com (2603:10b6:303:b7:cafe::50) by MW4PR03CA0120.outlook.office365.com (2603:10b6:303:b7::35) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5813.20 via Frontend Transport; Thu, 17 Nov 2022 08:56:00 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.117.161) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.117.161 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.117.161; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.117.161) by CO1NAM11FT026.mail.protection.outlook.com (10.13.175.67) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5834.8 via Frontend Transport; Thu, 17 Nov 2022 08:56:00 +0000 Received: from rnnvmail201.nvidia.com (10.129.68.8) by mail.nvidia.com (10.129.200.67) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.36; Thu, 17 Nov 2022 00:55:53 -0800 Received: from nvidia.com (10.126.230.35) by rnnvmail201.nvidia.com (10.129.68.8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.36; Thu, 17 Nov 2022 00:55:51 -0800 From: Suanming Mou To: , Aman Singh , Yuying Zhang CC: Subject: [PATCH] app/testpmd: fix action destruction memory leak Date: Thu, 17 Nov 2022 10:55:37 +0200 Message-ID: <20221117085537.24372-1-suanmingm@nvidia.com> X-Mailer: git-send-email 2.18.1 MIME-Version: 1.0 X-Originating-IP: [10.126.230.35] X-ClientProxiedBy: rnnvmail203.nvidia.com (10.129.68.9) To rnnvmail201.nvidia.com (10.129.68.8) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CO1NAM11FT026:EE_|DM4PR12MB5939:EE_ X-MS-Office365-Filtering-Correlation-Id: c921270a-3b48-4056-6d60-08dac8798cf3 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: R3wvHsg7N6KGMmNXKnk77oJJdzzqGdv+KxZcL6cFH/3Sqxucou6dQiKjZ+WBSP7ktT4PiRVhhX5y5KlX3XTrP1g9unX3NFoBKcWb/WjLOzw6ITC1g4xzH5qfpKgvAorJgsI4qjAlL3b7TWAfywXgm6CURFmM2plXbE/RWI8WA2KJ+wxCQVvH8zw3MgXCjWV1mIRFNqkX6ZxCIgJS71gYjWglVEMmBL/j7XgVI1mO2OzqG+cIYhKiLwtOy5qEjS50cWmclZIR+fOq21Z8FPHne2JpMNQUq5qQxjmrnMNHBjC6alwBLhzT/TwXf0Mq3t/ecZphTNbbNkA7MiTbpGvX503DDNIgThSnNXPFz0b9bkoihGX1SbpOliGZjdL4yv/EbV8J0vFj2sVgYoSrDduv3AOxH6qTKfjDvGwHk1t1mpUYy6lcf4OYuW+WWPvIc39RUZ3pcB0QsW7T6CLcltfT7kjewJF9vFxANQsuAHeMFGGbEZO8ZjLwDMYJdXzO7xcVOcEFxHYKCcGDz8LqZYch8TiB65e0+tUslKeOxkekfg9SdwKOsZNs3232EWTrfMLbuLCXbXeVvR36i9jaAijQUDmQ5jDW64E88k55MLid8lYtZcMCeCBEDMgudh+3nOHNyBV6psOWlDjTKF5K2gFptOtFa4gKrKPL+RaDuJHEDW5A5UVrbYB21yR4HPKgzZ3rz2b3ObX2Rd8CDoR5qJT09g== X-Forefront-Antispam-Report: CIP:216.228.117.161; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:dc6edge2.nvidia.com; CAT:NONE; SFS:(13230022)(4636009)(376002)(396003)(346002)(39860400002)(136003)(451199015)(36840700001)(40470700004)(46966006)(4744005)(5660300002)(110136005)(41300700001)(2906002)(4326008)(70586007)(316002)(70206006)(8676002)(16526019)(336012)(6666004)(40460700003)(86362001)(26005)(47076005)(186003)(83380400001)(7696005)(478600001)(2616005)(1076003)(82310400005)(6286002)(7636003)(8936002)(426003)(356005)(82740400003)(55016003)(36756003)(36860700001)(40480700001); DIR:OUT; SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Nov 2022 08:56:00.5989 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: c921270a-3b48-4056-6d60-08dac8798cf3 X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.117.161]; Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: CO1NAM11FT026.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR12MB5939 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org In case action handle destroy fails, the job memory was not freed properly. This commit fixes the possible memory leak in the action handle destruction failed case. Fixes: c9dc03840873 ("ethdev: add indirect action async query") Signed-off-by: Suanming Mou Reported-by: David Marchand Reviewed-by: David Marchand --- app/test-pmd/config.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/app/test-pmd/config.c b/app/test-pmd/config.c index 982549ffed..719bdd4261 100644 --- a/app/test-pmd/config.c +++ b/app/test-pmd/config.c @@ -2873,9 +2873,9 @@ port_queue_action_handle_destroy(portid_t port_id, job->type = QUEUE_JOB_TYPE_ACTION_DESTROY; job->pia = pia; - if (pia->handle && - rte_flow_async_action_handle_destroy(port_id, + if (rte_flow_async_action_handle_destroy(port_id, queue_id, &attr, pia->handle, job, &error)) { + free(job); ret = port_flow_complain(&error); continue; }