From patchwork Fri Nov 18 07:02:46 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Xing, Beilei" X-Patchwork-Id: 119951 X-Patchwork-Delegate: qi.z.zhang@intel.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 8B16EA0542; Fri, 18 Nov 2022 08:02:54 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 788EC4067B; Fri, 18 Nov 2022 08:02:54 +0100 (CET) Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by mails.dpdk.org (Postfix) with ESMTP id C468A4021F for ; Fri, 18 Nov 2022 08:02:52 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1668754972; x=1700290972; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=do0+RfxoLRzVmYQeHMKm9oXSJ/f5hfiOpDqDNYEg4rw=; b=oEZTs7gAroTaOvOIGMaVEisSrQkHHy4kcbIw2tgnsKR9fVLGu+AmcfE1 7TqhlGXHgaa51Gu+f/NbeBBzH0/ODcF/cKe2/qOmJ1PioXdAMKOdLFlFz XCXyHnLHZwOGWpkDFRYlhQPnEkqLDSH9ladlPfbzLPtuWVXapqdYWnQma 49+w/SFA7RYn1sy9eE4XS7syFLMgI8MEK3MaeREQIKCpIiJOacImgImRG 4EubZjMy2FzBxYQGod6Eq9WZxc+2/vvwtIoSqMju+Sp0Y5wXYkMJPbCB2 ge1IR/MXXM7XHefRR6xgsCCB6pUtZAUdMZJV0F9TkCbduGxe/z/Q+VVfj w==; X-IronPort-AV: E=McAfee;i="6500,9779,10534"; a="377341366" X-IronPort-AV: E=Sophos;i="5.96,173,1665471600"; d="scan'208";a="377341366" Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 17 Nov 2022 23:02:51 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10534"; a="729129837" X-IronPort-AV: E=Sophos;i="5.96,173,1665471600"; d="scan'208";a="729129837" Received: from dpdk-beileix-3.sh.intel.com ([10.67.110.253]) by FMSMGA003.fm.intel.com with ESMTP; 17 Nov 2022 23:02:50 -0800 From: beilei.xing@intel.com To: jingjing.wu@intel.com Cc: dev@dpdk.org, yuan.peng@intel.com, Beilei Xing Subject: [PATCH v3] net/idpf: fix crash when launching l3fwd Date: Fri, 18 Nov 2022 07:02:46 +0000 Message-Id: <20221118070246.114513-1-beilei.xing@intel.com> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20221117101509.14472-1-beilei.xing@intel.com> References: <20221117101509.14472-1-beilei.xing@intel.com> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org From: Beilei Xing There's core dump when launching l3fwd with 1 queue 1 core. It's because NULL pointer is used if fail to configure device. This patch removes incorrect check during device configuration, and checks NULL pointer when executing VIRTCHNL2_OP_DEALLOC_VECTORS. Fixes: 549343c25db8 ("net/idpf: support device initialization") Fixes: 70675bcc3a57 ("net/idpf: support RSS") Fixes: 37291a68fd78 ("net/idpf: support write back based on ITR expire") Signed-off-by: Beilei Xing Acked-by: Qi Zhang Tested-by: Peng, Yuan --- v2 change: fix typo. v3 change: check NULL pointer before virtual channel handling. drivers/net/idpf/idpf_ethdev.c | 10 ++-------- 1 file changed, 2 insertions(+), 8 deletions(-) diff --git a/drivers/net/idpf/idpf_ethdev.c b/drivers/net/idpf/idpf_ethdev.c index 20f088eb80..491ef966a7 100644 --- a/drivers/net/idpf/idpf_ethdev.c +++ b/drivers/net/idpf/idpf_ethdev.c @@ -372,13 +372,6 @@ idpf_dev_configure(struct rte_eth_dev *dev) return -ENOTSUP; } - if ((dev->data->nb_rx_queues == 1 && conf->rxmode.mq_mode != RTE_ETH_MQ_RX_NONE) || - (dev->data->nb_rx_queues > 1 && conf->rxmode.mq_mode != RTE_ETH_MQ_RX_RSS)) { - PMD_INIT_LOG(ERR, "Multi-queue packet distribution mode %d is not supported", - conf->rxmode.mq_mode); - return -ENOTSUP; - } - if (conf->txmode.mq_mode != RTE_ETH_MQ_TX_NONE) { PMD_INIT_LOG(ERR, "Multi-queue TX mode %d is not supported", conf->txmode.mq_mode); @@ -620,7 +613,8 @@ idpf_dev_stop(struct rte_eth_dev *dev) idpf_vc_config_irq_map_unmap(vport, false); - idpf_vc_dealloc_vectors(vport); + if (vport->recv_vectors != NULL) + idpf_vc_dealloc_vectors(vport); vport->stopped = 1;