From patchwork Fri Nov 18 16:23:06 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Niklas_S=C3=B6derlund?= X-Patchwork-Id: 119972 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 11DC0A00C4; Fri, 18 Nov 2022 17:24:01 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id F07C940041; Fri, 18 Nov 2022 17:24:00 +0100 (CET) Received: from NAM12-DM6-obe.outbound.protection.outlook.com (mail-dm6nam12on2116.outbound.protection.outlook.com [40.107.243.116]) by mails.dpdk.org (Postfix) with ESMTP id 890C54003F; Fri, 18 Nov 2022 17:23:59 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=UwcDx7sPTpI/gsrCtmpONVx69Ak2NVXMkpqosXtN93BTDtoFPYfQnchidIjSm0qB5R5FX+jeHyTGICq1hhMuRNhKYgkJAFChw3JOGVwqS2keryHuAvuvVfl5BUts98pkGitGsehMOxOK4zY/YvZIAgCcMfKqYlQu0j6pu8/8ME/QKPxlOZdhLjOxomsZ3UibI1hW3sOZ61geunIWk1oFZZXM7v+rBQDS79Pev3+RCkOq31extj/QpEAIMTEDMNk4hX+p2LppEB/coaPen5nESCYwT5HCIABqUYUsfqcUlqEY/23spI43DzdfcYFzsiY2rak0a8C8FSW3XEILG7Mx7A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Mer9099d5bHeZXi8P08d4fFqtPTjHn3sNCOwA7/3dWQ=; b=Vz94VOvpXOmj3R7RI1foO8h7leWkOXeK5TqDb+NFRvuNIIP9/ADTZ/U7HUNex1h5LfxeWg4AkOgyDCDoSzI/EXr2cSQCql/VxCI8VsewJhMH17QhQ2uDtW/pJgfw65ybNH75XbNY1XWBxFIsBZy0RVlAAoGSvk3EGK+WIYIp4PX9UiF+sjGRCN4Q/NrRL98hcDuFJw651w3e0l+WMrNeKK85KvS3hO+9lmTnYZoywScDLGy6cw2lkn+IjIaWaWy3oghU5RE+F0YTzUN/n+RuLw0EwxQvtUsJjn9eSN9/5751sKnQa+F96pVZc1+jlq/UB+D5mXn5VhEd5lPHDIS+2w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=corigine.com; dmarc=pass action=none header.from=corigine.com; dkim=pass header.d=corigine.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=corigine.onmicrosoft.com; s=selector2-corigine-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Mer9099d5bHeZXi8P08d4fFqtPTjHn3sNCOwA7/3dWQ=; b=B0IwzLj1TZF10lG7yI8XTWzewXmGOUNbioNQDmfs/krj4pRnntp+MErHWnMn9sw8vNkR7WUErEd5wFwCbrNqKQUEUmkr9c4PAb8If77uCAgr79HjQzZvEZ9PkZSYqguCYRz4ltB0afERUx0aRmqr/87srTAnPXjR3/GrNdCgjrA= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=corigine.com; Received: from SJ0PR13MB6037.namprd13.prod.outlook.com (2603:10b6:a03:3e2::9) by DM8PR13MB5110.namprd13.prod.outlook.com (2603:10b6:8:31::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5834.9; Fri, 18 Nov 2022 16:23:56 +0000 Received: from SJ0PR13MB6037.namprd13.prod.outlook.com ([fe80::9d7f:1fa0:af36:e57a]) by SJ0PR13MB6037.namprd13.prod.outlook.com ([fe80::9d7f:1fa0:af36:e57a%7]) with mapi id 15.20.5813.018; Fri, 18 Nov 2022 16:23:56 +0000 From: =?utf-8?q?Niklas_S=C3=B6derlund?= To: dev@dpdk.org Cc: oss-drivers@corigine.com, Fei Qin , stable@dpdk.org, =?utf-8?q?Niklas_S=C3=B6derlund?= , Chaoyong He Subject: [PATCH] net/nfp: fix return path in TSO processing function Date: Fri, 18 Nov 2022 17:23:06 +0100 Message-Id: <20221118162306.975425-1-niklas.soderlund@corigine.com> X-Mailer: git-send-email 2.38.1 X-ClientProxiedBy: FR2P281CA0150.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:98::11) To SJ0PR13MB6037.namprd13.prod.outlook.com (2603:10b6:a03:3e2::9) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SJ0PR13MB6037:EE_|DM8PR13MB5110:EE_ X-MS-Office365-Filtering-Correlation-Id: 07f0bb47-47b1-4a4d-ab0f-08dac9814a1c X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: PW+rBonKbAj5wej9zYlxNhgsIQ5gQeXx5RHsLZq7bgd7JqIye85y0CY4k0M8qxBaAwjW0z+yIduAnMzyOOMy8b1/UTApEgwnxtnaNHtMP+euCHdVZkUIou8TQSmDn7GWrZ2DmglAKnztrndEM5A7iASCQtvJPU55S+I+bvikzKeeDxppWEEt8rJv/YDfkEwQ+cdZ2t+7KldWa0pedDI76gq9BO6C2nxKbJt9nSmiJTMPqqa75vpRCKJl/N0PbEFZC52axaoOuvro4jdiHJIO2opQbnxmy3HjmAfRvW9P0KWXGlJUXfjT946JNWoVHAj2jmMx2k8bKteQnCgQ9UM7SlVzYEIHeMMBGq0gx5VAIBqWZ4CF2GFWt21Mi0qDO1wE/cmMxn7zq7ogpJZMg6iCvDXqf4aFKsvmCZL6ZAPlRjZa3MvUM0vu1wyrClwwisQ0rxd12umrIp3jww3gkiS2g4IVIzOQyP5MW9ZMQX2E6FYYIIg+jjDIjayolqCRYAeTe8VyKu+kro9PoqPah4zVmYsvNe/lBwFrLeatY/M7MDq6XoEAUlF2CKeZv1qUE3sBAT5YGs6aNiz8tnu+R8r8WfRgaleKOrny97D4Z0FHxFo3IcJrb+Fb2u+syUYZgt3efTcemnpb27OPp205Qq01ExcfvQSYBLCrimbiNRH38XPN2VVWsPKNv7H/sjbLkeW6 X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:SJ0PR13MB6037.namprd13.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230022)(4636009)(366004)(136003)(346002)(396003)(376002)(39830400003)(451199015)(66556008)(2906002)(107886003)(450100002)(66476007)(6666004)(66946007)(8676002)(4326008)(2616005)(26005)(86362001)(41300700001)(6512007)(5660300002)(36756003)(316002)(8936002)(1076003)(52116002)(6916009)(6506007)(186003)(54906003)(6486002)(38100700002)(38350700002)(478600001); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?q?Lq9JKCMv7rKSx54T5UHviAllTpN0?= =?utf-8?q?nRENkQdBxsgh9oznpZZ4DCAFaQE5ZP/ZB4yjnOcs76SX5TodTyxkZV3CW1ruYBzp7?= =?utf-8?q?aDmiNvr657d1E6HkfSTLo93D9qEnTB6NTIUkbRLVCEnnN1X+3sJ/EcqaVKQr9I1u5?= =?utf-8?q?Gyqr7J0YPxwqIjLo3ecyl29I/hArj5/T0s0O4+r+SS/eZRLSqdg/YpmV8WNAdQpvL?= =?utf-8?q?KTgZMfU6uF/o1pKsjlzrbCSQ+CFuh/dBWj+TUcmJNZU7tO8RQFWOrTwvdHO2XXBSY?= =?utf-8?q?IWZSlUAuW9s3daUt+Z6grgYOVzXuOmoddtMcy11znLkbC+yYzwdojtc5cVuf0VNr6?= =?utf-8?q?SvF3fH1xhTXcY1qZpOLOYxlnPOSM7kxdcq7Cwmku7592im9DyYrIt9HQUpL22/yJO?= =?utf-8?q?FDTnEnLPYf9hpXnniOhZRjrf4B3e8C6ty3Uw5o84NEfde7kRgDEncdfutf+GuMTN7?= =?utf-8?q?UH2E0wGbQpiz7QfO8/BtpIJ2yKch4eWD1A7iCnEZg50KFkigG0oJSNNbPojdAJQAk?= =?utf-8?q?2w6qLeR9kq+h42IWi43kKmcVoO1w3N+/ifKH/6M1S2dn/uI3NdJNifQ7dRfh5gzOs?= =?utf-8?q?e3Tmf+wfgFTpBAymaiF3RkYEO5+lTnnax4mwNuCTbjzKf89C9At7ZUvVtnEX1J+F8?= =?utf-8?q?ucvNJPpQvlT/LNS/3zrUsnKBN36Y+S2Cc2I2qikwWRGD6+mWyStpNKNyV5HX0RGhG?= =?utf-8?q?tAcmMsHJiQFuNVHljRYjo4esZKpU+4aSTYti9lZxTWlpIP8MGfJHiQhyA7oGDQ09K?= =?utf-8?q?UIjwul81OCpVV7N9ZUfn2F0osm1Ke548UhG3uqt+jVZbslVpnPHCYTQjTWuRmpmBZ?= =?utf-8?q?PMrunLq3bv8S2yCoUL4z1r0PpX54UB8GawufrvX+pAhWRgb6hNOLtSdEjisj/N0x7?= =?utf-8?q?trtzyTGW1ZhOotmdj2g2gSih8tGObi+MbIddESdynO0IgaNMFDf1YDCvIbLpeJYpL?= =?utf-8?q?+evUj6JnkKaUGPdSHZbrNMTCuCiloxtEE3zQoKtgRCzWzK8Q/9BCuFPGolOu7GCct?= =?utf-8?q?rgESLGil0yqUwsiDV4DD1cUcKld5pti60KDnEc9r89k6BmVlD+6/QbpBQmxpnckZG?= =?utf-8?q?b8o1kGN4LY8AArRLnb85MeZa6kZk0RNDOwLJRRKhxm146Ass6Fx9GKeTGSKftIOzr?= =?utf-8?q?Hivcf6zHezriubSGvpyHEA7OCz9MKRXQNASZw3qISLKZ/Zcp/aeIYDl1wyRWLoz69?= =?utf-8?q?VKn58OHdIAJosGCYYIoPcDiI3OSM9y/AbYR/jISOl1dDRcS5mDq2eg18b0nK+BVG0?= =?utf-8?q?6pkfc29Vlhu6eDESzUnCAURX5kCI5Q3ztAgyNdmmyadqYFINubDMWcws6d1dwg/lJ?= =?utf-8?q?7e8Wpj9obMjq5mShkyRYwDEl52xXPHQ+6XUM9ZkyTxslXF9PoQBTH6K4y2ivUiHdQ?= =?utf-8?q?KY9LDrz4+p/KnMRGlTY540JBXsjgM6PFSYnG/nbSyqX234Gdkm6USzfzTnzV/uxpK?= =?utf-8?q?w0nOqIx637zl//hw4TCTwQCo6HEsoHQCjkGOgl3+HEEkJ4WqdDxWvCBl52aSB0r2A?= =?utf-8?q?FWqewXSFCVQB/KQ9KFZdVjp96DlRpnSnoA=3D=3D?= X-OriginatorOrg: corigine.com X-MS-Exchange-CrossTenant-Network-Message-Id: 07f0bb47-47b1-4a4d-ab0f-08dac9814a1c X-MS-Exchange-CrossTenant-AuthSource: SJ0PR13MB6037.namprd13.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Nov 2022 16:23:56.1452 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: fe128f2c-073b-4c20-818e-7246a585940c X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: MiXWiRzILeNrgITI8zGh2i1WZV49TARXj3PWHWqGYAJl+9WLsHJ9Jtm2T11sEYfscuRI3l0Jsmyh8d1bxiUiaz7OxCVIq7z7vf1MEdUGvKA= X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM8PR13MB5110 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org From: Fei Qin When enable TSO, nfp_net_nfdk_tx_tso() fills segment information in Tx descriptor. However, the return path for TSO is lost and the LSO related fields of Tx descriptor is filled with zeros which prevents packets from being sent. This patch fixes the return path in TSO processing function to make sure TSO works fine. Fixes: c73dced48c8c ("net/nfp: add NFDk Tx") Cc: stable@dpdk.org Signed-off-by: Fei Qin Reviewed-by: Niklas Söderlund Reviewed-by: Chaoyong He Signed-off-by: Niklas Söderlund --- drivers/net/nfp/nfp_rxtx.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/net/nfp/nfp_rxtx.c b/drivers/net/nfp/nfp_rxtx.c index 38377ca2182e..01cffdfde0b4 100644 --- a/drivers/net/nfp/nfp_rxtx.c +++ b/drivers/net/nfp/nfp_rxtx.c @@ -1135,6 +1135,8 @@ nfp_net_nfdk_tx_tso(struct nfp_net_txq *txq, struct rte_mbuf *mb) txd.lso_hdrlen = mb->l2_len + mb->l3_len + mb->l4_len; txd.lso_totsegs = (mb->pkt_len + mb->tso_segsz) / mb->tso_segsz; + return txd.raw; + clean_txd: txd.l3_offset = 0; txd.l4_offset = 0;