From patchwork Mon Nov 21 22:32:03 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sinan Kaya X-Patchwork-Id: 120018 Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 42E0AA056D; Mon, 21 Nov 2022 23:32:38 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 92B0742D51; Mon, 21 Nov 2022 23:32:20 +0100 (CET) Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by mails.dpdk.org (Postfix) with ESMTP id ED48F42D43 for ; Mon, 21 Nov 2022 23:32:18 +0100 (CET) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id A9B2EB816A0 for ; Mon, 21 Nov 2022 22:32:18 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id EFE4FC433C1; Mon, 21 Nov 2022 22:32:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1669069937; bh=VjI2Ec8kMto3iRfsRyn5fX9hQQiC6ztV5fVsgiMS9yw=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=j3FCYK6SOCQUwRB4bfaUTeuyAHQ2+4EStrZERW9nGt94/e7J9T84gixuugtREpuT0 s2t7PLUT7W1xcw7Lk1dX3y/7FYnPCJlnQdovkMHoxzXsF9pl6hxurNHsfty+O2vrgH tQdE8Y6jZmG//uBFlJq813wnU899UpSLU5l2vtW9qv+j7SwS8wnxTyTOCwntNYnGWI NXmqPL6zcYmFNEzKq0+Ifb/1wf9aYVyFgd5S4EobzvpvNoakEtiY8nv6pFKN1qOGU2 yKz8EIxbfGpi8lk7IAno5CSTX5jhyQM3SdMDlXcfAgzXf2KNWf6GMN5XlVE/sboHEz PDC090vp37SQg== From: okaya@kernel.org To: dev@dpdk.org Cc: Sinan Kaya Subject: [PATCH v2 04/11] memzone: check result of malloc_elem_from_data Date: Mon, 21 Nov 2022 17:32:03 -0500 Message-Id: <20221121223208.1147154-5-okaya@kernel.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20221121223208.1147154-1-okaya@kernel.org> References: <20221121223208.1147154-1-okaya@kernel.org> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org From: Sinan Kaya In memzone_reserve_aligned_thread_unsafe result of call to malloc_elem_from_data is dereferenced here and may be null. Signed-off-by: Sinan Kaya Acked-by: Dmitry Kozlyuk --- lib/eal/common/eal_common_memzone.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/lib/eal/common/eal_common_memzone.c b/lib/eal/common/eal_common_memzone.c index 8d472505eb..930fee5fdc 100644 --- a/lib/eal/common/eal_common_memzone.c +++ b/lib/eal/common/eal_common_memzone.c @@ -169,6 +169,10 @@ memzone_reserve_aligned_thread_unsafe(const char *name, size_t len, } struct malloc_elem *elem = malloc_elem_from_data(mz_addr); + if (elem == NULL) { + rte_errno = ENOSPC; + return NULL; + } /* fill the zone in config */ mz_idx = rte_fbarray_find_next_free(arr, 0);