From patchwork Mon Nov 21 22:32:05 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sinan Kaya X-Patchwork-Id: 120020 Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id A5ED0A056D; Mon, 21 Nov 2022 23:32:47 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 5869542D5E; Mon, 21 Nov 2022 23:32:22 +0100 (CET) Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by mails.dpdk.org (Postfix) with ESMTP id 4855842D4C for ; Mon, 21 Nov 2022 23:32:20 +0100 (CET) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 1373BB8169E for ; Mon, 21 Nov 2022 22:32:20 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 6550BC43470; Mon, 21 Nov 2022 22:32:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1669069938; bh=OA9aKvIimBSPp+xtTJJVhYWAQ4KuSadN9gXKHvpeV1w=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=kN/9cVBIC1hk4km5gRUX2Caz7u+Hfm/Jg6arg46mWpvASPauwrNUAQd/yICCb7G1o QxpGQA6ww0XMoMTgMkBijG1IO/M+CXTHkz4ev8TjubEzG0VWMTv+VDHkFDmvJe6EMu fmihRepdUjCJ4RqCXSuIfQa/mDyCQ9L0Y0qUNkdJJYj8Y+nDXsKlnJNq2oW3ERa/At hHJr/7MIfux8i8TOv0jn3L0FOB86Ac+DZg3gZSGwEnLvma77eWC8SDjnLlMTXccxWh MOwfGgtdOmz6UCj788G3PxPyFJSsB+vaSgzrgSJMb5Sz830+LrFTta3vj2XyG1WCJ/ SgnavfqmXr1zw== From: okaya@kernel.org To: dev@dpdk.org Cc: Sinan Kaya Subject: [PATCH v2 06/11] malloc: check result of rte_mem_virt2memseg_list Date: Mon, 21 Nov 2022 17:32:05 -0500 Message-Id: <20221121223208.1147154-7-okaya@kernel.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20221121223208.1147154-1-okaya@kernel.org> References: <20221121223208.1147154-1-okaya@kernel.org> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org From: Sinan Kaya In alloc_pages_on_heap result of call to rte_mem_virt2memseg_list is dereferenced here and may be null. Signed-off-by: Sinan Kaya --- lib/eal/common/malloc_heap.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/lib/eal/common/malloc_heap.c b/lib/eal/common/malloc_heap.c index 503e551bf9..3f41430e42 100644 --- a/lib/eal/common/malloc_heap.c +++ b/lib/eal/common/malloc_heap.c @@ -323,6 +323,8 @@ alloc_pages_on_heap(struct malloc_heap *heap, uint64_t pg_sz, size_t elt_size, map_addr = ms[0]->addr; msl = rte_mem_virt2memseg_list(map_addr); + if (msl == NULL) + return NULL; /* check if we wanted contiguous memory but didn't get it */ if (contig && !eal_memalloc_is_contig(msl, map_addr, alloc_sz)) {