diff mbox series

[RESEND,v2,02/11] net/tap: check if name is null

Message ID	20221122153053.1172434-3-okaya@kernel.org (mailing list archive)
State	Superseded, archived
Delegated to:	Ferruh Yigit
Headers	From: okaya@kernel.org To: dev@dpdk.org Cc: Sinan Kaya <okaya@kernel.org> Subject: [PATCH RESEND v2 02/11] net/tap: check if name is null Date: Tue, 22 Nov 2022 10:30:44 -0500 Message-Id: <20221122153053.1172434-3-okaya@kernel.org> In-Reply-To: <20221122153053.1172434-1-okaya@kernel.org> References: <20221122153053.1172434-1-okaya@kernel.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: list Errors-To: dev-bounces@dpdk.org
Series	codeql fixes for various subsystems \| [RESEND,v2,00/11] codeql fixes for various subsystems [RESEND,v2,01/11] ethdev: check return result of rte_eth_dev_info_get [RESEND,v2,02/11] net/tap: check if name is null [RESEND,v2,03/11] memzone: check result of rte_fbarray_get [RESEND,v2,04/11] memzone: check result of malloc_elem_from_data [RESEND,v2,05/11] malloc: malloc_elem_join_adjacent_free can return null [RESEND,v2,06/11] malloc: check result of rte_mem_virt2memseg_list [RESEND,v2,07/11] malloc: check result of rte_fbarray_get [RESEND,v2,08/11] malloc: check result of rte_mem_virt2memseg [RESEND,v2,09/11] malloc: check result of malloc_elem_free [RESEND,v2,10/11] malloc: check result of elem_start_pt [RESEND,v2,11/11] bus/vdev: check result of rte_vdev_device_name

Checks

Context	Check	Description
ci/checkpatch	success	coding style OK

Commit Message

Sinan Kaya Nov. 22, 2022, 3:30 p.m. UTC

  From: Sinan Kaya <okaya@kernel.org>

In rte_pmd_tun_probe result of call to rte_vdev_device_name is
dereferenced here and may be null.

Signed-off-by: Sinan Kaya <okaya@kernel.org>
---
 drivers/net/tap/rte_eth_tap.c | 3 +++
 1 file changed, 3 insertions(+)

Comments

Ferruh Yigit Jan. 18, 2023, 10:57 a.m. UTC | #1

On 11/22/2022 3:30 PM, okaya@kernel.org wrote:
> From: Sinan Kaya <okaya@kernel.org>
> 
> In rte_pmd_tun_probe result of call to rte_vdev_device_name is
> dereferenced here and may be null.
> 
> Signed-off-by: Sinan Kaya <okaya@kernel.org>
> ---
>  drivers/net/tap/rte_eth_tap.c | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/drivers/net/tap/rte_eth_tap.c b/drivers/net/tap/rte_eth_tap.c
> index f2a6c33a19..b99439e4f2 100644
> --- a/drivers/net/tap/rte_eth_tap.c
> +++ b/drivers/net/tap/rte_eth_tap.c
> @@ -2340,6 +2340,9 @@ rte_pmd_tun_probe(struct rte_vdev_device *dev)
>  	struct rte_eth_dev *eth_dev;
>  
>  	name = rte_vdev_device_name(dev);
> +	if (name == NULL)
> +		return -1;
> +
>  	params = rte_vdev_device_args(dev);
>  	memset(remote_iface, 0, RTE_ETH_NAME_MAX_LEN);
>  

Yes, technically 'rte_vdev_device_name()' can return NULL, but call
stack is like this:

`
vdev_probe_all_drivers() //in 'vdev.c'
  name = rte_vdev_device_name(dev);
  if (vdev_parse(name, &driver))
    return -1;
  ret = driver->probe(dev); //it is 'rte_pmd_tun_probe()'
`

I assume this is highlighted by a tool but in practice
'rte_vdev_device_name()' should not return NULL, and there are many
other location this check is missing.

Although it doesn't hurt, I think we can skip the check since it is
unnecessary.

Sinan Kaya Jan. 19, 2023, 5:21 a.m. UTC | #2

On Wed, 2023-01-18 at 10:57 +0000, Ferruh Yigit wrote:
> I assume this is highlighted by a tool but in practice
> 
> 'rte_vdev_device_name()' should not return NULL, and there are many
> 
> other location this check is missing.

That's correct. Warning was found by codeql static analysis tool. When
I search the codebase,
I do see a mixture of null checks and no checks for this function. We
can ignore this patch, if you
feel strongly against it.

diff mbox series

Patch

diff --git a/drivers/net/tap/rte_eth_tap.c b/drivers/net/tap/rte_eth_tap.c
index f2a6c33a19..b99439e4f2 100644
--- a/drivers/net/tap/rte_eth_tap.c
+++ b/drivers/net/tap/rte_eth_tap.c
@@ -2340,6 +2340,9 @@  rte_pmd_tun_probe(struct rte_vdev_device *dev)
 	struct rte_eth_dev *eth_dev;
 
 	name = rte_vdev_device_name(dev);
+	if (name == NULL)
+		return -1;
+
 	params = rte_vdev_device_args(dev);
 	memset(remote_iface, 0, RTE_ETH_NAME_MAX_LEN);