diff mbox series

[RFC,3/4] testpmd: add show lcores command

Message ID 20221123101931.1688238-4-rjarry@redhat.com (mailing list archive)
State Not Applicable, archived
Delegated to: Thomas Monjalon
Headers
Series lcore telemetry improvements |

Checks

Context Check Description
ci/checkpatch success coding style OK

Commit Message

Robin Jarry Nov. 23, 2022, 10:19 a.m. UTC 
  Add a simple command that calls rte_lcore_dump().

Signed-off-by: Robin Jarry <rjarry@redhat.com>
---
 app/test-pmd/cmdline.c | 31 +++++++++++++++++++++++++++++++
 1 file changed, 31 insertions(+)

Comments

Chengwen Feng Nov. 24, 2022, 12:54 a.m. UTC | #1 
Hi Robin,

On 2022/11/23 18:19, Robin Jarry wrote:
> Add a simple command that calls rte_lcore_dump().
> 
> Signed-off-by: Robin Jarry <rjarry@redhat.com>
> ---
>  app/test-pmd/cmdline.c | 31 +++++++++++++++++++++++++++++++
>  1 file changed, 31 insertions(+)
> 
> diff --git a/app/test-pmd/cmdline.c b/app/test-pmd/cmdline.c
> index b32dc8bfd445..d290938ffb4e 100644
> --- a/app/test-pmd/cmdline.c
> +++ b/app/test-pmd/cmdline.c
> @@ -7151,6 +7151,36 @@ static cmdline_parse_inst_t cmd_showfwdall = {
>  	},
>  };
>  
> +/* show lcores */
> +struct lcores_result {
> +	cmdline_fixed_string_t show;
> +	cmdline_fixed_string_t lcores;
> +};
> +
> +static cmdline_parse_token_string_t cmd_lcores_action =
> +	TOKEN_STRING_INITIALIZER(struct lcores_result, show, "show");
> +static cmdline_parse_token_string_t cmd_lcores_lcores =
> +	TOKEN_STRING_INITIALIZER(struct lcores_result, lcores, "lcores");
> +
> +static void
> +cmd_showlcores_parsed(__rte_unused void *parsed_result,
> +		      __rte_unused struct cmdline *cl,
> +		      __rte_unused void *data)
> +{
> +	rte_lcore_dump(stdout);
> +}
> +
> +static cmdline_parse_inst_t cmd_showlcores = {
> +	.f = cmd_showlcores_parsed,
> +	.data = NULL,
> +	.help_str = "show lcores",
> +	.tokens = {
> +		(void *)&cmd_lcores_action,
> +		(void *)&cmd_lcores_lcores,
> +		NULL,
> +	},
> +};

There are many dump_xxx cmd, suggest the commands as dump_lcores:
testpmd> dump_
 dump_physmem [Mul-choice STRING]: Dump status
 dump_memzone [Mul-choice STRING]: Dump status
 dump_socket_mem [Mul-choice STRING]: Dump status
 dump_struct_sizes [Mul-choice STRING]: Dump status
 dump_ring [Mul-choice STRING]: Dump status
 dump_mempool [Mul-choice STRING]: Dump status
 dump_devargs [Mul-choice STRING]: Dump status
 dump_log_types [Mul-choice STRING]: Dump status
 dump_ring [Mul-choice STRING]: dump_ring|dump_mempool <name>: Dump one ring/mempool
 dump_mempool [Mul-choice STRING]: dump_ring|dump_mempool <name>: Dump one ring/mempool

> +
>  /* *** READ A RING DESCRIPTOR OF A PORT RX/TX QUEUE *** */
>  struct cmd_read_rxd_txd_result {
>  	cmdline_fixed_string_t read;
> @@ -12637,6 +12667,7 @@ static cmdline_parse_ctx_t builtin_ctx[] = {
>  	(cmdline_parse_inst_t *)&cmd_showdevice,
>  	(cmdline_parse_inst_t *)&cmd_showcfg,
>  	(cmdline_parse_inst_t *)&cmd_showfwdall,
> +	(cmdline_parse_inst_t *)&cmd_showlcores,
>  	(cmdline_parse_inst_t *)&cmd_start,
>  	(cmdline_parse_inst_t *)&cmd_start_tx_first,
>  	(cmdline_parse_inst_t *)&cmd_start_tx_first_n,
>
diff mbox series

Patch

diff --git a/app/test-pmd/cmdline.c b/app/test-pmd/cmdline.c
index b32dc8bfd445..d290938ffb4e 100644
--- a/app/test-pmd/cmdline.c
+++ b/app/test-pmd/cmdline.c
@@ -7151,6 +7151,36 @@  static cmdline_parse_inst_t cmd_showfwdall = {
 	},
 };
 
+/* show lcores */
+struct lcores_result {
+	cmdline_fixed_string_t show;
+	cmdline_fixed_string_t lcores;
+};
+
+static cmdline_parse_token_string_t cmd_lcores_action =
+	TOKEN_STRING_INITIALIZER(struct lcores_result, show, "show");
+static cmdline_parse_token_string_t cmd_lcores_lcores =
+	TOKEN_STRING_INITIALIZER(struct lcores_result, lcores, "lcores");
+
+static void
+cmd_showlcores_parsed(__rte_unused void *parsed_result,
+		      __rte_unused struct cmdline *cl,
+		      __rte_unused void *data)
+{
+	rte_lcore_dump(stdout);
+}
+
+static cmdline_parse_inst_t cmd_showlcores = {
+	.f = cmd_showlcores_parsed,
+	.data = NULL,
+	.help_str = "show lcores",
+	.tokens = {
+		(void *)&cmd_lcores_action,
+		(void *)&cmd_lcores_lcores,
+		NULL,
+	},
+};
+
 /* *** READ A RING DESCRIPTOR OF A PORT RX/TX QUEUE *** */
 struct cmd_read_rxd_txd_result {
 	cmdline_fixed_string_t read;
@@ -12637,6 +12667,7 @@  static cmdline_parse_ctx_t builtin_ctx[] = {
 	(cmdline_parse_inst_t *)&cmd_showdevice,
 	(cmdline_parse_inst_t *)&cmd_showcfg,
 	(cmdline_parse_inst_t *)&cmd_showfwdall,
+	(cmdline_parse_inst_t *)&cmd_showlcores,
 	(cmdline_parse_inst_t *)&cmd_start,
 	(cmdline_parse_inst_t *)&cmd_start_tx_first,
 	(cmdline_parse_inst_t *)&cmd_start_tx_first_n,