devtools: update Meson setup command

Message ID 20221206101648.1361771-1-thomas@monjalon.net (mailing list archive)
State Accepted, archived
Delegated to: Thomas Monjalon
Headers
Series devtools: update Meson setup command |

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/iol-mellanox-Performance success Performance Testing PASS
ci/iol-intel-Performance success Performance Testing PASS
ci/iol-intel-Functional success Functional Testing PASS
ci/github-robot: build success github build: passed
ci/iol-aarch64-unit-testing success Testing PASS
ci/iol-testing success Testing PASS
ci/iol-x86_64-unit-testing success Testing PASS
ci/iol-x86_64-compile-testing success Testing PASS
ci/iol-aarch64-compile-testing success Testing PASS
ci/Intel-compilation success Compilation OK
ci/intel-Testing success Testing PASS
ci/loongarch-compilation success Compilation OK
ci/loongarch-unit-testing success Unit Testing PASS

Commit Message

Thomas Monjalon Dec. 6, 2022, 10:16 a.m. UTC
  The command "meson build" causes a deprecation warning with meson 0.64:

WARNING: Running the setup command as `meson [options]` instead of
	`meson setup [options]` is ambiguous and deprecated.

Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
---
 .ci/linux-build.sh            | 2 +-
 devtools/test-meson-builds.sh | 4 ++--
 2 files changed, 3 insertions(+), 3 deletions(-)
  

Comments

David Marchand Dec. 6, 2022, 10:27 a.m. UTC | #1
On Tue, Dec 6, 2022 at 11:17 AM Thomas Monjalon <thomas@monjalon.net> wrote:
>
> The command "meson build" causes a deprecation warning with meson 0.64:
>
> WARNING: Running the setup command as `meson [options]` instead of
>         `meson setup [options]` is ambiguous and deprecated.
>
> Signed-off-by: Thomas Monjalon <thomas@monjalon.net>

Reviewed-by: David Marchand <david.marchand@redhat.com>
  
Tyler Retzlaff Dec. 6, 2022, 3:41 p.m. UTC | #2
On Tue, Dec 06, 2022 at 11:16:48AM +0100, Thomas Monjalon wrote:
> The command "meson build" causes a deprecation warning with meson 0.64:
> 
> WARNING: Running the setup command as `meson [options]` instead of
> 	`meson setup [options]` is ambiguous and deprecated.
> 
> Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
> ---

Acked-by: Tyler Retzlaff <roretzla@linux.microsoft.com>
  
Aaron Conole Dec. 7, 2022, 1:25 p.m. UTC | #3
Thomas Monjalon <thomas@monjalon.net> writes:

> The command "meson build" causes a deprecation warning with meson 0.64:
>
> WARNING: Running the setup command as `meson [options]` instead of
> 	`meson setup [options]` is ambiguous and deprecated.
>
> Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
> ---

Acked-by: Aaron Conole <aconole@redhat.com>
  
Thomas Monjalon Dec. 8, 2022, 11:25 a.m. UTC | #4
06/12/2022 11:27, David Marchand:
> On Tue, Dec 6, 2022 at 11:17 AM Thomas Monjalon <thomas@monjalon.net> wrote:
> >
> > The command "meson build" causes a deprecation warning with meson 0.64:
> >
> > WARNING: Running the setup command as `meson [options]` instead of
> >         `meson setup [options]` is ambiguous and deprecated.
> >
> > Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
> 
> Reviewed-by: David Marchand <david.marchand@redhat.com>

Applied
  

Patch

diff --git a/.ci/linux-build.sh b/.ci/linux-build.sh
index baec65a914..5225dc71c4 100755
--- a/.ci/linux-build.sh
+++ b/.ci/linux-build.sh
@@ -163,7 +163,7 @@  if [ "$ABI_CHECKS" = "true" ]; then
     if [ ! -d reference ]; then
         refsrcdir=$(readlink -f $(pwd)/../dpdk-$REF_GIT_TAG)
         git clone --single-branch -b "$REF_GIT_TAG" $REF_GIT_REPO $refsrcdir
-        meson $OPTS -Dexamples= $refsrcdir $refsrcdir/build
+        meson setup $OPTS -Dexamples= $refsrcdir $refsrcdir/build
         ninja -C $refsrcdir/build
         DESTDIR=$(pwd)/reference ninja -C $refsrcdir/build install
         devtools/gen-abi.sh reference
diff --git a/devtools/test-meson-builds.sh b/devtools/test-meson-builds.sh
index 3a308bc9af..7efd5576fc 100755
--- a/devtools/test-meson-builds.sh
+++ b/devtools/test-meson-builds.sh
@@ -124,8 +124,8 @@  config () # <dir> <builddir> <meson options>
 		options="$options -D$option"
 	done
 	options="$options $*"
-	echo "$MESON $options $dir $builddir" >&$verbose
-	$MESON $options $dir $builddir
+	echo "$MESON setup $options $dir $builddir" >&$verbose
+	$MESON setup $options $dir $builddir
 }
 
 compile () # <builddir>