diff mbox series

doc: update recipe for static rdma-core in mlx guides

Message ID 20221208111646.1487459-1-thomas@monjalon.net (mailing list archive)
State Superseded, archived
Delegated to: Raslan Darawsheh
Headers
Series doc: update recipe for static rdma-core in mlx guides |

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/iol-mellanox-Performance success Performance Testing PASS
ci/iol-intel-Functional success Functional Testing PASS
ci/github-robot: build success github build: passed
ci/iol-intel-Performance success Performance Testing PASS
ci/iol-testing fail Testing issues
ci/iol-x86_64-unit-testing fail Testing issues
ci/iol-aarch64-unit-testing success Testing PASS
ci/iol-x86_64-compile-testing success Testing PASS
ci/iol-aarch64-compile-testing success Testing PASS
ci/Intel-compilation success Compilation OK
ci/intel-Testing success Testing PASS
ci/loongarch-compilation success Compilation OK
ci/loongarch-unit-testing success Unit Testing PASS

Commit Message

Thomas Monjalon Dec. 8, 2022, 11:16 a.m. UTC 
  With recent versions of rdma-core, it becomes important to install,
so some non-standard compiler tricks are avoided.

While at it, disabling unneeded pyVerbs and man pages.

Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
---
 doc/guides/nics/mlx4.rst     | 3 ++-
 doc/guides/platform/mlx5.rst | 3 ++-
 2 files changed, 4 insertions(+), 2 deletions(-)

Comments

Bruce Richardson Dec. 8, 2022, 11:33 a.m. UTC | #1 
On Thu, Dec 08, 2022 at 12:16:46PM +0100, Thomas Monjalon wrote:
> With recent versions of rdma-core, it becomes important to install,
> so some non-standard compiler tricks are avoided.
> 
I think this paragraph could do with a bit more explanation in it, e.g. to
clarify that this is (presumably) installing package vs working with it in
build directory.

/Bruce
diff mbox series

Patch

diff --git a/doc/guides/nics/mlx4.rst b/doc/guides/nics/mlx4.rst
index 924ce6f64b..c6279f51d0 100644
--- a/doc/guides/nics/mlx4.rst
+++ b/doc/guides/nics/mlx4.rst
@@ -209,8 +209,9 @@  Current RDMA core package and Linux kernel (recommended)
 - Starting with rdma-core v21, static libraries can be built::
 
     cd build
-    CFLAGS=-fPIC cmake -DIN_PLACE=1 -DENABLE_STATIC=1 -GNinja ..
+    CFLAGS=-fPIC cmake -DENABLE_STATIC=1 -DNO_PYVERBS=1 -DNO_MAN_PAGES=1 -GNinja ..
     ninja
+    ninja install
 
 .. _`RDMA core installation documentation`: https://raw.githubusercontent.com/linux-rdma/rdma-core/master/README.md
 
diff --git a/doc/guides/platform/mlx5.rst b/doc/guides/platform/mlx5.rst
index 3cc1dd29e2..5784b9a87b 100644
--- a/doc/guides/platform/mlx5.rst
+++ b/doc/guides/platform/mlx5.rst
@@ -162,8 +162,9 @@  https://github.com/linux-rdma/rdma-core
 It is possible to build rdma-core as static libraries starting with version 21::
 
     cd build
-    CFLAGS=-fPIC cmake -DIN_PLACE=1 -DENABLE_STATIC=1 -GNinja ..
+    CFLAGS=-fPIC cmake -DENABLE_STATIC=1 -DNO_PYVERBS=1 -DNO_MAN_PAGES=1 -GNinja ..
     ninja
+    ninja install
 
 
 NVIDIA MLNX_OFED/EN