From patchwork Wed Dec 21 07:39:17 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Rongwei Liu X-Patchwork-Id: 121167 X-Patchwork-Delegate: andrew.rybchenko@oktetlabs.ru Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id C723FA034C; Wed, 21 Dec 2022 08:40:33 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 727D942D3B; Wed, 21 Dec 2022 08:40:08 +0100 (CET) Received: from NAM02-BN1-obe.outbound.protection.outlook.com (mail-bn1nam02on2053.outbound.protection.outlook.com [40.107.212.53]) by mails.dpdk.org (Postfix) with ESMTP id 9822742D3D for ; Wed, 21 Dec 2022 08:40:06 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ByVLLZ0KH7d1DRhKkUw4gbgKPmEr18PUNCX/+Wmf+gBGngElA1afnjYHw/SFw2q9zVREszX+WUZI27fTA7s5whELsztlkRBIKVJrwq0JEC2hLRu/0ni6jVyveei3BSF0GhRHCiZRrL3C1oS9Y4Z6+JdE8tIwFB702glJ15GINrAq/666pnJhKiAfQoR2GpXtTzS4bjUVQ/Q5eoqpl5Y+ax4Md79MVnUa7OtIHNdVyOSPmP35wbEPp6KCfJb9wHfRDluTRbMH/ImWz8nJh876RAtyg/CsBb0x9vv8bXov6thZWnVDdskjnvMJMjvIvKgYdQsWAziZ7gVpsodUXka7nw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Z6xAzVtQLkKh0JGeIicYd01kp84eULsGEaMsJfefhL0=; b=FoYF8R26/JeOOPB+wcqgYfYNsFT//cSEVHqQpHdpz4pQpifzsGUcQLy1+xbtgtoYJhBaJjhmlBeh2cFePJVA+D8VQcmoax5/CZG1VAujTwt7hkKug6yknzur+ai5nhIzEfsm56MoVextBp+Hzk7+A8LCtiKlZynv82/7lTtUhjKQ5UwtRJpgkLda9ecji5Vn1IsGWtOkDlOqUZ3AgiSMzY7h2sODsNdqf2WAEY9r+zAmMFeaBLVejsMY+M/pIsVUIMTu7e6NWUepYDIkCSCDhujuXGy8lRW2SAOljKW78p8LNXWxa78idTDcRsXHayqelvSVeton+79ROOsjLA+JuQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.117.161) smtp.rcpttodomain=monjalon.net smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Z6xAzVtQLkKh0JGeIicYd01kp84eULsGEaMsJfefhL0=; b=DwsxdV5zgQsyV8Lw8Fks5Pkb90uH9CTd4xgN0/JBnu597E02OcIn1lySVVi5n+i0uzEIACKGTPK7qvWy83IE3tapQwE3i5/qjC8AzhTdG/TrQ1+djfVmJ2qmFYdALLNGCZVF/OvFuakL+K63l8JoRWQSf76ZKDJcgxEvvhZje3KjF0uo9BudvxHde3xCXuF3ZXL4wXrFGHpO5f1UPSeCPUYsLJR1aVPz4byDjVp5YNrQoN2JVhhG9Rbh7ybcGkEFC8uVfuXp4JFzFeLFJfWUqIO9+PCTuWKlRl0kYaQXLnmLaynLD58BiTpvj2CupcnuRMbqqthE0yIc3OGn+00K0A== Received: from DS7PR03CA0059.namprd03.prod.outlook.com (2603:10b6:5:3b5::34) by DS0PR12MB8245.namprd12.prod.outlook.com (2603:10b6:8:f2::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5924.16; Wed, 21 Dec 2022 07:40:05 +0000 Received: from DM6NAM11FT089.eop-nam11.prod.protection.outlook.com (2603:10b6:5:3b5:cafe::2d) by DS7PR03CA0059.outlook.office365.com (2603:10b6:5:3b5::34) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5924.21 via Frontend Transport; Wed, 21 Dec 2022 07:40:05 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.117.161) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.117.161 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.117.161; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.117.161) by DM6NAM11FT089.mail.protection.outlook.com (10.13.173.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5944.6 via Frontend Transport; Wed, 21 Dec 2022 07:40:05 +0000 Received: from rnnvmail201.nvidia.com (10.129.68.8) by mail.nvidia.com (10.129.200.67) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.36; Tue, 20 Dec 2022 23:39:55 -0800 Received: from nvidia.com (10.126.231.37) by rnnvmail201.nvidia.com (10.129.68.8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.36; Tue, 20 Dec 2022 23:39:53 -0800 From: Rongwei Liu To: , , , CC: , Subject: [RFC 8/9] net/mlx5: return error for sws modify field Date: Wed, 21 Dec 2022 09:39:17 +0200 Message-ID: <20221221073918.3581151-9-rongweil@nvidia.com> X-Mailer: git-send-email 2.27.0 In-Reply-To: <20221221073918.3581151-1-rongweil@nvidia.com> References: <20221221073918.3581151-1-rongweil@nvidia.com> MIME-Version: 1.0 X-Originating-IP: [10.126.231.37] X-ClientProxiedBy: rnnvmail201.nvidia.com (10.129.68.8) To rnnvmail201.nvidia.com (10.129.68.8) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DM6NAM11FT089:EE_|DS0PR12MB8245:EE_ X-MS-Office365-Filtering-Correlation-Id: 20364409-63c7-4535-b0b4-08dae32693b2 X-LD-Processed: 43083d15-7273-40c1-b7db-39efd9ccc17a,ExtAddr X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: SYPpMssKPIS9kA0Tq7ES6bsdbHb1nkFHO1Oy82JlMcoiKMGspTwm53UDwEud3CGQTnMg2ZylGpyzZKHaloNm3e0iGyIoyhf+UqVJJHiwOhB86KnG+J5sLmwTrnDU11Hpwl81sfNP2fP+LUKL3R3nMIqftFXSXRMZBtkQEZAYYMAkW1gK8WXOwk09eWDIo7UOZ2cwHIHtrU7be2VlyJ7V/nA7SOALnScV+W61rOD5rW2VToPyLCBvX5ghNbfR065zSvtraP7oeCyQsEzlqUXJ67ZnprqY7DcJBnOg2NgtACczMjSHyqdFS3CHj777tcawd/vFCMefiTb5p8TOqx9dxA0jSzA8H9XCPrPsJphn199X7inLpl1YjRL/auIXqoYIOgOe4kmgFnlF0WGHAF/Q4rbl8/zkFAWBwNJ+ZX77CLwTRTsA2djl0e+6bDSOVLw8QL88XKPYyhBnVFKQaKT0bwiYCpyxR0nKRI4AJzV/VyaIaWRsT4DNnShXcg7hAEWI0T0/dghd7sqLTb6vzKxZVHatjRd8yjWBawZyO6eJw3DdyKku6d15vXsOpuJwYOoQmse1HY/N9Zdlt4d4zW/qGV//uAt+GOitvXvhZkxaSxoTB27tbP5bsOadwDaVksvYAkw84AqRG7ACO/8h9ONdTsuB2C6ROUH1cCczmX3hY4bA4K8qyszo5Qe2+eBe3czVBzJcR7J9xWSLo//WwTcGVA== X-Forefront-Antispam-Report: CIP:216.228.117.161; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:dc6edge2.nvidia.com; CAT:NONE; SFS:(13230022)(4636009)(396003)(39860400002)(376002)(346002)(136003)(451199015)(40470700004)(46966006)(36840700001)(70206006)(82310400005)(36860700001)(41300700001)(83380400001)(8936002)(356005)(7636003)(70586007)(8676002)(4326008)(5660300002)(16526019)(1076003)(47076005)(336012)(426003)(2616005)(6666004)(107886003)(86362001)(55016003)(36756003)(40480700001)(82740400003)(6286002)(478600001)(40460700003)(186003)(26005)(2906002)(110136005)(54906003)(316002)(7696005); DIR:OUT; SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Dec 2022 07:40:05.1164 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 20364409-63c7-4535-b0b4-08dae32693b2 X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.117.161]; Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: DM6NAM11FT089.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS0PR12MB8245 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Return unsupported error message when application tries to modify flex item field. Signed-off-by: Rongwei Liu --- drivers/net/mlx5/mlx5_flow_dv.c | 19 +++++++++++++------ 1 file changed, 13 insertions(+), 6 deletions(-) diff --git a/drivers/net/mlx5/mlx5_flow_dv.c b/drivers/net/mlx5/mlx5_flow_dv.c index 501a190c5e..f09648d85f 100644 --- a/drivers/net/mlx5/mlx5_flow_dv.c +++ b/drivers/net/mlx5/mlx5_flow_dv.c @@ -4947,6 +4947,8 @@ flow_dv_validate_action_modify_hdr(const uint64_t action_flags, const struct rte_flow_action *action, struct rte_flow_error *error) { + const struct rte_flow_action_modify_field *action_modify_field = action->conf; + if (action->type != RTE_FLOW_ACTION_TYPE_DEC_TTL && action->type != RTE_FLOW_ACTION_TYPE_DEC_IPV4_TTL && action->type != RTE_FLOW_ACTION_TYPE_DEC_IPV6_HOP && @@ -4954,6 +4956,12 @@ flow_dv_validate_action_modify_hdr(const uint64_t action_flags, return rte_flow_error_set(error, EINVAL, RTE_FLOW_ERROR_TYPE_ACTION_CONF, NULL, "action configuration not set"); + if (action_modify_field->src.field == RTE_FLOW_FIELD_FLEX_ITEM || + action_modify_field->dst.field == RTE_FLOW_FIELD_FLEX_ITEM) + return rte_flow_error_set(error, ENOTSUP, + RTE_FLOW_ERROR_TYPE_ACTION, action, + "flex item fields modification" + " is not supported"); if (action_flags & MLX5_FLOW_ACTION_ENCAP) return rte_flow_error_set(error, EINVAL, RTE_FLOW_ERROR_TYPE_ACTION, NULL, @@ -5371,17 +5379,16 @@ flow_dv_validate_action_modify_field(struct rte_eth_dev *dev, struct mlx5_hca_attr *hca_attr = &priv->sh->cdev->config.hca_attr; const struct rte_flow_action_modify_field *action_modify_field = action->conf; - uint32_t dst_width = mlx5_flow_item_field_width(dev, - action_modify_field->dst.field, - -1, attr, error); - uint32_t src_width = mlx5_flow_item_field_width(dev, - action_modify_field->src.field, - dst_width, attr, error); + uint32_t dst_width, src_width; ret = flow_dv_validate_action_modify_hdr(action_flags, action, error); if (ret) return ret; + dst_width = mlx5_flow_item_field_width(dev, action_modify_field->dst.field, + -1, attr, error); + src_width = mlx5_flow_item_field_width(dev, action_modify_field->src.field, + dst_width, attr, error); if (action_modify_field->width == 0) return rte_flow_error_set(error, EINVAL, RTE_FLOW_ERROR_TYPE_ACTION, action,