diff mbox series

cryptodev: increase default max nb queue pairs

Message ID 20230104073021.1039-1-anoobj@marvell.com (mailing list archive)
State Changes Requested, archived
Delegated to: akhil goyal
Headers
Series cryptodev: increase default max nb queue pairs |

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/loongarch-compilation success Compilation OK
ci/loongarch-unit-testing success Unit Testing PASS
ci/github-robot: build success github build: passed
ci/iol-broadcom-Performance success Performance Testing PASS
ci/iol-intel-Functional success Functional Testing PASS
ci/iol-intel-Performance success Performance Testing PASS
ci/iol-aarch64-unit-testing success Testing PASS
ci/iol-testing success Testing PASS
ci/iol-x86_64-unit-testing success Testing PASS
ci/Intel-compilation success Compilation OK
ci/intel-Testing success Testing PASS
ci/iol-x86_64-compile-testing success Testing PASS
ci/iol-aarch64-compile-testing success Testing PASS
ci/iol-abi-testing success Testing PASS

Commit Message

Anoob Joseph Jan. 4, 2023, 7:30 a.m. UTC 
  Increase default maximum number of queue pairs to 64. For sw crypto
PMDs, the number of queue pairs can be increased as required. The
default value (which is set to 8), prevents usage of sw cryptodev PMDs
with larger number of cores.

Application would be allowed to specify the number of queue pairs it
wishes to use. Only the upper bound is changed from 8 to 64.

Allow PMDs such as crypto_armv8 to run on larger number of cores.

Signed-off-by: Anoob Joseph <anoobj@marvell.com>
---
 lib/cryptodev/cryptodev_pmd.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Zhang, Fan Jan. 4, 2023, 10:58 a.m. UTC | #1 
On 1/4/2023 7:30 AM, Anoob Joseph wrote:
> Increase default maximum number of queue pairs to 64. For sw crypto
> PMDs, the number of queue pairs can be increased as required. The
> default value (which is set to 8), prevents usage of sw cryptodev PMDs
> with larger number of cores.
>
> Application would be allowed to specify the number of queue pairs it
> wishes to use. Only the upper bound is changed from 8 to 64.
>
> Allow PMDs such as crypto_armv8 to run on larger number of cores.
>
> Signed-off-by: Anoob Joseph <anoobj@marvell.com>
> ---
>   lib/cryptodev/cryptodev_pmd.h | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/lib/cryptodev/cryptodev_pmd.h b/lib/cryptodev/cryptodev_pmd.h
> index 0020102eb7..913a8f3623 100644
> --- a/lib/cryptodev/cryptodev_pmd.h
> +++ b/lib/cryptodev/cryptodev_pmd.h
> @@ -29,7 +29,7 @@ extern "C" {
>   #include "rte_cryptodev.h"
>   
>   
> -#define RTE_CRYPTODEV_PMD_DEFAULT_MAX_NB_QUEUE_PAIRS	8
> +#define RTE_CRYPTODEV_PMD_DEFAULT_MAX_NB_QUEUE_PAIRS	64
>   
>   #define RTE_CRYPTODEV_PMD_NAME_ARG			("name")
>   #define RTE_CRYPTODEV_PMD_MAX_NB_QP_ARG			("max_nb_queue_pairs")
Acked-by: Fan Zhang <fanzhang.oss@gmail.com>
Ruifeng Wang Jan. 10, 2023, 6:41 a.m. UTC | #2 
> -----Original Message-----
> From: Anoob Joseph <anoobj@marvell.com>
> Sent: Wednesday, January 4, 2023 3:30 PM
> To: Akhil Goyal <gakhil@marvell.com>; Ruifeng Wang <Ruifeng.Wang@arm.com>; Gagandeep Singh
> <g.singh@nxp.com>; hemant.agrawal@nxp.com; Kai Ji <kai.ji@intel.com>; Pablo de Lara
> <pablo.de.lara.guarch@intel.com>; Matan Azrad <matan@nvidia.com>; Zhangfei Gao
> <zhangfei.gao@linaro.org>; Fan Zhang <fanzhang.oss@gmail.com>
> Cc: Ashwin Sekhar T K <asekhar@marvell.com>; jerinj@marvell.com; dev@dpdk.org
> Subject: [PATCH] cryptodev: increase default max nb queue pairs
> 
> Increase default maximum number of queue pairs to 64. For sw crypto PMDs, the number of
> queue pairs can be increased as required. The default value (which is set to 8), prevents
> usage of sw cryptodev PMDs with larger number of cores.
> 
> Application would be allowed to specify the number of queue pairs it wishes to use. Only
> the upper bound is changed from 8 to 64.
> 
> Allow PMDs such as crypto_armv8 to run on larger number of cores.
> 
> Signed-off-by: Anoob Joseph <anoobj@marvell.com>
> ---
>  lib/cryptodev/cryptodev_pmd.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/lib/cryptodev/cryptodev_pmd.h b/lib/cryptodev/cryptodev_pmd.h index
> 0020102eb7..913a8f3623 100644
> --- a/lib/cryptodev/cryptodev_pmd.h
> +++ b/lib/cryptodev/cryptodev_pmd.h
> @@ -29,7 +29,7 @@ extern "C" {
>  #include "rte_cryptodev.h"
> 
> 
> -#define RTE_CRYPTODEV_PMD_DEFAULT_MAX_NB_QUEUE_PAIRS	8
> +#define RTE_CRYPTODEV_PMD_DEFAULT_MAX_NB_QUEUE_PAIRS	64
> 
>  #define RTE_CRYPTODEV_PMD_NAME_ARG			("name")
>  #define RTE_CRYPTODEV_PMD_MAX_NB_QP_ARG			("max_nb_queue_pairs")

Crypto device has devargs "max_nb_queue_pairs" which can be used to change queue pairs limit at init time.
Then no need to increase the default value?

> --
> 2.25.1
Anoob Joseph Jan. 10, 2023, 7:07 a.m. UTC | #3 
Hi Ruifeng,

> Crypto device has devargs "max_nb_queue_pairs" which can be used to change
> queue pairs limit at init time.
> Then no need to increase the default value?

Yes. Thanks for the pointer. This field would suffice for the issue that I'm trying to fix.

Thanks,
Anoob

> -----Original Message-----
> From: Ruifeng Wang <Ruifeng.Wang@arm.com>
> Sent: Tuesday, January 10, 2023 12:12 PM
> To: Anoob Joseph <anoobj@marvell.com>; Akhil Goyal <gakhil@marvell.com>;
> Gagandeep Singh <g.singh@nxp.com>; hemant.agrawal@nxp.com; Kai Ji
> <kai.ji@intel.com>; Pablo de Lara <pablo.de.lara.guarch@intel.com>; Matan
> Azrad <matan@nvidia.com>; Zhangfei Gao <zhangfei.gao@linaro.org>; Fan
> Zhang <fanzhang.oss@gmail.com>
> Cc: Ashwin Sekhar T K <asekhar@marvell.com>; Jerin Jacob Kollanukkaran
> <jerinj@marvell.com>; dev@dpdk.org; nd <nd@arm.com>
> Subject: [EXT] RE: [PATCH] cryptodev: increase default max nb queue pairs
> 
> External Email
> 
> ----------------------------------------------------------------------
> > -----Original Message-----
> > From: Anoob Joseph <anoobj@marvell.com>
> > Sent: Wednesday, January 4, 2023 3:30 PM
> > To: Akhil Goyal <gakhil@marvell.com>; Ruifeng Wang
> > <Ruifeng.Wang@arm.com>; Gagandeep Singh <g.singh@nxp.com>;
> > hemant.agrawal@nxp.com; Kai Ji <kai.ji@intel.com>; Pablo de Lara
> > <pablo.de.lara.guarch@intel.com>; Matan Azrad <matan@nvidia.com>;
> > Zhangfei Gao <zhangfei.gao@linaro.org>; Fan Zhang
> > <fanzhang.oss@gmail.com>
> > Cc: Ashwin Sekhar T K <asekhar@marvell.com>; jerinj@marvell.com;
> > dev@dpdk.org
> > Subject: [PATCH] cryptodev: increase default max nb queue pairs
> >
> > Increase default maximum number of queue pairs to 64. For sw crypto
> > PMDs, the number of queue pairs can be increased as required. The
> > default value (which is set to 8), prevents usage of sw cryptodev PMDs with
> larger number of cores.
> >
> > Application would be allowed to specify the number of queue pairs it
> > wishes to use. Only the upper bound is changed from 8 to 64.
> >
> > Allow PMDs such as crypto_armv8 to run on larger number of cores.
> >
> > Signed-off-by: Anoob Joseph <anoobj@marvell.com>
> > ---
> >  lib/cryptodev/cryptodev_pmd.h | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/lib/cryptodev/cryptodev_pmd.h
> > b/lib/cryptodev/cryptodev_pmd.h index
> > 0020102eb7..913a8f3623 100644
> > --- a/lib/cryptodev/cryptodev_pmd.h
> > +++ b/lib/cryptodev/cryptodev_pmd.h
> > @@ -29,7 +29,7 @@ extern "C" {
> >  #include "rte_cryptodev.h"
> >
> >
> > -#define RTE_CRYPTODEV_PMD_DEFAULT_MAX_NB_QUEUE_PAIRS	8
> > +#define RTE_CRYPTODEV_PMD_DEFAULT_MAX_NB_QUEUE_PAIRS	64
> >
> >  #define RTE_CRYPTODEV_PMD_NAME_ARG			("name")
> >  #define RTE_CRYPTODEV_PMD_MAX_NB_QP_ARG
> 	("max_nb_queue_pairs")
> 
> Crypto device has devargs "max_nb_queue_pairs" which can be used to change
> queue pairs limit at init time.
> Then no need to increase the default value?
> 
> > --
> > 2.25.1
diff mbox series

Patch

diff --git a/lib/cryptodev/cryptodev_pmd.h b/lib/cryptodev/cryptodev_pmd.h
index 0020102eb7..913a8f3623 100644
--- a/lib/cryptodev/cryptodev_pmd.h
+++ b/lib/cryptodev/cryptodev_pmd.h
@@ -29,7 +29,7 @@  extern "C" {
 #include "rte_cryptodev.h"
 
 
-#define RTE_CRYPTODEV_PMD_DEFAULT_MAX_NB_QUEUE_PAIRS	8
+#define RTE_CRYPTODEV_PMD_DEFAULT_MAX_NB_QUEUE_PAIRS	64
 
 #define RTE_CRYPTODEV_PMD_NAME_ARG			("name")
 #define RTE_CRYPTODEV_PMD_MAX_NB_QP_ARG			("max_nb_queue_pairs")