From patchwork Wed Jan 4 07:40:51 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Alvaro Karsz X-Patchwork-Id: 121567 X-Patchwork-Delegate: david.marchand@redhat.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 312F0A00C2; Wed, 4 Jan 2023 08:41:00 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 26E6B4282D; Wed, 4 Jan 2023 08:41:00 +0100 (CET) Received: from mail-wm1-f46.google.com (mail-wm1-f46.google.com [209.85.128.46]) by mails.dpdk.org (Postfix) with ESMTP id 12EC640697 for ; Wed, 4 Jan 2023 08:40:59 +0100 (CET) Received: by mail-wm1-f46.google.com with SMTP id c65-20020a1c3544000000b003cfffd00fc0so28870663wma.1 for ; Tue, 03 Jan 2023 23:40:59 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=solid-run-com.20210112.gappssmtp.com; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=CUx2JXComzvyLPdM3DMElxTdrpqJLEDuGvJ5wKA9ebA=; b=Y3H4tssmh1UyMREBq1+C1nCSP+9AmTAtYhUzZdqkw0WsMzTaO3Z33hLfLgx+eSrqMU aS2vPHWUStMPjzjaL5wVRPosLRZ/yU8jdMiHG9SMJ6pZaNiOe3uaUuQdUmrJgoIx7QlU RVsfo78PLNPNUveGWucsJ4QHbuCtRp2ml9Qcy5/tum2nFcbR5F/x7Q0W9gGI8+WWOcWv YyrJBd1nN9Zy+IFRJTX8tk3mlN5dKhxSHoaX7SRjmCR/l7lP+IS1/jeDJe+TkApZYUL/ IiLHCGVfujHCUL6MLb8c/b41yOwtVb/Ts3wFUlM/kBr4eRDVci+BD/Xc5BkP64V0s1eH ClEw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=CUx2JXComzvyLPdM3DMElxTdrpqJLEDuGvJ5wKA9ebA=; b=6iEnuN5Q7Zi+/yCmTmQXxT9us+UWC5NXOQ2NMc2xcAuXa0fF2PZuGPWovrWQSk259v dPduqLcKLxXRIv2KykwMgB6u9h0wx6GCNi5Em0auLX7scXIUpsnnrMsA1xxy7vG4+9// mUhsUvRh+809+kfFJrTPqrarGFZjK6p31CDC9Ieyy0oVUhDuP+9CiYTND9r7yeLFXetN iJjzMlg9e2ygHy4q64/xSeHA3Wxu6n6/6SAt/1MC19tuQYXfYy0NTmVCnDKtpMjgLyRC snwsLBEzsMgqDKtO+xrqG4jk2lYnMqWYlMCa6DVLhQWgBZmWD/8h1ZaZGwFLnK1Ar9re +tzw== X-Gm-Message-State: AFqh2kpQYhKauD0zRgHAP3kzLlpsaSEf805+LNx+PrDA7NekUZ4IsYo1 uB44ghFHwAeteq30txPY4WWbjKgu1Y4stsDib2E= X-Google-Smtp-Source: AMrXdXuIN0f5f8eQqFLchI7pRfj7ua7AjkqKIZRqJjlnVwYyJrT/MtAYWu0j3PUC6/38bZtU/GFbMA== X-Received: by 2002:a05:600c:5c8:b0:3d1:4145:b3b with SMTP id p8-20020a05600c05c800b003d141450b3bmr34004650wmd.9.1672818057810; Tue, 03 Jan 2023 23:40:57 -0800 (PST) Received: from localhost.localdomain (bzq-84-110-153-254.static-ip.bezeqint.net. [84.110.153.254]) by smtp.gmail.com with ESMTPSA id j34-20020a05600c1c2200b003d98438a43asm35814660wms.34.2023.01.03.23.40.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 03 Jan 2023 23:40:56 -0800 (PST) From: Alvaro Karsz To: dev@dpdk.org Cc: sachin.saxena@oss.nxp.com, hemant.agrawal@nxp.com, david.marchand@redhat.com, stable@dpdk.org, Alvaro Karsz Subject: [PATCH v3] bus/fslmc: unlock spinlock in case of timeout Date: Wed, 4 Jan 2023 09:40:51 +0200 Message-Id: <20230104074051.3420378-1-alvaro.karsz@solid-run.com> X-Mailer: git-send-email 2.32.0 MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Bug in function mc_send_command, A spinlock is not unlocked in case of timeouts. Fixes: 79711846f676 ("bus/fslmc: add timeout in MC send command") Cc: stable@dpdk.org Signed-off-by: Alvaro Karsz Reviewed-by: David Marchand --- v2: - Fix code indentation. - Fix "Fixes: " tag format. v3: - Remove unnecessary comment. - cc stable@dpdk.org --- drivers/bus/fslmc/mc/mc_sys.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/bus/fslmc/mc/mc_sys.c b/drivers/bus/fslmc/mc/mc_sys.c index ab9a074835..76fdcd5c8a 100644 --- a/drivers/bus/fslmc/mc/mc_sys.c +++ b/drivers/bus/fslmc/mc/mc_sys.c @@ -77,8 +77,11 @@ int mc_send_command(struct fsl_mc_io *mc_io, struct mc_command *cmd) total_time = rte_get_timer_cycles() - start_time; } while (status == MC_CMD_STATUS_READY && total_time <= time_to_wait); - if (status == MC_CMD_STATUS_READY) + if (status == MC_CMD_STATUS_READY) { + rte_spinlock_unlock(&mc_portal_lock); + return mc_status_to_error(MC_CMD_STATUS_TIMEOUT); + } /* Read the response back into the command buffer */ mc_read_response(mc_io->regs, cmd);