crypto/qat: fix build for generic x86 with GCC 12
Checks
Commit Message
Similar to commit 04361fe2aca8 ("crypto/qat: fix build with GCC 12").
The issue appears when building with the "generic" target we have in
devtools/test-meson-builds.sh.
Fixes: 3227bc7138f5 ("crypto/qat: use intel-ipsec-mb for partial hash and AES")
Cc: stable@dpdk.org
Signed-off-by: David Marchand <david.marchand@redhat.com>
---
drivers/crypto/qat/qat_sym_session.c | 2 ++
1 file changed, 2 insertions(+)
Comments
On Mon, Jan 09, 2023 at 11:34:36AM +0100, David Marchand wrote:
> Similar to commit 04361fe2aca8 ("crypto/qat: fix build with GCC 12").
> The issue appears when building with the "generic" target we have in
> devtools/test-meson-builds.sh.
>
> Fixes: 3227bc7138f5 ("crypto/qat: use intel-ipsec-mb for partial hash and AES")
> Cc: stable@dpdk.org
>
> Signed-off-by: David Marchand <david.marchand@redhat.com>
> ---
> drivers/crypto/qat/qat_sym_session.c | 2 ++
> 1 file changed, 2 insertions(+)
>
Confirm that this fixes the build issue.
Tested-by: Bruce Richardson <bruce.richardson@intel.com>
On Tue, Jan 10, 2023 at 12:27 PM Bruce Richardson
<bruce.richardson@intel.com> wrote:
>
> On Mon, Jan 09, 2023 at 11:34:36AM +0100, David Marchand wrote:
> > Similar to commit 04361fe2aca8 ("crypto/qat: fix build with GCC 12").
> > The issue appears when building with the "generic" target we have in
> > devtools/test-meson-builds.sh.
> >
> > Fixes: 3227bc7138f5 ("crypto/qat: use intel-ipsec-mb for partial hash and AES")
> > Cc: stable@dpdk.org
> >
> > Signed-off-by: David Marchand <david.marchand@redhat.com>
> > ---
> > drivers/crypto/qat/qat_sym_session.c | 2 ++
> > 1 file changed, 2 insertions(+)
> >
> Confirm that this fixes the build issue.
>
> Tested-by: Bruce Richardson <bruce.richardson@intel.com>
>
No objection from maintainer, Akhil, can you take this to next-crypto?
Thanks.
> On Tue, Jan 10, 2023 at 12:27 PM Bruce Richardson
> <bruce.richardson@intel.com> wrote:
> >
> > On Mon, Jan 09, 2023 at 11:34:36AM +0100, David Marchand wrote:
> > > Similar to commit 04361fe2aca8 ("crypto/qat: fix build with GCC 12").
> > > The issue appears when building with the "generic" target we have in
> > > devtools/test-meson-builds.sh.
> > >
> > > Fixes: 3227bc7138f5 ("crypto/qat: use intel-ipsec-mb for partial hash and
> AES")
> > > Cc: stable@dpdk.org
> > >
> > > Signed-off-by: David Marchand <david.marchand@redhat.com>
> > > ---
> > > drivers/crypto/qat/qat_sym_session.c | 2 ++
> > > 1 file changed, 2 insertions(+)
> > >
> > Confirm that this fixes the build issue.
> >
> > Tested-by: Bruce Richardson <bruce.richardson@intel.com>
> >
>
> No objection from maintainer, Akhil, can you take this to next-crypto?
Sure, will merge today/tomorrow.
On Tue, Jan 17, 2023 at 08:20:48AM +0000, Akhil Goyal wrote:
> > On Tue, Jan 10, 2023 at 12:27 PM Bruce Richardson
> > <bruce.richardson@intel.com> wrote:
> > >
> > > On Mon, Jan 09, 2023 at 11:34:36AM +0100, David Marchand wrote:
> > > > Similar to commit 04361fe2aca8 ("crypto/qat: fix build with GCC 12").
> > > > The issue appears when building with the "generic" target we have in
> > > > devtools/test-meson-builds.sh.
> > > >
> > > > Fixes: 3227bc7138f5 ("crypto/qat: use intel-ipsec-mb for partial hash and
> > AES")
> > > > Cc: stable@dpdk.org
> > > >
> > > > Signed-off-by: David Marchand <david.marchand@redhat.com>
> > > > ---
> > > > drivers/crypto/qat/qat_sym_session.c | 2 ++
> > > > 1 file changed, 2 insertions(+)
> > > >
> > > Confirm that this fixes the build issue.
> > >
> > > Tested-by: Bruce Richardson <bruce.richardson@intel.com>
> > >
> >
> > No objection from maintainer, Akhil, can you take this to next-crypto?
> Sure, will merge today/tomorrow.
Once merged into crypto can it be quickly pulled into the main tree, as the
build error is also seen there? I think build issues should generally be
fixed directly on main, as they affect those not working in the particular
subtree area.
> -----Original Message-----
> From: Bruce Richardson <bruce.richardson@intel.com>
> Sent: Tuesday, January 17, 2023 2:33 PM
> To: Akhil Goyal <gakhil@marvell.com>
> Cc: David Marchand <david.marchand@redhat.com>; Kai Ji <kai.ji@intel.com>;
> dev@dpdk.org; stable@dpdk.org; Ciara Power <ciara.power@intel.com>; Fan
> Zhang <fanzhang.oss@gmail.com>
> Subject: Re: [EXT] Re: [PATCH] crypto/qat: fix build for generic x86 with GCC 12
>
> On Tue, Jan 17, 2023 at 08:20:48AM +0000, Akhil Goyal wrote:
> > > On Tue, Jan 10, 2023 at 12:27 PM Bruce Richardson
> > > <bruce.richardson@intel.com> wrote:
> > > >
> > > > On Mon, Jan 09, 2023 at 11:34:36AM +0100, David Marchand wrote:
> > > > > Similar to commit 04361fe2aca8 ("crypto/qat: fix build with GCC 12").
> > > > > The issue appears when building with the "generic" target we have in
> > > > > devtools/test-meson-builds.sh.
> > > > >
> > > > > Fixes: 3227bc7138f5 ("crypto/qat: use intel-ipsec-mb for partial hash and
> > > AES")
> > > > > Cc: stable@dpdk.org
> > > > >
> > > > > Signed-off-by: David Marchand <david.marchand@redhat.com>
> > > > > ---
> > > > > drivers/crypto/qat/qat_sym_session.c | 2 ++
> > > > > 1 file changed, 2 insertions(+)
> > > > >
> > > > Confirm that this fixes the build issue.
> > > >
> > > > Tested-by: Bruce Richardson <bruce.richardson@intel.com>
> > > >
> > >
> > > No objection from maintainer, Akhil, can you take this to next-crypto?
> > Sure, will merge today/tomorrow.
>
> Once merged into crypto can it be quickly pulled into the main tree, as the
> build error is also seen there? I think build issues should generally be
> fixed directly on main, as they affect those not working in the particular
> subtree area.
Applied to dpdk-next-crypto
Thomas can pick the tree with qat fixes.
Thanks.
@@ -1331,6 +1331,8 @@ static int qat_sym_do_precomputes_ipsec_mb(enum icp_qat_hw_auth_algo hash_alg,
/* init ipad and opad from key and xor with fixed values */
memset(ipad, 0, block_size);
memset(opad, 0, block_size);
+ RTE_VERIFY(auth_keylen <= sizeof(ipad));
+ RTE_VERIFY(auth_keylen <= sizeof(opad));
rte_memcpy(ipad, auth_key, auth_keylen);
rte_memcpy(opad, auth_key, auth_keylen);