From patchwork Fri Jan 13 18:44:25 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephen Hemminger X-Patchwork-Id: 122041 X-Patchwork-Delegate: gakhil@marvell.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 5DF074238D; Fri, 13 Jan 2023 19:44:31 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id F15DF410EF; Fri, 13 Jan 2023 19:44:30 +0100 (CET) Received: from mail-pg1-f173.google.com (mail-pg1-f173.google.com [209.85.215.173]) by mails.dpdk.org (Postfix) with ESMTP id B629640E03 for ; Fri, 13 Jan 2023 19:44:29 +0100 (CET) Received: by mail-pg1-f173.google.com with SMTP id d10so15550097pgm.13 for ; Fri, 13 Jan 2023 10:44:29 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20210112.gappssmtp.com; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=VY+BD4jBhavoDXnvDGQ9WeMQ092uSDxMzVdjLfgY0xs=; b=GwtvyPdehPUVaS7bFGcmzH3M+Uihp/a5TwfXv7Clhwp1nqDugvUlZA4qziyIB5pflm JDNAxNUCASDvrY2sIz5pcLFxRK0QpPklzekeDSII5z8cSnU44Vh0KADHXCV1X90wqBwq /wXN+lyFTfVdxYWDAqhy2cjlbzHMDkq98voU9/J9uOazMiJb2WEw9NQRawxhGMGlWG23 k9w0NiOBwBQ6mNCNrcEq3pu3nm/ntYMcvWN7q7qPK+kJaIqOu98UTpF1R0mBrfsU0KMF PnmkoLh+sFaDha0cPdr5xiUGl40m0xqAmEUlJyyOrhZ7SROMfAAdlTQZw65Aiy+J7YEF hJbA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=VY+BD4jBhavoDXnvDGQ9WeMQ092uSDxMzVdjLfgY0xs=; b=oC1nkbqCAyYkafuwY1Tof6m6gLZEJokDRp+SGMp21aX9jgYBCIGRpDIzIXqnXVR4ND IywoY48zClsPvmntwEtU61yHKoDPOjmxq+lNTqWmO/MzqFoCr9sy5yYOtVSbXXWupLRX OVUFKZpHcX/Dw34y4EA3Zbm7/5sm1JaJ4X3vB4dQ+pTR2dJJqytTOQPkYzZYpeTH7LEK SkQ5S77FcesLlBpLKlY8mkoZPsyK9F9pxEEeWfurqN7KePqJ1wTmOsYKo4Ks5k8+QUVK TifcVWHDpg1vodvnN837+yyuDVE32iVXChF5zcrt4gCUy4bDgJ8R+2M/TowD0zf24wMi K1IA== X-Gm-Message-State: AFqh2korIldc6Nkxp+cbssv9IGJPzksWdTIuzgL0dWl/q7bQyF6uaBIS gyHM5jJFV7SHKcaR5FPl/Dr9TlIt5hQgzZwO18M= X-Google-Smtp-Source: AMrXdXuUA9i3wGrViXVSJMIadFH8kplRM17jEfUeD8uRhoa9ITz4aMt6q+ecIZmRWsrc4Q6w+tWjFQ== X-Received: by 2002:a05:6a00:27a9:b0:587:8450:997e with SMTP id bd41-20020a056a0027a900b005878450997emr10799891pfb.22.1673635468435; Fri, 13 Jan 2023 10:44:28 -0800 (PST) Received: from hermes.local (204-195-120-218.wavecable.com. [204.195.120.218]) by smtp.gmail.com with ESMTPSA id 130-20020a621788000000b00587fda4a260sm10597300pfx.9.2023.01.13.10.44.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 13 Jan 2023 10:44:28 -0800 (PST) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger , kai.ji@intel.com, Pablo de Lara , Ciara Power Subject: [PATCH] ipsec: remove unneccessary null check Date: Fri, 13 Jan 2023 10:44:25 -0800 Message-Id: <20230113184426.68063-1-stephen@networkplumber.org> X-Mailer: git-send-email 2.39.0 MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org The function rte_ring_free() accepts NULL as vaild input like free() and other functions. Found with null_free_check.cocci. Fixes: 16d6ebb65d59 ("crypto/ipsec_mb: fix null checks") Cc: kai.ji@intel.com Signed-off-by: Stephen Hemminger Acked-by: Tyler Retzlaff Acked-by: Fan Zhang Acked-by: Kai Ji --- drivers/crypto/ipsec_mb/ipsec_mb_ops.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/drivers/crypto/ipsec_mb/ipsec_mb_ops.c b/drivers/crypto/ipsec_mb/ipsec_mb_ops.c index 71e02cd0513d..3e52f9567401 100644 --- a/drivers/crypto/ipsec_mb/ipsec_mb_ops.c +++ b/drivers/crypto/ipsec_mb/ipsec_mb_ops.c @@ -139,15 +139,12 @@ int ipsec_mb_qp_release(struct rte_cryptodev *dev, uint16_t qp_id) { struct ipsec_mb_qp *qp = dev->data->queue_pairs[qp_id]; - struct rte_ring *r = NULL; if (!qp) return 0; if (rte_eal_process_type() == RTE_PROC_PRIMARY) { - r = rte_ring_lookup(qp->name); - if (r) - rte_ring_free(r); + rte_ring_free(rte_ring_lookup(qp->name)); #if IMB_VERSION(1, 1, 0) > IMB_VERSION_NUM if (qp->mb_mgr)