From patchwork Sat Jan 28 13:08:56 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jiawei Wang X-Patchwork-Id: 122613 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 8423B424AA; Sat, 28 Jan 2023 14:09:30 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 0872B40A82; Sat, 28 Jan 2023 14:09:28 +0100 (CET) Received: from NAM04-MW2-obe.outbound.protection.outlook.com (mail-mw2nam04on2074.outbound.protection.outlook.com [40.107.101.74]) by mails.dpdk.org (Postfix) with ESMTP id 697304068E for ; Sat, 28 Jan 2023 14:09:26 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=N8/Jpa6qOElGElQB+r3CaKUWQPZylZ+CaLc8VeAn9VnHcKfr1irLXqBJKdbsdwJCjeSBGibYAGwvlMhfv+8DvXi5FMZhtVoKZQ8xkQ8o3jvywzMFJNSQf2xJHqto3kt+Atd+YMFrRnLba3ncNnqjQPc90DCzXWDE5S40n3AYvTjxOo/SMUsUcig8wJYH5uPXLlhTlKOwZV2UmNIopLiAaCjhvNgIz/D9CJ9xYJgNUBeXc1b2rBXNgDXf2CiK4+MY8MZX+wwPN7A7G7e8ezlVyFHZoDd6uHNGnZsb1HLPm1pKSXrE6OweSE0l4yQY9iIhkWpDgTU574hHYBJrtLtaxg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Sdcy+b33zqPwYyFI33Ya73btsy1CySRcqnSEU8aC8Wg=; b=K8x2dlwzaqIPYiTWiGJebxK4T9dI0Qt7gBfNw0WuXfp2fYNJexhw/MbyBpRzTLkJQ0QMM+6yhxLWbQq3VQrrcAY/oRPJnquP4cpoZE1EAYJsvXEsFLbbwauaDu7fTegar5XhZFZxNIrXw4GzDnuASmOQDcrbepplYJjFUUzrHkvBA2sKpJNMGYoqjT8iSqNJI29xNDkEcztMMWSb/ETHRulqo6UPqJKxQPhdWxAzeazRaHZ06fPGmcGHVBvnyNSYLxxOUouebtcYbctfpD8GDYeHZf8uZVW8S9nWg/31A8hXFPjAXDil/jxKqZ+RbxBJzFUUZkh/43Ixn4BwLqreoQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.117.161) smtp.rcpttodomain=monjalon.net smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Sdcy+b33zqPwYyFI33Ya73btsy1CySRcqnSEU8aC8Wg=; b=rYBrREraS4etjqNkZOIWcKjCfoUn5W1AvKCQauXeKjyGpxrx02BBgpgVbnAXEJifqLaPJvLoLng2vrujfzsSUECMKaRH7PHITf9oOE/j7Jz0zFd8fOl6s92WNTBuN6u8NfW1BsXdyJvK4axOW63I5I0PD2+GKcEJGB7dGo98SqjoOJwiJFgtw7KxfQKvpWxnQfj99xHCICL87qEVzuRRdRw07N39M8ZyX3kzMEPN/wlW56miN5jt42fht3TL8KY4QlUU51bJT4tzNAwmSFek/dGbcUJh0TfIoQpbqD0T7wx2sN7sxrTo+5SWm9cFx79p9Y5FU023BSX3PSOVikma+g== Received: from CY5PR03CA0026.namprd03.prod.outlook.com (2603:10b6:930:8::21) by IA1PR12MB6185.namprd12.prod.outlook.com (2603:10b6:208:3e7::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6043.22; Sat, 28 Jan 2023 13:09:23 +0000 Received: from CY4PEPF0000C96D.namprd02.prod.outlook.com (2603:10b6:930:8:cafe::29) by CY5PR03CA0026.outlook.office365.com (2603:10b6:930:8::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6043.30 via Frontend Transport; Sat, 28 Jan 2023 13:09:23 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.117.161) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.117.161 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.117.161; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.117.161) by CY4PEPF0000C96D.mail.protection.outlook.com (10.167.242.5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6043.16 via Frontend Transport; Sat, 28 Jan 2023 13:09:23 +0000 Received: from rnnvmail201.nvidia.com (10.129.68.8) by mail.nvidia.com (10.129.200.67) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.36; Sat, 28 Jan 2023 05:09:20 -0800 Received: from nvidia.com (10.126.230.37) by rnnvmail201.nvidia.com (10.129.68.8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.36; Sat, 28 Jan 2023 05:09:17 -0800 From: Jiawei Wang To: , , , "Aman Singh" , Yuying Zhang , Ferruh Yigit , Andrew Rybchenko CC: , Subject: [PATCH 1/2] ethdev: add mhpsdp hardware port match item Date: Sat, 28 Jan 2023 15:08:56 +0200 Message-ID: <20230128130857.17399-2-jiaweiw@nvidia.com> X-Mailer: git-send-email 2.18.1 In-Reply-To: <20230128130857.17399-1-jiaweiw@nvidia.com> References: <20230128130857.17399-1-jiaweiw@nvidia.com> MIME-Version: 1.0 X-Originating-IP: [10.126.230.37] X-ClientProxiedBy: rnnvmail202.nvidia.com (10.129.68.7) To rnnvmail201.nvidia.com (10.129.68.8) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CY4PEPF0000C96D:EE_|IA1PR12MB6185:EE_ X-MS-Office365-Filtering-Correlation-Id: cd21c3e5-6e83-477f-2d26-08db0130e02e X-LD-Processed: 43083d15-7273-40c1-b7db-39efd9ccc17a,ExtAddr X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: MtQyy4zTbjzmdIgGEWPuO8NJ9UlO2U5i4naDQcVQG6/iBW1hJf9M/uyFNrp99CaHk1ha48duOIpF4BrxABlXw4TutXEPjofufBel3rB7pqNHctlOE8cEPW1sHQH11ACYKFGoRPhmsz0rRXWwDGD0qgao274hZu0oO5duT/LUERyaaf2c0FUpQEKmw0aKZwF1sJt9/1ucb8DD9Fbh3K0dysMCVj5qU5UJP56x6Ak+yfE1+vyEVGHYXbSWzeQlDAUUmQcvaViJEtUp3LiYjwJ1NFwXVg4fWAOdlYQEaqAd6Kav+5WyT4SfMyRVUTNlgs2bzIGmZLSINzZvUEaTEj1ktu+0FdbHZluApeHK/3Pv2Ocltqn5MP/MdCdfjmXd5YrgnH5fWoHRfbey98rmtnIwCQWnX8MGffnqxfbTWPO0B8ciIMY/OW1m2hwfGqBuiDQ6gqfAARed3Tq4cAtvMaQp4yIQ9P6R+wSJgnnw9SBkOLnwlaZgE+ESo0cFsBC4Y690yKhQrgy0mdoOvmCW5fuHGPLdrN9vCbvurZPqB00xH24y+LwTrpoG22dkqYHZkuknZprEXJXfhOQ8wPS3PRC98msgl8Ck2MmRwWD962BV7yWKmT5EaCac+rZeDUuBKTmFUY8mv5g/e5ah1kzCfeDSjIK3iMMXIdIX+Xhe3cUqFGNVeCkJWEm5u74Afzm2/abGY/7vs4wvFXGBhO0VGDbOf37w36dJ1Sx6bCV4QYB9tEM= X-Forefront-Antispam-Report: CIP:216.228.117.161; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:dc6edge2.nvidia.com; CAT:NONE; SFS:(13230025)(4636009)(376002)(136003)(39860400002)(396003)(346002)(451199018)(46966006)(40470700004)(36840700001)(82310400005)(1076003)(6286002)(36860700001)(2616005)(8936002)(40460700003)(356005)(2906002)(110136005)(7636003)(82740400003)(7696005)(316002)(41300700001)(478600001)(40480700001)(186003)(426003)(86362001)(55016003)(26005)(83380400001)(107886003)(16526019)(6666004)(54906003)(336012)(70586007)(47076005)(8676002)(70206006)(5660300002)(4326008)(36756003)(40753002); DIR:OUT; SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Jan 2023 13:09:23.2831 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: cd21c3e5-6e83-477f-2d26-08db0130e02e X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.117.161]; Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: CY4PEPF0000C96D.namprd02.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA1PR12MB6185 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org For the multiple hardware ports connect to a single DPDK port (mhpsdp), currently there is no information to indicate the packet belongs to which hardware port. This patch introduces a new hardware port item in rte flow API, and the port value reflects the hardware port of the received packets. While uses the hardware port as a matching item in the flow, and sets the same port value on the tx queue, then the packet can be sent from the same hardware port with received. This patch also adds the testpmd command line to match the new item: flow create 0 ingress group 0 pattern mhpsdp_hw_port hwport is 1 / end actions queue index 0 / end The above command means that creates a flow on a single DPDK port and matches the packet from the first physical port (the hwport 1 stands for the first port) and redirects these packets into RxQ 0. Signed-off-by: Jiawei Wang --- app/test-pmd/cmdline_flow.c | 29 +++++++++++++++++++ doc/guides/prog_guide/rte_flow.rst | 8 ++++++ doc/guides/rel_notes/release_23_03.rst | 5 ++++ doc/guides/testpmd_app_ug/testpmd_funcs.rst | 5 ++++ lib/ethdev/rte_flow.c | 1 + lib/ethdev/rte_flow.h | 32 +++++++++++++++++++++ 6 files changed, 80 insertions(+) diff --git a/app/test-pmd/cmdline_flow.c b/app/test-pmd/cmdline_flow.c index 88108498e0..fb9c0cc622 100644 --- a/app/test-pmd/cmdline_flow.c +++ b/app/test-pmd/cmdline_flow.c @@ -465,6 +465,8 @@ enum index { ITEM_METER, ITEM_METER_COLOR, ITEM_METER_COLOR_NAME, + ITEM_MHPSDP_HW_PORT, + ITEM_MHPSDP_HW_PORT_VALUE, /* Validate/create actions. */ ACTIONS, @@ -1355,6 +1357,7 @@ static const enum index next_item[] = { ITEM_L2TPV2, ITEM_PPP, ITEM_METER, + ITEM_MHPSDP_HW_PORT, END_SET, ZERO, }; @@ -1821,6 +1824,12 @@ static const enum index item_meter[] = { ZERO, }; +static const enum index item_mhpsdp_hw_port[] = { + ITEM_MHPSDP_HW_PORT_VALUE, + ITEM_NEXT, + ZERO, +}; + static const enum index next_action[] = { ACTION_END, ACTION_VOID, @@ -6443,6 +6452,23 @@ static const struct token token_list[] = { ARGS_ENTRY(struct buffer, port)), .call = parse_mp, }, + [ITEM_MHPSDP_HW_PORT] = { + .name = "mhpsdp_hw_port", + .help = "match on the hardware port of the" + " received packet.", + .priv = PRIV_ITEM(MHPSDP_HW_PORT, + sizeof(struct rte_flow_item_mhpsdp_hw_port)), + .next = NEXT(item_mhpsdp_hw_port), + .call = parse_vc, + }, + [ITEM_MHPSDP_HW_PORT_VALUE] = { + .name = "hwport", + .help = "hardware port value", + .next = NEXT(item_mhpsdp_hw_port, NEXT_ENTRY(COMMON_UNSIGNED), + item_param), + .args = ARGS(ARGS_ENTRY(struct rte_flow_item_mhpsdp_hw_port, + hwport)), + }, }; /** Remove and return last entry from argument stack. */ @@ -10981,6 +11007,9 @@ flow_item_default_mask(const struct rte_flow_item *item) case RTE_FLOW_ITEM_TYPE_METER_COLOR: mask = &rte_flow_item_meter_color_mask; break; + case RTE_FLOW_ITEM_TYPE_MHPSDP_HW_PORT: + mask = &rte_flow_item_mhpsdp_hw_port_mask; + break; default: break; } diff --git a/doc/guides/prog_guide/rte_flow.rst b/doc/guides/prog_guide/rte_flow.rst index 3e6242803d..175ffec288 100644 --- a/doc/guides/prog_guide/rte_flow.rst +++ b/doc/guides/prog_guide/rte_flow.rst @@ -1544,6 +1544,14 @@ Matches Color Marker set by a Meter. - ``color``: Metering color marker. +Item: ``MHPSDP_HW_PORT`` +^^^^^^^^^^^^^^^^^^^^^^^ + +Matches on the hardware port of the received packet, the hardware port in the +group of physical ports connected to a single DPDK port. + +- ``hwport``: Hardware port value. + Actions ~~~~~~~ diff --git a/doc/guides/rel_notes/release_23_03.rst b/doc/guides/rel_notes/release_23_03.rst index c15f6fbb9f..b5b3ab8886 100644 --- a/doc/guides/rel_notes/release_23_03.rst +++ b/doc/guides/rel_notes/release_23_03.rst @@ -69,6 +69,11 @@ New Features ``rte_event_dev_config::nb_single_link_event_port_queues`` parameter required for eth_rx, eth_tx, crypto and timer eventdev adapters. +* **Added rte_flow support for matching MHPSDP_HW_PORT fields.** + + For the multiple hardware ports connect to a single DPDK port (mhpsdp), + Added ``mhpsdp_hw_port`` item in rte_flow to support hardware port of + the packets. Removed Items ------------- diff --git a/doc/guides/testpmd_app_ug/testpmd_funcs.rst b/doc/guides/testpmd_app_ug/testpmd_funcs.rst index 0037506a79..7be7c55d63 100644 --- a/doc/guides/testpmd_app_ug/testpmd_funcs.rst +++ b/doc/guides/testpmd_app_ug/testpmd_funcs.rst @@ -3712,6 +3712,11 @@ This section lists supported pattern items and their attributes, if any. - ``color {value}``: meter color value (green/yellow/red). +- ``mhpsdp_hw_port``: match hardware port in the group of multiple ports connect + to a single DPDK port. + + - ``hwport {value}``: hardware port value. + - ``send_to_kernel``: send packets to kernel. diff --git a/lib/ethdev/rte_flow.c b/lib/ethdev/rte_flow.c index 7d0c24366c..92115a792a 100644 --- a/lib/ethdev/rte_flow.c +++ b/lib/ethdev/rte_flow.c @@ -157,6 +157,7 @@ static const struct rte_flow_desc_data rte_flow_desc_item[] = { MK_FLOW_ITEM(L2TPV2, sizeof(struct rte_flow_item_l2tpv2)), MK_FLOW_ITEM(PPP, sizeof(struct rte_flow_item_ppp)), MK_FLOW_ITEM(METER_COLOR, sizeof(struct rte_flow_item_meter_color)), + MK_FLOW_ITEM(MHPSDP_HW_PORT, sizeof(struct rte_flow_item_mhpsdp_hw_port)), }; /** Generate flow_action[] entry. */ diff --git a/lib/ethdev/rte_flow.h b/lib/ethdev/rte_flow.h index b60987db4b..53f99a20c8 100644 --- a/lib/ethdev/rte_flow.h +++ b/lib/ethdev/rte_flow.h @@ -624,6 +624,13 @@ enum rte_flow_item_type { * See struct rte_flow_item_meter_color. */ RTE_FLOW_ITEM_TYPE_METER_COLOR, + + /** + * Matches on the physical port of the received packet. + * + * See struct rte_flow_item_mhpsdp_hw_port. + */ + RTE_FLOW_ITEM_TYPE_MHPSDP_HW_PORT, }; /** @@ -2103,6 +2110,31 @@ static const struct rte_flow_item_meter_color rte_flow_item_meter_color_mask = { }; #endif +/** + * @warning + * @b EXPERIMENTAL: this structure may change without prior notice + * + * RTE_FLOW_ITEM_TYPE_MHPSDP_HW_PORT + * + * For the multiple hardware ports connect to a single DPDK port (mhpsdp), + * use this item to match the hardware port of the packets. + */ +struct rte_flow_item_mhpsdp_hw_port { + /** + * Hardware port in the group of multiple ports connect + * to a single DPDK port. Value 1 means the first hw port. + */ + uint8_t hwport; +}; + +/** Default mask for RTE_FLOW_ITEM_TYPE_MHPSDP_HW_PORT. */ +#ifndef __cplusplus +static const struct rte_flow_item_mhpsdp_hw_port +rte_flow_item_mhpsdp_hw_port_mask = { + .hwport = 0xff, +}; +#endif + /** * Action types. *