[v2] net/sfc: export pick transfer proxy callback to representors
Checks
Commit Message
Currently, the "pick transfer proxy ethdev" callback is only
advertised for non-representor (in example, main PF) ethdevs.
That does not sit well with the original idea of this method,
which is to let applications discover the privileged port to
use for transfer flow management instead of any given ethdev.
Applications trying to leverage this API on sfc representors
receive an error and cannot configure transfer flow offloads.
Fix the problem by exporting the method to representor ports.
Fixes: 26706314d418 ("net/sfc: implement transfer proxy port callback")
Cc: stable@dpdk.org
Signed-off-by: Ivan Malov <ivan.malov@arknetworks.am>
Reviewed-by: Andy Moreton <amoreton@xilinx.com>
Reviewed-by: Viacheslav Galaktionov <Viacheslav.Galaktionov@arknetworks.am>
---
v2: address community review notes
drivers/net/sfc/sfc_repr.c | 26 ++++++++++++++++++++++++++
1 file changed, 26 insertions(+)
Comments
On 1/31/23 14:08, Ivan Malov wrote:
> Currently, the "pick transfer proxy ethdev" callback is only
> advertised for non-representor (in example, main PF) ethdevs.
> That does not sit well with the original idea of this method,
> which is to let applications discover the privileged port to
> use for transfer flow management instead of any given ethdev.
> Applications trying to leverage this API on sfc representors
> receive an error and cannot configure transfer flow offloads.
>
> Fix the problem by exporting the method to representor ports.
>
> Fixes: 26706314d418 ("net/sfc: implement transfer proxy port callback")
> Cc: stable@dpdk.org
>
> Signed-off-by: Ivan Malov <ivan.malov@arknetworks.am>
> Reviewed-by: Andy Moreton <amoreton@xilinx.com>
> Reviewed-by: Viacheslav Galaktionov <Viacheslav.Galaktionov@arknetworks.am>
No capital letters in E-mail address, please.
Reviewed-by: Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>
On 1/31/2023 11:13 AM, Andrew Rybchenko wrote:
> On 1/31/23 14:08, Ivan Malov wrote:
>> Currently, the "pick transfer proxy ethdev" callback is only
>> advertised for non-representor (in example, main PF) ethdevs.
>> That does not sit well with the original idea of this method,
>> which is to let applications discover the privileged port to
>> use for transfer flow management instead of any given ethdev.
>> Applications trying to leverage this API on sfc representors
>> receive an error and cannot configure transfer flow offloads.
>>
>> Fix the problem by exporting the method to representor ports.
>>
>> Fixes: 26706314d418 ("net/sfc: implement transfer proxy port callback")
>> Cc: stable@dpdk.org
>>
>> Signed-off-by: Ivan Malov <ivan.malov@arknetworks.am>
>> Reviewed-by: Andy Moreton <amoreton@xilinx.com>
>> Reviewed-by: Viacheslav Galaktionov
>> <Viacheslav.Galaktionov@arknetworks.am>
>
> No capital letters in E-mail address, please.
>
fixed while merging
> Reviewed-by: Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>
>
Applied to dpdk-next-net/main, thanks.
On Wed, 8 Feb 2023, Ferruh Yigit wrote:
> On 1/31/2023 11:13 AM, Andrew Rybchenko wrote:
>> On 1/31/23 14:08, Ivan Malov wrote:
>>> Currently, the "pick transfer proxy ethdev" callback is only
>>> advertised for non-representor (in example, main PF) ethdevs.
>>> That does not sit well with the original idea of this method,
>>> which is to let applications discover the privileged port to
>>> use for transfer flow management instead of any given ethdev.
>>> Applications trying to leverage this API on sfc representors
>>> receive an error and cannot configure transfer flow offloads.
>>>
>>> Fix the problem by exporting the method to representor ports.
>>>
>>> Fixes: 26706314d418 ("net/sfc: implement transfer proxy port callback")
>>> Cc: stable@dpdk.org
>>>
>>> Signed-off-by: Ivan Malov <ivan.malov@arknetworks.am>
>>> Reviewed-by: Andy Moreton <amoreton@xilinx.com>
>>> Reviewed-by: Viacheslav Galaktionov
>>> <Viacheslav.Galaktionov@arknetworks.am>
>>
>> No capital letters in E-mail address, please.
>>
>
> fixed while merging
Thank you Ferruh. You have been most helpful.
>
>> Reviewed-by: Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>
>>
>
> Applied to dpdk-next-net/main, thanks.
>
>
@@ -9,6 +9,8 @@
#include <stdint.h>
+#include <rte_flow_driver.h>
+#include <rte_flow.h>
#include <rte_mbuf.h>
#include <rte_ethdev.h>
#include <rte_malloc.h>
@@ -888,6 +890,29 @@ sfc_repr_stats_get(struct rte_eth_dev *dev, struct rte_eth_stats *stats)
return 0;
}
+static int
+sfc_repr_flow_pick_transfer_proxy(struct rte_eth_dev *dev,
+ uint16_t *transfer_proxy_port,
+ struct rte_flow_error *error)
+{
+ struct sfc_repr_shared *srs = sfc_repr_shared_by_eth_dev(dev);
+
+ return rte_flow_pick_transfer_proxy(srs->pf_port_id,
+ transfer_proxy_port, error);
+}
+
+const struct rte_flow_ops sfc_repr_flow_ops = {
+ .pick_transfer_proxy = sfc_repr_flow_pick_transfer_proxy,
+};
+
+static int
+sfc_repr_dev_flow_ops_get(struct rte_eth_dev *dev __rte_unused,
+ const struct rte_flow_ops **ops)
+{
+ *ops = &sfc_repr_flow_ops;
+ return 0;
+}
+
static const struct eth_dev_ops sfc_repr_dev_ops = {
.dev_configure = sfc_repr_dev_configure,
.dev_start = sfc_repr_dev_start,
@@ -901,6 +926,7 @@ static const struct eth_dev_ops sfc_repr_dev_ops = {
.rx_queue_release = sfc_repr_rx_queue_release,
.tx_queue_setup = sfc_repr_tx_queue_setup,
.tx_queue_release = sfc_repr_tx_queue_release,
+ .flow_ops_get = sfc_repr_dev_flow_ops_get,
};