From patchwork Wed Feb 1 07:28:04 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Alex Vesker X-Patchwork-Id: 122783 X-Patchwork-Delegate: rasland@nvidia.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id A463041B9B; Wed, 1 Feb 2023 08:29:32 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 7C6D142D3A; Wed, 1 Feb 2023 08:29:05 +0100 (CET) Received: from NAM02-SN1-obe.outbound.protection.outlook.com (mail-sn1nam02on2050.outbound.protection.outlook.com [40.107.96.50]) by mails.dpdk.org (Postfix) with ESMTP id 1A66242D0E for ; Wed, 1 Feb 2023 08:29:04 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=HhzZmwIszEqoH3ox7pWZSR+ynhzylZ+WEAsaK4TYBlhPkFmcdIMPrMZrAIT0bqDOQ5o/fjhOt1zX5Sl4H4UYBfFS9JJhsc7lN3oUf52QOriN2cWiwH8RGLcYjnQU5zqYXDerJO9J6W+Voc+l5/njJbML1J8XZz8lm5bcVF2Bq3ykq0IjheXWhFQzRdaHUm0navZ8OdeXmBU4/7Hj6J/LSR1VaIBj6UgbMboOonywFFKS4BAdsMj//HNfSf1P9Pgy70Iy/Z30JqFjWEDEe3UESk4ft5Jl16jaiyiX7hgn3oO/cR1Cs1aYGiLScz16ZVq5wJrEpnJXBvSbXpJ+tI1zYg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Yr+q/4M9OMh13H28sjEXhnUf+GLUeT9C7JNMnnmj1WI=; b=ZR3eISdUYVpX0FuSJZr6ErOpMvZgyMcJ56NxFa7rMSL8PTSV00BgQGUJydXegyuKisy9dpNMos4a9kRWrOZqcRYmb9iOnKdHfysia5KQ2LPJE7BjqoplT0SEqbHwjRgI2ArEL79AMMpfk5AIu6akbavHRNM0gPgqjfE/IKLDOx8GBv/XOpTK83s+6+cfU/NOwTQjOo3tHNLGZMYzEFGkVHUCN8xGBYi4OWP57QLHzJjdZAr3sbrdOMuabxGcFElSf43XoVq06CkaRpyKQxTbQos+gREpGyIKNktDR5HiVhIe6UI298dbE5ROvYH8jK1HhDfxxmqpU/TFeZKuu5Jo3g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.117.161) smtp.rcpttodomain=monjalon.net smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Yr+q/4M9OMh13H28sjEXhnUf+GLUeT9C7JNMnnmj1WI=; b=UzwSXDWp7Y9olqbHNQnolz/VFaTAdoNrPR05ecIN/o91tK8G5zNsPJ+e6MAYYBQBtgVXW9cjuVqwJkhkQzThcqxavIcuTD/nNhoDFzoRLUR+EBpEpfDgEF7yB4kjo+DOon2c4U9EP5jgtpLdj7UbgmaicW+StbZasFLYtxEialqIwjgy+ddhNXL+G+SrXBdnYOD+WEQcw77mvrfHghn9f8m/H0fNQEHDqYLdXqUeaTdEDYicjwcU4Xc5FnvLnD0o3wI3zmUZx/7/soD0BNjK3kDol3H1gdSG+U52ZNs/hGYB/p47fdL2x9A0sFZk+OfeJ/6yZsb4RhgALnu5XNMvew== Received: from BN9PR03CA0531.namprd03.prod.outlook.com (2603:10b6:408:131::26) by MN0PR12MB5884.namprd12.prod.outlook.com (2603:10b6:208:37c::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6043.38; Wed, 1 Feb 2023 07:29:02 +0000 Received: from BN8NAM11FT109.eop-nam11.prod.protection.outlook.com (2603:10b6:408:131:cafe::7a) by BN9PR03CA0531.outlook.office365.com (2603:10b6:408:131::26) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6043.38 via Frontend Transport; Wed, 1 Feb 2023 07:29:02 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.117.161) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.117.161 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.117.161; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.117.161) by BN8NAM11FT109.mail.protection.outlook.com (10.13.176.221) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6064.24 via Frontend Transport; Wed, 1 Feb 2023 07:29:02 +0000 Received: from rnnvmail201.nvidia.com (10.129.68.8) by mail.nvidia.com (10.129.200.67) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.36; Tue, 31 Jan 2023 23:28:49 -0800 Received: from nvidia.com (10.126.230.37) by rnnvmail201.nvidia.com (10.129.68.8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.36; Tue, 31 Jan 2023 23:28:47 -0800 From: Alex Vesker To: , , , "Matan Azrad" CC: , Subject: [v2 05/16] net/mlx5/hws: align RTC create command with PRM format Date: Wed, 1 Feb 2023 09:28:04 +0200 Message-ID: <20230201072815.1329101-6-valex@nvidia.com> X-Mailer: git-send-email 2.27.0 In-Reply-To: <20230201072815.1329101-1-valex@nvidia.com> References: <20230131093346.1261066-1-valex@nvidia.com> <20230201072815.1329101-1-valex@nvidia.com> MIME-Version: 1.0 X-Originating-IP: [10.126.230.37] X-ClientProxiedBy: rnnvmail201.nvidia.com (10.129.68.8) To rnnvmail201.nvidia.com (10.129.68.8) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BN8NAM11FT109:EE_|MN0PR12MB5884:EE_ X-MS-Office365-Filtering-Correlation-Id: 25c81572-e8e3-484c-fe5b-08db0425fdf9 X-LD-Processed: 43083d15-7273-40c1-b7db-39efd9ccc17a,ExtAddr X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: P9FEytdHoVUGbZX8q1jh22G0mHxvZipAgFT2zlyy9nmtDt3SMJEQNzS91CHMTiBdr3JkF1pODBo2WHnLYYhArqQGoWPK4acvpSIQ9CABYRxwqWUxvh4vbvnHPOa9THrBFY/ppLVvjNAZBJhwvrUisXR3GqPnc0aqnBgxOwivELh6vNd5YD2fDuwFywd/QXHPPo+dxn2jo5cjbC5hMkHV/Nuib0VSib7HrFfdZ3GGAfpf5s8gtQKK7r2gltkhfabpzkLREbZ86p7Z1JHIwmyxOKiszw8zH+V23LAgkUenraySl1vlHE1+RA3bBTYJXdbxqgndzcbm5ES45Qz+D5b4H/ZN7WC9j3lBiBH+i1fpk8XX8SBRpWCdQLdmIAS5l4cXbsvsX2W8TU1i00oQktB8dD+1/0cFCAW7DbZ3LJF8Kjhm6VQ42cGJjgyJMQmW15uQPxGjK1dFK52uv1avE+WlvP9texNOccx/PKKRuvMXUs3i74pOldygXA+E3pwW1eEn5R7PpOhHY2oQQP5MeTxsLjbnvlCZEKNm46Sk6OzZXNjwqJ6LKFfaPDEnssOnSQRsTe/B0HUglM08NjzmR9zAFPWUv+igTobLqhd4OPDQZT2llDvdMPYxbDjhlrFD1ZhvJHTN+NNBrTHAfdtIiJLIgYoC13UNY+nbANAEikPk7Y7tHscyS6K+CSLO4IcRI1+amODQE8VTO9DFbfSBn2HjPQ== X-Forefront-Antispam-Report: CIP:216.228.117.161; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:dc6edge2.nvidia.com; CAT:NONE; SFS:(13230025)(4636009)(396003)(39860400002)(136003)(376002)(346002)(451199018)(36840700001)(46966006)(40470700004)(5660300002)(2906002)(8936002)(41300700001)(4326008)(70206006)(83380400001)(70586007)(8676002)(16526019)(82310400005)(36756003)(7696005)(40480700001)(110136005)(40460700003)(478600001)(6286002)(186003)(6666004)(107886003)(26005)(1076003)(55016003)(426003)(47076005)(86362001)(336012)(2616005)(6636002)(356005)(54906003)(82740400003)(7636003)(36860700001)(316002); DIR:OUT; SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Feb 2023 07:29:02.2346 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 25c81572-e8e3-484c-fe5b-08db0425fdf9 X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.117.161]; Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: BN8NAM11FT109.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN0PR12MB5884 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Rename rtc params create for new format. Signed-off-by: Alex Vesker --- drivers/common/mlx5/mlx5_prm.h | 16 ++++++++++------ drivers/net/mlx5/hws/mlx5dr_cmd.c | 13 +++++++++++-- drivers/net/mlx5/hws/mlx5dr_cmd.h | 11 +++++++---- drivers/net/mlx5/hws/mlx5dr_matcher.c | 19 ++++++++++++------- 4 files changed, 40 insertions(+), 19 deletions(-) diff --git a/drivers/common/mlx5/mlx5_prm.h b/drivers/common/mlx5/mlx5_prm.h index 140534ea46..298cc48b06 100644 --- a/drivers/common/mlx5/mlx5_prm.h +++ b/drivers/common/mlx5/mlx5_prm.h @@ -3237,6 +3237,7 @@ enum mlx5_ifc_rtc_access_mode { enum mlx5_ifc_rtc_ste_format { MLX5_IFC_RTC_STE_FORMAT_8DW = 0x4, MLX5_IFC_RTC_STE_FORMAT_11DW = 0x5, + MLX5_IFC_RTC_STE_FORMAT_RANGE = 0x7, }; enum mlx5_ifc_rtc_reparse_mode { @@ -3251,24 +3252,27 @@ struct mlx5_ifc_rtc_bits { u8 reserved_at_40[0x40]; u8 update_index_mode[0x2]; u8 reparse_mode[0x2]; - u8 reserved_at_84[0x4]; + u8 num_match_ste[0x4]; u8 pd[0x18]; u8 reserved_at_a0[0x9]; u8 access_index_mode[0x3]; u8 num_hash_definer[0x4]; - u8 reserved_at_b0[0x3]; + u8 update_method[0x1]; + u8 reserved_at_b1[0x2]; u8 log_depth[0x5]; u8 log_hash_size[0x8]; - u8 ste_format[0x8]; + u8 ste_format_0[0x8]; u8 table_type[0x8]; - u8 reserved_at_d0[0x10]; - u8 match_definer_id[0x20]; + u8 ste_format_1[0x8]; + u8 reserved_at_d8[0x8]; + u8 match_definer_0[0x20]; u8 stc_id[0x20]; u8 ste_table_base_id[0x20]; u8 ste_table_offset[0x20]; u8 reserved_at_160[0x8]; u8 miss_flow_table_id[0x18]; - u8 reserved_at_180[0x280]; + u8 match_definer_1[0x20]; + u8 reserved_at_1a0[0x260]; }; struct mlx5_ifc_alias_context_bits { diff --git a/drivers/net/mlx5/hws/mlx5dr_cmd.c b/drivers/net/mlx5/hws/mlx5dr_cmd.c index b0cef5e944..3578fe4b69 100644 --- a/drivers/net/mlx5/hws/mlx5dr_cmd.c +++ b/drivers/net/mlx5/hws/mlx5dr_cmd.c @@ -259,17 +259,26 @@ mlx5dr_cmd_rtc_create(struct ibv_context *ctx, attr, obj_type, MLX5_GENERAL_OBJ_TYPE_RTC); attr = MLX5_ADDR_OF(create_rtc_in, in, rtc); - MLX5_SET(rtc, attr, ste_format, rtc_attr->is_jumbo ? + MLX5_SET(rtc, attr, ste_format_0, rtc_attr->is_frst_jumbo ? MLX5_IFC_RTC_STE_FORMAT_11DW : MLX5_IFC_RTC_STE_FORMAT_8DW); + + if (rtc_attr->is_scnd_range) { + MLX5_SET(rtc, attr, ste_format_1, MLX5_IFC_RTC_STE_FORMAT_RANGE); + MLX5_SET(rtc, attr, num_match_ste, 2); + } + MLX5_SET(rtc, attr, pd, rtc_attr->pd); + MLX5_SET(rtc, attr, update_method, rtc_attr->fw_gen_wqe); MLX5_SET(rtc, attr, update_index_mode, rtc_attr->update_index_mode); MLX5_SET(rtc, attr, access_index_mode, rtc_attr->access_index_mode); MLX5_SET(rtc, attr, num_hash_definer, rtc_attr->num_hash_definer); MLX5_SET(rtc, attr, log_depth, rtc_attr->log_depth); MLX5_SET(rtc, attr, log_hash_size, rtc_attr->log_size); MLX5_SET(rtc, attr, table_type, rtc_attr->table_type); - MLX5_SET(rtc, attr, match_definer_id, rtc_attr->definer_id); + MLX5_SET(rtc, attr, num_hash_definer, rtc_attr->num_hash_definer); + MLX5_SET(rtc, attr, match_definer_0, rtc_attr->match_definer_0); + MLX5_SET(rtc, attr, match_definer_1, rtc_attr->match_definer_1); MLX5_SET(rtc, attr, stc_id, rtc_attr->stc_base); MLX5_SET(rtc, attr, ste_table_base_id, rtc_attr->ste_base); MLX5_SET(rtc, attr, ste_table_offset, rtc_attr->ste_offset); diff --git a/drivers/net/mlx5/hws/mlx5dr_cmd.h b/drivers/net/mlx5/hws/mlx5dr_cmd.h index 36295e0c76..0fc65aad49 100644 --- a/drivers/net/mlx5/hws/mlx5dr_cmd.h +++ b/drivers/net/mlx5/hws/mlx5dr_cmd.h @@ -23,8 +23,8 @@ struct mlx5dr_cmd_ft_modify_attr { }; struct mlx5dr_cmd_fg_attr { - uint32_t table_id; - uint32_t table_type; + uint32_t table_id; + uint32_t table_type; }; struct mlx5dr_cmd_forward_tbl { @@ -40,14 +40,17 @@ struct mlx5dr_cmd_rtc_create_attr { uint32_t ste_base; uint32_t ste_offset; uint32_t miss_ft_id; + bool fw_gen_wqe; uint8_t update_index_mode; uint8_t access_index_mode; uint8_t num_hash_definer; uint8_t log_depth; uint8_t log_size; uint8_t table_type; - uint8_t definer_id; - bool is_jumbo; + uint8_t match_definer_0; + uint8_t match_definer_1; + bool is_frst_jumbo; + bool is_scnd_range; }; struct mlx5dr_cmd_alias_obj_create_attr { diff --git a/drivers/net/mlx5/hws/mlx5dr_matcher.c b/drivers/net/mlx5/hws/mlx5dr_matcher.c index 913bb9d447..101a12d361 100644 --- a/drivers/net/mlx5/hws/mlx5dr_matcher.c +++ b/drivers/net/mlx5/hws/mlx5dr_matcher.c @@ -413,6 +413,8 @@ static int mlx5dr_matcher_create_rtc(struct mlx5dr_matcher *matcher, struct mlx5dr_pool *ste_pool, *stc_pool; struct mlx5dr_devx_obj *devx_obj; struct mlx5dr_pool_chunk *ste; + uint8_t first_definer_id; + bool is_jumbo; int ret; switch (rtc_type) { @@ -426,12 +428,15 @@ static int mlx5dr_matcher_create_rtc(struct mlx5dr_matcher *matcher, rtc_attr.log_depth = attr->table.sz_col_log; rtc_attr.miss_ft_id = matcher->end_ft->id; + is_jumbo = mlx5dr_definer_is_jumbo(matcher->mt->definer); + first_definer_id = mlx5dr_definer_get_id(matcher->mt->definer); + if (attr->insert_mode == MLX5DR_MATCHER_INSERT_BY_HASH) { /* The usual Hash Table */ rtc_attr.update_index_mode = MLX5_IFC_RTC_STE_UPDATE_MODE_BY_HASH; /* The first match template is used since all share the same definer */ - rtc_attr.definer_id = mlx5dr_definer_get_id(matcher->mt->definer); - rtc_attr.is_jumbo = mlx5dr_definer_is_jumbo(matcher->mt->definer); + rtc_attr.match_definer_0 = first_definer_id; + rtc_attr.is_frst_jumbo = is_jumbo; } else if (attr->insert_mode == MLX5DR_MATCHER_INSERT_BY_INDEX) { rtc_attr.update_index_mode = MLX5_IFC_RTC_STE_UPDATE_MODE_BY_OFFSET; rtc_attr.num_hash_definer = 1; @@ -439,12 +444,12 @@ static int mlx5dr_matcher_create_rtc(struct mlx5dr_matcher *matcher, if (attr->distribute_mode == MLX5DR_MATCHER_DISTRIBUTE_BY_HASH) { /* Hash Split Table */ rtc_attr.access_index_mode = MLX5_IFC_RTC_STE_ACCESS_MODE_BY_HASH; - rtc_attr.definer_id = mlx5dr_definer_get_id(matcher->mt->definer); - rtc_attr.is_jumbo = mlx5dr_definer_is_jumbo(matcher->mt->definer); + rtc_attr.match_definer_0 = first_definer_id; + rtc_attr.is_frst_jumbo = is_jumbo; } else if (attr->distribute_mode == MLX5DR_MATCHER_DISTRIBUTE_BY_LINEAR) { /* Linear Lookup Table */ rtc_attr.access_index_mode = MLX5_IFC_RTC_STE_ACCESS_MODE_LINEAR; - rtc_attr.definer_id = ctx->caps->linear_match_definer; + rtc_attr.match_definer_0 = ctx->caps->linear_match_definer; } } @@ -468,8 +473,8 @@ static int mlx5dr_matcher_create_rtc(struct mlx5dr_matcher *matcher, rtc_attr.log_depth = 0; rtc_attr.update_index_mode = MLX5_IFC_RTC_STE_UPDATE_MODE_BY_OFFSET; /* The action STEs use the default always hit definer */ - rtc_attr.definer_id = ctx->caps->trivial_match_definer; - rtc_attr.is_jumbo = false; + rtc_attr.match_definer_0 = ctx->caps->trivial_match_definer; + rtc_attr.is_frst_jumbo = false; rtc_attr.miss_ft_id = 0; break;