From patchwork Fri Feb 3 02:23:28 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Chaoyong He X-Patchwork-Id: 122986 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 0487141BB4; Fri, 3 Feb 2023 03:23:51 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id E30874014F; Fri, 3 Feb 2023 03:23:50 +0100 (CET) Received: from NAM10-DM6-obe.outbound.protection.outlook.com (mail-dm6nam10on2132.outbound.protection.outlook.com [40.107.93.132]) by mails.dpdk.org (Postfix) with ESMTP id D6C8C40141; Fri, 3 Feb 2023 03:23:48 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=nN+c6LePotKdnjYpjClNnPSAauX8EPjb74XU8uGYEm2+eGJbvZJ6GRTCb3t/rYVF/zjcRZhRqw8Vk6UeiZnLRDduEoXO1x7oVGSbowj56DIWOSV5r8OOd1ncdnjpCHmO2KUUng4yRKkgL/TvsS1VtH27h/q3bCoyv3XGcg/b1nILdNhkocuWQvlMpg8tcjgJCl9E/B6llOuWoj0uD3yxmtqCmtRQyBUODSE11QU5ADFwBeAGPmynm7lioS8MIg/dT6LLMN/8hy9n17uNexv47cefr19N355r3pTPlOzNryPXx/Uh+8MSNweK8ylsXbe01CW3LghDYPbeGfE8eoTjfQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=swqWDYNBTLpVh8dX7tnUpGjxdQSRVA6Ez43TlUrd3zw=; b=mzHhmwdsju0dIFa2bYdJ1zFPr3gmSr6V2QbDKyHSMgg2DwNWTZRmxUoqRFFBsNqShOdJKZhgNUCfM8z5Z0aT5b6VSfLHYbc25C5bd/frirTGE2obFHSe/V5gZA3XniwEQuVUqDo7ynG7Z+jp2zXHaWQ1C+aUXhLE4x14dLh82TqlxMCXidvCqzFALhOON//+fyw8oGtw82yo+8+tdh6HcofrbOcOTWNvpO/o4/Y/+kjkU470S0ZX7w+gRQiKkMur7g83hR/M6UgOIGTkVZFTnuyk2yvPgdBsdBPVMo70C5Q7kUjC91X9uR2ZJSIUgx/NDn23rG3LHO1hw3uSMULyKQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=corigine.com; dmarc=pass action=none header.from=corigine.com; dkim=pass header.d=corigine.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=corigine.onmicrosoft.com; s=selector2-corigine-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=swqWDYNBTLpVh8dX7tnUpGjxdQSRVA6Ez43TlUrd3zw=; b=EuEk87ohnuIklw61JJH7GfqCaomvkzk3J9vhpCGZTayLo5j548K/XJ+QZqRlLBariMa37wdqrUfCRDwtKtiAV0RvNjMBNz3nN7UrcZoE0+JG8yrEcL9Qnh/4jPObFyIGI6+RdZDHBDaZkKezDVBlTLL9q9sWIxS0SbPv/UjcKvY= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=corigine.com; Received: from SJ0PR13MB5545.namprd13.prod.outlook.com (2603:10b6:a03:424::5) by CO6PR13MB5354.namprd13.prod.outlook.com (2603:10b6:303:14a::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6064.25; Fri, 3 Feb 2023 02:23:46 +0000 Received: from SJ0PR13MB5545.namprd13.prod.outlook.com ([fe80::7ea4:e421:5dd5:9f4d]) by SJ0PR13MB5545.namprd13.prod.outlook.com ([fe80::7ea4:e421:5dd5:9f4d%4]) with mapi id 15.20.6064.027; Fri, 3 Feb 2023 02:23:46 +0000 From: Chaoyong He To: dev@dpdk.org Cc: oss-drivers@corigine.com, Richard Donkin , stable@dpdk.org, Chaoyong He Subject: [PATCH] net/nfp: fix length comparison for max DMA length Date: Fri, 3 Feb 2023 10:23:28 +0800 Message-Id: <20230203022328.15674-1-chaoyong.he@corigine.com> X-Mailer: git-send-email 2.29.3 X-ClientProxiedBy: SI2PR02CA0040.apcprd02.prod.outlook.com (2603:1096:4:196::6) To SJ0PR13MB5545.namprd13.prod.outlook.com (2603:10b6:a03:424::5) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SJ0PR13MB5545:EE_|CO6PR13MB5354:EE_ X-MS-Office365-Filtering-Correlation-Id: d5bcc9f1-dd11-45b2-dd25-08db058dad5e X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: WCEJOvy0DYo6xGMheWQZRb/Rc/qgtp/EGQGci4vmqnIzPGRHH2AUwR471ygtBJLoyDA7zH7GBfpybLk9vFPoVAboMkYZMZRMldtFSk7WllPOBwl+5FL2Hy3R3e2SqjdNCVo8sOr7wZ9c/pwY0F8B0gZ+JYjFetPlnExiNgPXMYaPAnlvgVcy/CD+hv3JfjNWeZDXzbSliMAye3OyJSj/Ct+9pAgIOgOFdW5z+kYMdZhxcK9nKyg/x8iwnkQBFi2KuMtIWx4Yt9hr9LrZw0zexTy6MOHiBkzSwBfCj03CKy+w1RdyEcR+AIz9kI1wajjijRMuTxTsjaZOzeIs7EHJm+JCGRzP/twH03IxBYRo0CwnqECYCGhDCZR+plbbbB6R4uNOkenAJLp02vlY3uW/MvNrsGzZyOCez84GyQcRf98Fp7rdSaHbr2PBrQx80RZoFT/N0pzbzsgCQajjbYKUGjHcynOPnhaRaKPM5F55/TAafaf+6fkA3Zb/8BajEKE1iyZX9q8QbR4F50E6QSru7jhU5iWhFuz54YJPOaFq2P6kS8YbbRFyPyk07ueqOVGsqJRWtOp1neAq70Jm9OS5BHQNgIsm8426I6NzPEZx4vAdcgS76DlrZaCWyyS8KeldyEkpbCNusGsqbiNcnR/GtNyp7f9/FijuBbc5f39ys89xsok2haJhCEIBvnV00c9CfyFJ2a0JJXvtJXLdvnvjPg8wOdfyzREya+z6mn1TOt4= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:SJ0PR13MB5545.namprd13.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230025)(4636009)(396003)(136003)(346002)(366004)(376002)(39840400004)(451199018)(86362001)(36756003)(44832011)(38350700002)(5660300002)(38100700002)(2906002)(450100002)(66476007)(478600001)(4326008)(8676002)(41300700001)(54906003)(316002)(66946007)(66556008)(6916009)(52116002)(83380400001)(8936002)(1076003)(6666004)(107886003)(6506007)(186003)(6486002)(2616005)(6512007)(26005); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: NVOlJEZp/EoKcjbIiQB66m6Jrfqfos2m/ilEaX1qWSmLsibMYpAFd8+ZoywzbCPyutxxdpdQYHEF21lQtiEIZXyWEY78xjEhYouyh5vjRr6E36u3RPVBIpHHhlgtUxmA5mp+V09S4AIpnq157GiSmwSmkWpdOB4E9nOFWc1EhlSGeqVsvz+piOIVkInmmbMRHcfvrSHcSW51m6Gz6fZAQV7cBWw2d3u0ANlZoQSG6nMjaMDiTrcNqBuBlVcaKboY2RPjKJxw7o7ZsgndCKAESdT+/7g5zR6c5oFu32WzGHZ5uVqvDeC5GszEHBEOUdTb4bRR7rgBA+N4Thwf+vCi771rz1xS+9FDcmt2a/TYJxwh+WX7ZUe9/P8b3jMifd4b0PmJesdE5jzlOVOxKDEt3YvGH7fnxmlFCRLyMCHN3ioR2jEz1OPrLMBJst0/KWKfcqOCqnbEpdoue35kvCRaVQnBpWy+08hLAASNgBuf7p8ioDaKXQ+WO6hoPHZRjMInC+a+IIIXyeBThUk7Et6gpV1bnvSs//7hoGzxzvWmQBiCsiOSwtvw0CECeLdT/S36nioqHV2n16FwRFyyubClHsE3PWjnT5I4J1FcnxZXXzMg7M1s+aBdCY385a+C/nNnddhpjdgfEaqGXiGm0vA3kvysvXzpENMNcbeNJiXxS1EfxWwNoEDeHaq71tCkZO2+UDoiIJM72D9P28o3OW8SV8jKudz0NNZziXG6ApA/7n7vuUcVlY421LB0xYxLNjSGJRCzVaijAuxycszA7QmrhxdT3fFKhYS0UETOWEjTTPfIiQm3QyqRUz13/fvAYcAMBKHt9McTLJ++A3Q+WKG5WIBXD1dF/yV5H97QAVMC5YS70Yyiz2jqqVxQfIQz/LKVdm8jUT4oocGbdQfIvosqiAhyGd4Ktyasg8qvHWbEQAZyZ5yN+FGIqSh+l8Z9dQcGhbbtmDtoWpLb9krSay73ageRrOq/9IP0tD0boptjjws0Q6FHGK+Zn/qI3rwEysj29hzm4YZuQbzsyo3XtN8LII4n39GvArjxjkSjV9alnTVeNcNS8VYckWZ64/RTR7tzw32cfG6kS2HT5G5h1VJXKyJv9UOITzVxzSLxE0flQ5lXbn2x1y7fvRm+Lnve4VGzqk+k4GIFQHtE+B+DXG2f71H/NnUJG48Cp69TpCF9PwzixhkWTkLqACEWLBz26J30tEjjM7vqTQ7oLEsHh/H/W59nUlXcUVJSEo/1Cu2NG6gucrl8zMQjIuJwQQsALkmrPvTaZtdfmZGCgo9vC4h2ivTxtf3KuF+4vmzSUXEfKHzNO8bexuzM+bjR7ZotsHrXVnt8JGzlxf8bFgc8zFGPbYYdUL6zu9HNrTmzzOcv1mIpNQhN2Y3+kxS5QV1lAW8vj13IaPsMxVh2B5oYA+rxmTvwmTyIaIq8FvTQiYnVXBdXqfyNSVLoBa8xXTU/ysdOfTeNHbPvveeeAifEMD6w8vNuiQ3cJdsFGuRSmTi1G20dg5pqJRRIbRtA7irY8Mx/qws8wlBCKGQjqQeY/XlQ7hErQX7ZgK84rOsLH6VeXjfRvf0pJ3/bJaQety49pbWRCS++jBv8St93ipe/49DABQ== X-OriginatorOrg: corigine.com X-MS-Exchange-CrossTenant-Network-Message-Id: d5bcc9f1-dd11-45b2-dd25-08db058dad5e X-MS-Exchange-CrossTenant-AuthSource: SJ0PR13MB5545.namprd13.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Feb 2023 02:23:46.2134 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: fe128f2c-073b-4c20-818e-7246a585940c X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: jsAFxLHW4M88IyUrRY6rwLGBZs82DQUgjsE5w1R/VRRNlhlElU68JGqAtE9fnYfmKz2HgFY7FjKcoKdYLhoRuFDFutvx5f4+0jU5aik9mYc= X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO6PR13MB5354 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org From: Richard Donkin The DMA transfer length is allowed to be as large as NFDK_TX_MAX_DATA_PER_HEAD. The existing check would not allow a simple- type descriptor to be created for a packet of size NFDK_TX_MAX_DATA_PER_HEAD, but it would also not enable gather-type descriptors to be created correctly later. Change the limit of simple-type descriptors to include packets of size NFDK_TX_MAX_DATA_PER_HEAD. In practice this fixes traffic with packets of size 4096. Previously such packets would not be transmitted correctly. Fixes: c73dced48c8c ("net/nfp: add NFDk Tx") Cc: stable@dpdk.org Signed-off-by: Richard Donkin Reviewed-by: Chaoyong He --- drivers/net/nfp/nfp_rxtx.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/nfp/nfp_rxtx.c b/drivers/net/nfp/nfp_rxtx.c index 01cffdfde0..fa4cc94a43 100644 --- a/drivers/net/nfp/nfp_rxtx.c +++ b/drivers/net/nfp/nfp_rxtx.c @@ -1214,7 +1214,7 @@ nfp_net_nfdk_xmit_pkts(void *tx_queue, struct rte_mbuf **tx_pkts, uint16_t nb_pk if ((hw->cap & NFP_NET_CFG_CTRL_LSO_ANY) && (pkt->ol_flags & RTE_MBUF_F_TX_TCP_SEG)) { type = NFDK_DESC_TX_TYPE_TSO; - } else if (!pkt->next && dma_len < NFDK_TX_MAX_DATA_PER_HEAD) { + } else if (!pkt->next && dma_len <= NFDK_TX_MAX_DATA_PER_HEAD) { type = NFDK_DESC_TX_TYPE_SIMPLE; } else { type = NFDK_DESC_TX_TYPE_GATHER;