diff mbox series

[3/4] examples/qos_sched: use bigger bursts on dequeue

Message ID 20230203100533.10377-4-bruce.richardson@intel.com (mailing list archive)
State Accepted, archived
Delegated to: Thomas Monjalon
Headers
Series small fixes and improvements for qos_sched example |

Checks

Context Check Description
ci/checkpatch success coding style OK

Commit Message

Bruce Richardson Feb. 3, 2023, 10:05 a.m. UTC 
  While performance of the QoS block drops sharply if the dequeue size is
greater than or equal to the enqueue size, increasing the dequeue size
to just under the enqueue one gives improved performance when the
scheduler is not keeping up with the line rate.

Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
---
 doc/guides/sample_app_ug/qos_scheduler.rst | 2 +-
 examples/qos_sched/main.h                  | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

--
2.37.2

Comments

Cristian Dumitrescu Feb. 17, 2023, 4:20 p.m. UTC | #1 
> -----Original Message-----
> From: Richardson, Bruce <bruce.richardson@intel.com>
> Sent: Friday, February 3, 2023 10:06 AM
> To: dev@dpdk.org
> Cc: Singh, Jasvinder <jasvinder.singh@intel.com>; Richardson, Bruce
> <bruce.richardson@intel.com>; Dumitrescu, Cristian
> <cristian.dumitrescu@intel.com>
> Subject: [PATCH 3/4] examples/qos_sched: use bigger bursts on dequeue
> 
> While performance of the QoS block drops sharply if the dequeue size is
> greater than or equal to the enqueue size, increasing the dequeue size
> to just under the enqueue one gives improved performance when the
> scheduler is not keeping up with the line rate.
> 
> Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
> ---
>  doc/guides/sample_app_ug/qos_scheduler.rst | 2 +-
>  examples/qos_sched/main.h                  | 2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)
> 
Acked-by: Cristian Dumitrescu <cristian.dumitrescu@intel.com>
diff mbox series

Patch

diff --git a/doc/guides/sample_app_ug/qos_scheduler.rst b/doc/guides/sample_app_ug/qos_scheduler.rst
index f376554dd9..9936b99172 100644
--- a/doc/guides/sample_app_ug/qos_scheduler.rst
+++ b/doc/guides/sample_app_ug/qos_scheduler.rst
@@ -91,7 +91,7 @@  Optional application parameters include:
 *   B = I/O RX lcore write burst size to the output software rings,
     worker lcore read burst size from input software rings,QoS enqueue size (the default value is 64)

-*   C = QoS dequeue size (the default value is 32)
+*   C = QoS dequeue size (the default value is 63)

 *   D = Worker lcore write burst size to the NIC TX (the default value is 64)

diff --git a/examples/qos_sched/main.h b/examples/qos_sched/main.h
index b9c301483a..d8f3e32c83 100644
--- a/examples/qos_sched/main.h
+++ b/examples/qos_sched/main.h
@@ -26,7 +26,7 @@  extern "C" {

 #define MAX_PKT_RX_BURST 64
 #define PKT_ENQUEUE 64
-#define PKT_DEQUEUE 32
+#define PKT_DEQUEUE 63
 #define MAX_PKT_TX_BURST 64

 #define RX_PTHRESH 8 /**< Default values of RX prefetch threshold reg. */