diff mbox series

[23.07,1/2] build: fix case of project language name

Message ID 20230310111138.92282-2-bruce.richardson@intel.com (mailing list archive)
State Accepted, archived
Delegated to: Thomas Monjalon
Headers
Series Minor meson build improvements |

Checks

Context Check Description
ci/checkpatch warning coding style issues

Commit Message

Bruce Richardson March 10, 2023, 11:11 a.m. UTC 
  According to the meson manual [1], the project language should be given
as 'c', rather than 'C' in the initial "project" function call. While
meson itself does not complain about this, the "muon" project, which
attempts to re-implement meson in C, does complain.

/home/bruce/dpdk/meson.build:4:17: error 'C' is not a valid language
  4 | project('DPDK', 'C',
                      ^

[1] https://mesonbuild.com/Reference-manual_functions.html#project

Fixes: a25a650be5f0 ("build: add infrastructure for meson and ninja builds")

Signed-off-by: Bruce richardson <bruce.richardson@intel.com>
---
 meson.build | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Tyler Retzlaff March 13, 2023, 11:50 p.m. UTC | #1 
On Fri, Mar 10, 2023 at 11:11:37AM +0000, Bruce Richardson wrote:
> According to the meson manual [1], the project language should be given
> as 'c', rather than 'C' in the initial "project" function call. While
> meson itself does not complain about this, the "muon" project, which
> attempts to re-implement meson in C, does complain.
> 
> /home/bruce/dpdk/meson.build:4:17: error 'C' is not a valid language
>   4 | project('DPDK', 'C',
>                       ^
> 
> [1] https://mesonbuild.com/Reference-manual_functions.html#project
> 
> Fixes: a25a650be5f0 ("build: add infrastructure for meson and ninja builds")
> 
> Signed-off-by: Bruce richardson <bruce.richardson@intel.com>
> ---

Reviewed-by: Tyler Retzlaff <roretzla@linux.microsoft.com>
diff mbox series

Patch

diff --git a/meson.build b/meson.build
index f91d652bc5..992ca91e88 100644
--- a/meson.build
+++ b/meson.build
@@ -1,7 +1,7 @@ 
 # SPDX-License-Identifier: BSD-3-Clause
 # Copyright(c) 2017-2019 Intel Corporation
 
-project('DPDK', 'C',
+project('DPDK', 'c',
         # Get version number from file.
         # Fallback to "more" for Windows compatibility.
         version: run_command(find_program('cat', 'more'),