diff mbox series

[2/2] config/arm: Enable NUMA for generic Arm build

Message ID 20230414124139.66443-3-akihiko.odaki@daynix.com (mailing list archive)
State Rejected, archived
Delegated to: Thomas Monjalon
Headers
Series Enable generic Arm build |

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/loongarch-compilation success Compilation OK
ci/loongarch-unit-testing success Unit Testing PASS
ci/Intel-compilation success Compilation OK
ci/github-robot: build success github build: passed
ci/intel-Testing success Testing PASS
ci/iol-mellanox-Performance success Performance Testing PASS
ci/iol-broadcom-Performance success Performance Testing PASS
ci/iol-aarch64-unit-testing success Testing PASS
ci/iol-unit-testing success Testing PASS
ci/iol-abi-testing success Testing PASS
ci/iol-aarch64-compile-testing success Testing PASS
ci/iol-x86_64-compile-testing success Testing PASS
ci/intel-Functional success Functional PASS
ci/iol-intel-Functional success Functional Testing PASS
ci/iol-intel-Performance success Performance Testing PASS
ci/iol-broadcom-Functional success Functional Testing PASS
ci/iol-testing success Testing PASS
ci/iol-x86_64-unit-testing success Testing PASS

Commit Message

Akihiko Odaki April 14, 2023, 12:41 p.m. UTC 
  We enable NUMA even if the presence of NUMA is unknown for the other
architectures. Enable NUMA for generic Arm build too.

Signed-off-by: Akihiko Odaki <akihiko.odaki@daynix.com>
---
 config/arm/meson.build | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

Comments

Ruifeng Wang April 20, 2023, 7:20 a.m. UTC | #1 
> -----Original Message-----
> From: Akihiko Odaki <akihiko.odaki@daynix.com>
> Sent: Friday, April 14, 2023 8:42 PM
> To: Ruifeng Wang <Ruifeng.Wang@arm.com>; Bruce Richardson <bruce.richardson@intel.com>
> Cc: dev@dpdk.org; Akihiko Odaki <akihiko.odaki@daynix.com>
> Subject: [PATCH 2/2] config/arm: Enable NUMA for generic Arm build
> 
> We enable NUMA even if the presence of NUMA is unknown for the other architectures. Enable
> NUMA for generic Arm build too.
> 
> Signed-off-by: Akihiko Odaki <akihiko.odaki@daynix.com>
> ---
>  config/arm/meson.build | 6 ++++--
>  1 file changed, 4 insertions(+), 2 deletions(-)
> 
> diff --git a/config/arm/meson.build b/config/arm/meson.build index 724c00ad7e..f8ee7cdafb
> 100644
> --- a/config/arm/meson.build
> +++ b/config/arm/meson.build
> @@ -271,13 +271,15 @@ implementers = {
>  soc_generic = {
>      'description': 'Generic un-optimized build for armv8 aarch64 exec mode',
>      'implementer': 'generic',
> -    'part_number': 'generic'
> +    'part_number': 'generic',
> +    'numa': true

The default value of numa is true. So no need to add it here?

if not soc_config.get('numa', true)
    has_libnuma = 0
endif

>  }
> 
>  soc_generic_aarch32 = {
>      'description': 'Generic un-optimized build for armv8 aarch32 exec mode',
>      'implementer': 'generic',
> -    'part_number': 'generic_aarch32'
> +    'part_number': 'generic_aarch32',
> +    'numa': true
>  }
> 
>  soc_armada = {
> --
> 2.40.0
Akihiko Odaki April 22, 2023, 5:26 a.m. UTC | #2 
On 2023/04/20 16:20, Ruifeng Wang wrote:
>> -----Original Message-----
>> From: Akihiko Odaki <akihiko.odaki@daynix.com>
>> Sent: Friday, April 14, 2023 8:42 PM
>> To: Ruifeng Wang <Ruifeng.Wang@arm.com>; Bruce Richardson <bruce.richardson@intel.com>
>> Cc: dev@dpdk.org; Akihiko Odaki <akihiko.odaki@daynix.com>
>> Subject: [PATCH 2/2] config/arm: Enable NUMA for generic Arm build
>>
>> We enable NUMA even if the presence of NUMA is unknown for the other architectures. Enable
>> NUMA for generic Arm build too.
>>
>> Signed-off-by: Akihiko Odaki <akihiko.odaki@daynix.com>
>> ---
>>   config/arm/meson.build | 6 ++++--
>>   1 file changed, 4 insertions(+), 2 deletions(-)
>>
>> diff --git a/config/arm/meson.build b/config/arm/meson.build index 724c00ad7e..f8ee7cdafb
>> 100644
>> --- a/config/arm/meson.build
>> +++ b/config/arm/meson.build
>> @@ -271,13 +271,15 @@ implementers = {
>>   soc_generic = {
>>       'description': 'Generic un-optimized build for armv8 aarch64 exec mode',
>>       'implementer': 'generic',
>> -    'part_number': 'generic'
>> +    'part_number': 'generic',
>> +    'numa': true
> 
> The default value of numa is true. So no need to add it here?
> 
> if not soc_config.get('numa', true)
>      has_libnuma = 0
> endif

You're right. I confirmed this change is unnecessary. Please ignore this 
patch and consider merging only the first patch of this series.

> 
>>   }
>>
>>   soc_generic_aarch32 = {
>>       'description': 'Generic un-optimized build for armv8 aarch32 exec mode',
>>       'implementer': 'generic',
>> -    'part_number': 'generic_aarch32'
>> +    'part_number': 'generic_aarch32',
>> +    'numa': true
>>   }
>>
>>   soc_armada = {
>> --
>> 2.40.0
>
diff mbox series

Patch

diff --git a/config/arm/meson.build b/config/arm/meson.build
index 724c00ad7e..f8ee7cdafb 100644
--- a/config/arm/meson.build
+++ b/config/arm/meson.build
@@ -271,13 +271,15 @@  implementers = {
 soc_generic = {
     'description': 'Generic un-optimized build for armv8 aarch64 exec mode',
     'implementer': 'generic',
-    'part_number': 'generic'
+    'part_number': 'generic',
+    'numa': true
 }
 
 soc_generic_aarch32 = {
     'description': 'Generic un-optimized build for armv8 aarch32 exec mode',
     'implementer': 'generic',
-    'part_number': 'generic_aarch32'
+    'part_number': 'generic_aarch32',
+    'numa': true
 }
 
 soc_armada = {