diff mbox series

[v2,3/3] app/eventdev: prevent mempool exhaustion

Message ID 20230425195110.4223-3-pbhagavatula@marvell.com (mailing list archive)
State Accepted, archived
Delegated to: Jerin Jacob
Headers
Series [v2,1/3] event/cnxk: use LMTST for enqueue new burst |

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/loongarch-compilation success Compilation OK
ci/loongarch-unit-testing success Unit Testing PASS
ci/iol-broadcom-Performance success Performance Testing PASS
ci/iol-mellanox-Performance success Performance Testing PASS
ci/iol-broadcom-Functional success Functional Testing PASS
ci/iol-intel-Performance success Performance Testing PASS
ci/iol-intel-Functional success Functional Testing PASS
ci/iol-aarch64-unit-testing success Testing PASS
ci/github-robot: build success github build: passed
ci/iol-unit-testing success Testing PASS
ci/iol-abi-testing success Testing PASS
ci/iol-x86_64-compile-testing success Testing PASS
ci/iol-aarch64-compile-testing success Testing PASS
ci/iol-testing success Testing PASS
ci/iol-x86_64-unit-testing success Testing PASS
ci/Intel-compilation success Compilation OK
ci/intel-Testing success Testing PASS
ci/intel-Functional success Functional PASS

Commit Message

Pavan Nikhilesh Bhagavatula April 25, 2023, 7:51 p.m. UTC 
  From: Pavan Nikhilesh <pbhagavatula@marvell.com>

Prevent mempool exhaustion due to elements being stuck in lcore
local caches.

Signed-off-by: Pavan Nikhilesh <pbhagavatula@marvell.com>
---
 app/test-eventdev/test_perf_common.c | 11 ++++++-----
 1 file changed, 6 insertions(+), 5 deletions(-)

Comments

Shijith Thotton May 18, 2023, 3:47 p.m. UTC | #1 
>From: Pavan Nikhilesh <pbhagavatula@marvell.com>
>
>Prevent mempool exhaustion due to elements being stuck in lcore
>local caches.
>
>Signed-off-by: Pavan Nikhilesh <pbhagavatula@marvell.com>

Acked-by: Shijith Thotton <sthotton@marvell.com>

>---
> app/test-eventdev/test_perf_common.c | 11 ++++++-----
> 1 file changed, 6 insertions(+), 5 deletions(-)
>
>diff --git a/app/test-eventdev/test_perf_common.c b/app/test-
>eventdev/test_perf_common.c
>index 68af3cb346..5e0255cfeb 100644
>--- a/app/test-eventdev/test_perf_common.c
>+++ b/app/test-eventdev/test_perf_common.c
>@@ -1859,34 +1859,35 @@ int
> perf_mempool_setup(struct evt_test *test, struct evt_options *opt)
> {
> 	struct test_perf *t = evt_test_priv(test);
>+	unsigned int cache_sz;
>
>+	cache_sz = RTE_MIN(RTE_MEMPOOL_CACHE_MAX_SIZE, (opt->pool_sz /
>1.5) / t->nb_workers);
> 	if (opt->prod_type == EVT_PROD_TYPE_SYNT ||
> 			opt->prod_type ==
>EVT_PROD_TYPE_EVENT_TIMER_ADPTR) {
> 		t->pool = rte_mempool_create(test->name, /* mempool name */
> 				opt->pool_sz, /* number of elements*/
> 				sizeof(struct perf_elt), /* element size*/
>-				512, /* cache size*/
>+				cache_sz, /* cache size*/
> 				0, NULL, NULL,
> 				perf_elt_init, /* obj constructor */
> 				NULL, opt->socket_id, 0); /* flags */
> 	} else if (opt->prod_type == EVT_PROD_TYPE_EVENT_CRYPTO_ADPTR &&
>-			opt->crypto_op_type ==
>RTE_CRYPTO_OP_TYPE_ASYMMETRIC)  {
>+		   opt->crypto_op_type == RTE_CRYPTO_OP_TYPE_ASYMMETRIC)
>{
> 		t->pool = rte_mempool_create(test->name, /* mempool name */
> 				opt->pool_sz, /* number of elements*/
> 				sizeof(struct perf_elt) +
>modex_test_case.result_len,
> 				/* element size*/
>-				512, /* cache size*/
>+				cache_sz, /* cache size*/
> 				0, NULL, NULL,
> 				NULL, /* obj constructor */
> 				NULL, opt->socket_id, 0); /* flags */
> 	} else {
> 		t->pool = rte_pktmbuf_pool_create(test->name, /* mempool
>name */
> 				opt->pool_sz, /* number of elements*/
>-				512, /* cache size*/
>+				cache_sz, /* cache size*/
> 				0,
> 				RTE_MBUF_DEFAULT_BUF_SIZE,
> 				opt->socket_id); /* flags */
>-
> 	}
>
> 	if (t->pool == NULL) {
>--
>2.25.1
diff mbox series

Patch

diff --git a/app/test-eventdev/test_perf_common.c b/app/test-eventdev/test_perf_common.c
index 68af3cb346..5e0255cfeb 100644
--- a/app/test-eventdev/test_perf_common.c
+++ b/app/test-eventdev/test_perf_common.c
@@ -1859,34 +1859,35 @@  int
 perf_mempool_setup(struct evt_test *test, struct evt_options *opt)
 {
 	struct test_perf *t = evt_test_priv(test);
+	unsigned int cache_sz;
 
+	cache_sz = RTE_MIN(RTE_MEMPOOL_CACHE_MAX_SIZE, (opt->pool_sz / 1.5) / t->nb_workers);
 	if (opt->prod_type == EVT_PROD_TYPE_SYNT ||
 			opt->prod_type == EVT_PROD_TYPE_EVENT_TIMER_ADPTR) {
 		t->pool = rte_mempool_create(test->name, /* mempool name */
 				opt->pool_sz, /* number of elements*/
 				sizeof(struct perf_elt), /* element size*/
-				512, /* cache size*/
+				cache_sz, /* cache size*/
 				0, NULL, NULL,
 				perf_elt_init, /* obj constructor */
 				NULL, opt->socket_id, 0); /* flags */
 	} else if (opt->prod_type == EVT_PROD_TYPE_EVENT_CRYPTO_ADPTR &&
-			opt->crypto_op_type == RTE_CRYPTO_OP_TYPE_ASYMMETRIC)  {
+		   opt->crypto_op_type == RTE_CRYPTO_OP_TYPE_ASYMMETRIC) {
 		t->pool = rte_mempool_create(test->name, /* mempool name */
 				opt->pool_sz, /* number of elements*/
 				sizeof(struct perf_elt) + modex_test_case.result_len,
 				/* element size*/
-				512, /* cache size*/
+				cache_sz, /* cache size*/
 				0, NULL, NULL,
 				NULL, /* obj constructor */
 				NULL, opt->socket_id, 0); /* flags */
 	} else {
 		t->pool = rte_pktmbuf_pool_create(test->name, /* mempool name */
 				opt->pool_sz, /* number of elements*/
-				512, /* cache size*/
+				cache_sz, /* cache size*/
 				0,
 				RTE_MBUF_DEFAULT_BUF_SIZE,
 				opt->socket_id); /* flags */
-
 	}
 
 	if (t->pool == NULL) {