From patchwork Thu May 4 17:36:12 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ajit Khaparde X-Patchwork-Id: 126695 X-Patchwork-Delegate: ajit.khaparde@broadcom.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 3BC7342A65; Thu, 4 May 2023 19:38:00 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id CD42742D63; Thu, 4 May 2023 19:36:43 +0200 (CEST) Received: from mail-pf1-f179.google.com (mail-pf1-f179.google.com [209.85.210.179]) by mails.dpdk.org (Postfix) with ESMTP id 941AE42D85 for ; Thu, 4 May 2023 19:36:40 +0200 (CEST) Received: by mail-pf1-f179.google.com with SMTP id d2e1a72fcca58-6438d95f447so566065b3a.3 for ; Thu, 04 May 2023 10:36:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; t=1683221799; x=1685813799; h=mime-version:references:in-reply-to:message-id:date:subject:cc:to :from:from:to:cc:subject:date:message-id:reply-to; bh=DqJNrIMPxBVU3673Zzn4Au2tlOHaH4PaDBMnuoTX2/Y=; b=HtsmLT2sjAudCBT5Wwtze3HrafpB7sitxuggZtBu82yE2/V5bKuxQQi9AieS7jKeMT y1nmf/bO39slgpVwb5ThFX6xqqts6fOfYkWHxdkQy84pVITnIuBdNSKpoufBmoi1Wj/+ T+eEL2kjSADUPz+dB5rYVzRrUN/Qrz3fwmXNw= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1683221799; x=1685813799; h=mime-version:references:in-reply-to:message-id:date:subject:cc:to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=DqJNrIMPxBVU3673Zzn4Au2tlOHaH4PaDBMnuoTX2/Y=; b=WEa9MPDQfqXgnKgzCR3KowBFj6AbgcWtFR30/3JUUwO1ETIIUM2SuQIprqzhlUhluH K6G/ugG28VMyglJZn/bV9spuVrkrLUh3GnHXLLyCWwB5ZhGn/H/8DrZa8DPbot7gS2+c dAJkjrRo1npBqHcaxEAPrUpQ4u6yGkuvTmO4Ew8DDegAxKCmKcQS8V0OzYVyc1IMc604 OcPHCs6aCyD2rG5r6osK2vQ6f9JTLZQHEeVX7hNPc350zBpjj9Wmy1dSriC7P3jvTt2T EvJYMLh8Vg6MdSm/N7gVSuzlFPH5ep98K6ax/F7rsozhl90hND/+rhPQ4ydc7eAWONr3 sZCw== X-Gm-Message-State: AC+VfDxVSPSzfK5NOwVImGAyUU7McsbAebko/fgWOgdS+yzOrhVBxytC 2v+gejIHm0fWovSoOP45ZuSqwoq3TngYGLNxH6sz4hoGzoPe9A2x8vnN56tJNGgAd8wHXT67R6B gXd+hMBSj5sSd1/r3XEoY1MbTMH5vUTcyusrm3yfRbsLRIgzDAAAjf1r5yzg/XKN+CzQ9 X-Google-Smtp-Source: ACHHUZ4xcuyRdJkQHMgPaWLI89/2qRKIF8e+WkOw9VDf81ZFn97vsBlHQZ4L3aT3ST7s1svZhHXCqQ== X-Received: by 2002:a05:6a00:22cc:b0:641:24bb:bbb1 with SMTP id f12-20020a056a0022cc00b0064124bbbbb1mr3552868pfj.27.1683221799049; Thu, 04 May 2023 10:36:39 -0700 (PDT) Received: from localhost.localdomain ([192.19.223.252]) by smtp.gmail.com with ESMTPSA id v11-20020aa7850b000000b0062bc045bf4fsm26305230pfn.19.2023.05.04.10.36.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 04 May 2023 10:36:38 -0700 (PDT) From: Ajit Khaparde To: dev@dpdk.org Cc: Shuanglin Wang , Kishore Padmanabha , Mike Baucom Subject: [PATCH v3 11/11] net/bnxt: set RSS config based on RSS mode Date: Thu, 4 May 2023 10:36:12 -0700 Message-Id: <20230504173612.17696-12-ajit.khaparde@broadcom.com> X-Mailer: git-send-email 2.39.2 (Apple Git-143) In-Reply-To: <20230504173612.17696-1-ajit.khaparde@broadcom.com> References: <20230504173612.17696-1-ajit.khaparde@broadcom.com> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org From: Shuanglin Wang Avoid submitting hwrm RSS request when rss mode disabled. On WH+, if rss mode isn't enabled, then there is no rss context. Submitting HWRM_VNIC_RSS_CFG request to firmware would hit a failure. The fix is to check the rss context. If no rss context, then don't submit the hwrm request. Signed-off-by: Shuanglin Wang Signed-off-by: Kishore Padmanabha Reviewed-by: Mike Baucom Reviewed-by: Ajit Khaparde --- drivers/net/bnxt/bnxt_hwrm.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/net/bnxt/bnxt_hwrm.c b/drivers/net/bnxt/bnxt_hwrm.c index b944547656..06f196760f 100644 --- a/drivers/net/bnxt/bnxt_hwrm.c +++ b/drivers/net/bnxt/bnxt_hwrm.c @@ -2405,6 +2405,9 @@ bnxt_hwrm_vnic_rss_cfg_non_p5(struct bnxt *bp, struct bnxt_vnic_info *vnic) struct hwrm_vnic_rss_cfg_output *resp = bp->hwrm_cmd_resp_addr; int rc = 0; + if (vnic->num_lb_ctxts == 0) + return rc; + HWRM_PREP(&req, HWRM_VNIC_RSS_CFG, BNXT_USE_CHIMP_MB); req.hash_type = rte_cpu_to_le_32(vnic->hash_type);