From patchwork Wed May 17 16:15:52 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephen Hemminger X-Patchwork-Id: 126933 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id A6AAD42B2C; Wed, 17 May 2023 18:17:10 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id C8B9D42D64; Wed, 17 May 2023 18:16:22 +0200 (CEST) Received: from mail-pf1-f180.google.com (mail-pf1-f180.google.com [209.85.210.180]) by mails.dpdk.org (Postfix) with ESMTP id 5485842D38 for ; Wed, 17 May 2023 18:16:18 +0200 (CEST) Received: by mail-pf1-f180.google.com with SMTP id d2e1a72fcca58-644d9bf05b7so741178b3a.3 for ; Wed, 17 May 2023 09:16:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20221208.gappssmtp.com; s=20221208; t=1684340177; x=1686932177; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=E+g3LGv1MimqAdKQP79DQNEodaidHvBBomLqdvw/v70=; b=V88f3oV+9syrIfOIR75V3e/pDoZAlU0eqJUQMWxTWZOyjP/6XE6yblFBaS1IO/LKwL Us+ACpfZbULZpGA49b/yuA6yA36CYrI6tGq/DdjAlzUvr2NJVznpofK0y8JzdtglLuSu 8JQbVoUAY7j/ZWrIhLRZM3TuTcx3e5xpsfDaaKfjLXkAlsqF0k7I5gZjBZo6TDQ3AHfm uIX/xRaGI8eKzl5u+Cm73RguESRxX+sJ7SAAOHQIUGoozER/W6UOUzIFRv1eMzmbD2SF fBYETQnFHuLPbIs3p7PF/ijazVy5hbNTJyVsuRIrTamSBowLPFdOxlnHdfNRuRo60Zgc g1jA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1684340177; x=1686932177; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=E+g3LGv1MimqAdKQP79DQNEodaidHvBBomLqdvw/v70=; b=FjvR3PoFkdDsFGTw/7RouBzqyTyVRtyaUwowdaAnAknyXwsyLhVtswwK3A76E+j10l /GpqZILIhnvO/c90dkDu/L4c+G/7m2LNdLt9XDGC4h1lNPB1PkXJnaQPS8mlyCGCmkIC AvOzEayiqI3JLwd08TgT9HUY1w4LOggFfT1PkAMsMk1VRkBZFKJaXYBEvH/0XDRkIquG 2pQ+YYk2el1vDLr6yZZcfUdF19RtZ///qZr5YfJBcgPg5z5SQ0Re9GFGAHLHD3NDSF3p gyJ+3ZwSyAV7uZu0p3t0+M76HgCdrA1msmfpapgof0V+b78RsVlM2oteKMDlzyvWq9Ve gN4Q== X-Gm-Message-State: AC+VfDzZ6pZw6rKkAmBaJuyXzUTBnQKaE40D3Hst7jrwmCpZM3ojcDWL ZkZ+m7jCNC5+dUrx+Wd54ZWnXMF6WM+XnQNkKCRdzQ== X-Google-Smtp-Source: ACHHUZ71xcJ42lrxRSr7VyoDC+umhF2tXr3JoviJ8VPHcycpGsn9W8AzZCbIX+vQu53IyOEZSeONdQ== X-Received: by 2002:a05:6a20:9184:b0:106:dfc8:6f5b with SMTP id v4-20020a056a20918400b00106dfc86f5bmr8608592pzd.50.1684340177575; Wed, 17 May 2023 09:16:17 -0700 (PDT) Received: from hermes.local (204-195-120-218.wavecable.com. [204.195.120.218]) by smtp.gmail.com with ESMTPSA id h5-20020a62b405000000b0063f33e216dasm15793009pfn.96.2023.05.17.09.16.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 17 May 2023 09:16:17 -0700 (PDT) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger , Qi Zhang , Xiao Wang , Qiming Yang , Wenjun Wu Subject: [PATCH 09/20] net/fm10k, net/ixgbe: remove word sanity Date: Wed, 17 May 2023 09:15:52 -0700 Message-Id: <20230517161603.117728-10-stephen@networkplumber.org> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20230517161603.117728-1-stephen@networkplumber.org> References: <20230517161603.117728-1-stephen@networkplumber.org> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Remove non-inclusive term sanity from these Intel drivers. Signed-off-by: Stephen Hemminger --- drivers/net/fm10k/fm10k_ethdev.c | 2 +- drivers/net/fm10k/fm10k_rxtx.c | 2 +- drivers/net/ixgbe/ixgbe_fdir.c | 2 +- drivers/net/ixgbe/ixgbe_ipsec.c | 2 +- drivers/net/ixgbe/ixgbe_rxtx.c | 2 +- 5 files changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/net/fm10k/fm10k_ethdev.c b/drivers/net/fm10k/fm10k_ethdev.c index 4d3c4c10cfa4..894cf8c8a6b5 100644 --- a/drivers/net/fm10k/fm10k_ethdev.c +++ b/drivers/net/fm10k/fm10k_ethdev.c @@ -1757,7 +1757,7 @@ mempool_element_size_valid(struct rte_mempool *mp) /* account for up to 512B of alignment */ min_size -= FM10K_RX_DATABUF_ALIGN; - /* sanity check for overflow */ + /* check for overflow */ if (min_size > mp->elt_size) return 0; diff --git a/drivers/net/fm10k/fm10k_rxtx.c b/drivers/net/fm10k/fm10k_rxtx.c index c0841ab8cb34..94345299b22a 100644 --- a/drivers/net/fm10k/fm10k_rxtx.c +++ b/drivers/net/fm10k/fm10k_rxtx.c @@ -647,7 +647,7 @@ fm10k_xmit_pkts(void *tx_queue, struct rte_mbuf **tx_pkts, if (q->nb_free < mb->nb_segs) break; - /* sanity check to make sure the mbuf is valid */ + /* check to make sure the mbuf is valid */ if ((mb->nb_segs == 0) || ((mb->nb_segs > 1) && (mb->next == NULL))) break; diff --git a/drivers/net/ixgbe/ixgbe_fdir.c b/drivers/net/ixgbe/ixgbe_fdir.c index 06d6e2126de5..51bbf577e3fe 100644 --- a/drivers/net/ixgbe/ixgbe_fdir.c +++ b/drivers/net/ixgbe/ixgbe_fdir.c @@ -1130,7 +1130,7 @@ ixgbe_fdir_filter_program(struct rte_eth_dev *dev, return -ENOTSUP; /* - * Sanity check for x550. + * Check for x550. * When adding a new filter with flow type set to IPv4, * the flow director mask should be configed before, * and the L4 protocol and ports are masked. diff --git a/drivers/net/ixgbe/ixgbe_ipsec.c b/drivers/net/ixgbe/ixgbe_ipsec.c index d3313085560d..d4aa3e9ede8e 100644 --- a/drivers/net/ixgbe/ixgbe_ipsec.c +++ b/drivers/net/ixgbe/ixgbe_ipsec.c @@ -615,7 +615,7 @@ ixgbe_crypto_enable_ipsec(struct rte_eth_dev *dev) rx_offloads = dev->data->dev_conf.rxmode.offloads; tx_offloads = dev->data->dev_conf.txmode.offloads; - /* sanity checks */ + /* input validation */ if (rx_offloads & RTE_ETH_RX_OFFLOAD_TCP_LRO) { PMD_DRV_LOG(ERR, "RSC and IPsec not supported"); return -1; diff --git a/drivers/net/ixgbe/ixgbe_rxtx.c b/drivers/net/ixgbe/ixgbe_rxtx.c index c9d6ca9efea4..72f89b1b51fd 100644 --- a/drivers/net/ixgbe/ixgbe_rxtx.c +++ b/drivers/net/ixgbe/ixgbe_rxtx.c @@ -4907,7 +4907,7 @@ ixgbe_set_rsc(struct rte_eth_dev *dev) uint32_t rdrxctl; uint32_t rfctl; - /* Sanity check */ + /* Offload check */ dev->dev_ops->dev_infos_get(dev, &dev_info); if (dev_info.rx_offload_capa & RTE_ETH_RX_OFFLOAD_TCP_LRO) rsc_capable = true;